Compare commits

..

344 Commits

Author SHA1 Message Date
37991642dc nightly 2023-03-01 00:46:18 +01:00
1038b7f2c7 wip GovernorPreventLateQuorum 2023-02-28 23:33:12 +01:00
7dc201fce9 fix some specs 2023-02-28 22:57:43 +01:00
bf73fb4013 fix GovernorPreventLateQuorum.spec 2023-02-28 18:35:03 +01:00
6c4ffe783f cleanup accesscontrol specs 2023-02-28 17:12:15 +01:00
f21f86c3c1 fixing certora/specs/GovernorCountingSimple.spec 2023-02-28 16:09:35 +01:00
2e7bca424a cleanup GovernorBase.spec 2023-02-28 14:05:30 +01:00
d4e9d8d54d fix error in one of the governor rules 2023-02-28 12:18:04 +01:00
baf71582b9 improve helperFunctionsWithRevert 2023-02-28 11:10:36 +01:00
ecebc5688d add --optimistic_hashing to governor scripts 2023-02-28 09:55:41 +01:00
3c58e4e3d3 isOperationReady NOT envfree 2023-02-27 17:21:06 +01:00
4242fdace4 isOperationReady envfree 2023-02-27 16:19:18 +01:00
14b40eddcb add --optimistic_hashing 2023-02-27 15:25:04 +01:00
c8c8ca39d7 cleanup 2023-02-27 15:19:07 +01:00
150edce57b fix timelockcontroller 2023-02-27 15:13:25 +01:00
9f2d511d20 fix2 2023-02-27 14:01:59 +01:00
b50d9980be fix 2023-02-27 13:48:48 +01:00
423a808748 fix harness 2023-02-27 11:59:16 +01:00
5c859049e6 latest compiler 2023-02-27 11:18:16 +01:00
cad49af31e minimize diff 2023-02-27 11:02:36 +01:00
e0fa84a6b7 Merge branch 'master' into formal-verification 2023-02-27 11:00:16 +01:00
e04f7ded94 Fixed GPLQ spec, all rules passing (#3822)
Co-authored-by: Michael George <michael@certora.com>
Co-authored-by: Nick Armstrong <nick@certora.com>
Co-authored-by: Michael George <mdgeorge@cs.cornell.edu>
Co-authored-by: Aleksander Kryukov <firealexkryukov@gmail.com>
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
2022-11-27 20:41:50 -03:00
2c5194f3f1 Clean and fix formal verification (#3798)
Co-authored-by: Michael George <michael@certora.com>
Co-authored-by: Nick Armstrong <nick@certora.com>
Co-authored-by: Michael George <mdgeorge@cs.cornell.edu>
Co-authored-by: Aleksander Kryukov <firealexkryukov@gmail.com>
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
2022-11-04 18:07:39 +01:00
07ac1030e7 chmod -x certora/scripts/**/*.sh 2022-11-03 12:07:39 +01:00
a73d7ab57b get rid of certora/helpers 2022-10-05 15:30:03 +02:00
89962af163 Fix ERC20Wrapper.spec 2022-10-05 15:23:26 +02:00
c7a544d568 move passing scripts out of noCI 2022-09-29 18:40:14 +02:00
634c37becf enable ci test for some (passing) rules 2022-09-28 23:49:03 +02:00
d986bbc8e0 filter noCI on script listing 2022-09-28 11:02:50 +02:00
fed8d5c856 refactor & improve ERC20 specs 2022-09-28 10:55:39 +02:00
597202d904 finish ERC20 base specs + move all other specs to noCI for the time being 2022-09-27 23:36:58 +02:00
8f6a03204e Start working on ERC20 specs 2022-09-27 21:42:18 +02:00
d916e2edf4 further script cleanup 2022-09-23 12:47:45 +02:00
3075181276 use bash 2022-09-23 11:54:11 +02:00
8b1042371a remove some scripts from CI run 2022-09-23 11:43:33 +02:00
38d21cab86 update scripts 2022-09-22 18:56:59 +02:00
bfbf4d8398 clean applyHarness 2022-09-22 10:47:06 +02:00
49333bcc24 clean applyHarness 2022-09-22 10:44:48 +02:00
3252e54f2b use solc without version & remove send_only 2022-09-21 17:41:13 +02:00
cc7837fb46 cleanup scripts/*.sh 2022-09-21 17:30:34 +02:00
9dd0eb5e5c better wildcard 2022-09-21 17:21:26 +02:00
9ce8455ae0 run certora scripts 2022-09-21 17:12:20 +02:00
dfa0505c40 fix formal verification workflow 2022-09-21 09:18:00 +02:00
e7f770591b update harness and matrix 2022-09-20 20:12:05 +02:00
b9c7899e6c no debug 2022-09-20 16:50:37 +02:00
0f20d57771 touch to force make 2022-09-20 16:46:24 +02:00
797ef26bb6 refactor 2022-09-20 16:42:18 +02:00
9aa745e4fe try using python 3.8 2022-09-20 16:40:45 +02:00
d7c3cc758b try using python 3.10 2022-09-20 16:39:12 +02:00
3c0d926908 --debug 2022-09-20 16:28:09 +02:00
28367f8989 fix action 2022-09-20 16:23:25 +02:00
61817e055f enable formal verification by matrix 2022-09-20 16:18:56 +02:00
94f9f7ac58 test matrix 2022-09-20 16:15:33 +02:00
b2ec06aaf2 test matrix 2022-09-20 16:11:32 +02:00
0fa6aad5e5 Update certora harness 2022-09-20 15:12:26 +02:00
0c2453ba17 Automatically generate test matrix 2022-09-09 22:54:56 +02:00
0d1e919742 run check on the formal-verification branch 2022-09-09 15:47:00 +02:00
75ce9ef8e9 name 2022-09-09 13:52:59 +02:00
56c355ea8b fix 2022-09-09 13:47:16 +02:00
e9f53ebc02 run prettier --write 2022-09-09 13:33:55 +02:00
3aa0a015d1 workflow trigger 2022-09-09 13:28:49 +02:00
d98d9c03f3 Merge remote-tracking branch 'Certora/master' into formal-verification 2022-09-09 13:19:12 +02:00
2627753bfe votes solvency passing again 2022-08-12 00:32:35 -07:00
4820ed4ea8 missing erc20votes harnessing 2022-08-11 21:27:17 -07:00
4a3b0bb875 filters for skipped functions 2022-08-11 21:11:01 -07:00
3e6045155e reorganized scripts 2022-08-11 20:40:13 -07:00
b90f4d285e Merge pull request #4 from Certora/certora/erc1155ext
fix erc1155supply vacuity, change CI solc version to 8.4
2022-06-16 11:25:14 -07:00
1701b0c7fd fix erc1155supply vacuity, change CI solc version to 8.4 2022-06-15 17:05:12 -07:00
154a151518 Update verify.yml, adding master branch 2022-06-15 14:31:28 -07:00
0b99b54327 Merge pull request #3 from Certora/certora/erc1155ext
Certora/erc1155ext
2022-06-15 14:18:59 -07:00
9708bc0397 undo script changes 2022-06-15 14:13:43 -07:00
8ec6b0f56f Merge branch 'OpenZeppelin:master' into certora/erc1155ext 2022-06-15 14:07:26 -07:00
962a5023e6 remove commented code, fix some old scripts 2022-06-14 16:52:57 -07:00
6820ff8b9c Merge branch 'OpenZeppelin:master' into certora/erc1155ext 2022-06-08 16:39:13 -07:00
65ab8e9ac4 Changed rule transfersHaveSameLengthInputArrays (passing) to use _ instead of holder 2022-06-07 17:51:27 -07:00
9bbc7b7eb3 Moved three transfer rules from 1155Supply spec to base 1155 spec 2022-06-07 17:32:45 -07:00
e4492aed8a Cleaned up code for rule transfersHaveSameLengthInputArrays (passing) 2022-06-07 17:26:22 -07:00
9c45c52c4b Fix CI script name for GovernorPreventLateQuorum 2022-06-07 17:26:11 -07:00
ca034ab3df Deleted unused method from GovPreventLateQuorum 2022-06-07 17:20:50 -07:00
75a3602ba6 Modified rule transfersHaveSameLengthInputArrays (passing) to limit array size 2022-06-07 17:16:45 -07:00
7946806fb3 Commented out sanity rules for the purposes of CI 2022-06-06 17:34:11 -07:00
84b371f92c Added rule transfersHaveSameLengthInputArrays (partially passing) 2022-06-06 13:54:53 -07:00
cccd90ec83 fix typo in CI 2022-06-06 13:06:28 -07:00
ee2f0ecb68 Improved multiple token transfer batch transfer equivalence rule 2022-06-06 13:02:41 -07:00
6a4fc6acb8 set up CI for round3 scripts 2022-06-06 12:57:50 -07:00
1aa8141b14 removed a assert failure message from an invariant in Initializable spec 2022-06-06 12:56:19 -07:00
866042d6fc Added two transfer batch transfer equivalence rules 2022-06-06 12:53:13 -07:00
234b843c36 commented out failing rules and added solc version to ERC1155 2022-06-06 15:44:07 -04:00
a373d25b01 updated CI to match moving scripts to old 2022-06-06 15:35:08 -04:00
f4b2aff79e added erc1155ext branch to CI 2022-06-06 15:33:29 -04:00
371818f792 Removed reference to _burn and _mint 2022-06-06 12:26:41 -07:00
3ccaf4f6d1 Updated and cleaned up rule descriptions 2022-06-06 11:50:05 -07:00
ffa3daa5d9 Modified verification scripts and Supply spec syntax 2022-06-06 11:42:42 -07:00
990fd18c21 make ERC1155Harness, set up script, and undo munging for ERC1155 2022-06-06 11:26:58 -07:00
5a7cc50974 Modified burnable verification script to follow script naming convention 2022-06-06 11:25:48 -07:00
e3341255b2 Added rule skeletons for equivalence rules 2022-06-06 11:24:50 -07:00
69d9ebfcdf Added modified scripts to run previous ERC1155 spec 2022-06-06 11:24:50 -07:00
be18334b69 Merge branch 'OpenZeppelin:master' into certora/erc1155ext 2022-06-06 09:23:03 -07:00
5516589b88 final initializable spec modulo extra natspec style comments 2022-06-03 16:45:27 -07:00
6363deaedd Changed rule onlyHolderOrApprovedCanReduceBalance to include filtered block 2022-06-03 16:12:12 -07:00
b10a2b8cd3 Added burn and burnBatch to filtered block of unexpectedBalanceChange 2022-06-03 13:56:46 -07:00
bdb49654c5 Deleted redundant rule burnBatchAmountProportionalToBalanceReduction 2022-06-03 12:27:08 -07:00
bab9528dc1 Added rule comments re burn method rules holding for burnBatch method 2022-06-03 12:24:03 -07:00
93928e3e19 Added rule burnBatchOnEmptyArraysChangesNothing (passing) 2022-06-03 12:13:10 -07:00
f3f26e3ff3 Modified verification scripts to include --send_only flag 2022-06-02 14:25:08 -07:00
3eb67081f3 Added TODO show equivalence between batch and non-batch methods 2022-06-02 14:15:20 -07:00
d02c2ccab3 Added comments throughout regarding reasoning 2022-06-02 14:08:29 -07:00
27fa53bba9 added init_state axiom for sum of balances 2022-06-02 14:37:40 -04:00
b90d195c6c Added rule re burnBatch (not implemented) 2022-06-02 11:30:58 -07:00
a6863a059c Changed invariant total_supply_is_sum_of_balances (partially passing) 2022-06-02 11:30:58 -07:00
669a22e0ff remove duplicate initalize script 2022-06-01 17:39:39 -07:00
cab8e489b2 initializable final draft, ready for review 2022-06-01 17:38:28 -07:00
0119a187c1 Added rule multipleTokenBurnBurnBatchEquivalence (passing) 2022-06-01 10:34:03 -07:00
15e847c835 Added invariant balanceOfZeroAddressIsZero (partially passing) 2022-05-31 18:34:22 -07:00
8e283704c3 Modified 1155 Burnable scripts 2022-05-31 16:29:46 -07:00
38495a5026 Added rule singleTokenBurnBurnBatchEquivalence (passing) 2022-05-31 16:02:23 -07:00
f74e316422 Added rule sequentialBurnsEquivalentToSingleBurnOfSum (passing) 2022-05-31 15:12:48 -07:00
2a73da9f67 Added rule burnBatchAmountProportionalToBalanceReduction (unimplemented) 2022-05-31 14:13:44 -07:00
018c58219f Updated 1155 Pausable and Supply scripts to first run make munged 2022-05-31 13:59:46 -07:00
bd3427d5ff Included rule burnAmountProportionalToBalanceReduction (passing) 2022-05-31 13:57:19 -07:00
10f5d8d942 Updated verifyERC1155Burnable.sh to first run make munged 2022-05-31 13:57:19 -07:00
b2cdcc38d4 final govPreventLateQ 2022-05-28 11:01:25 -07:00
ca0d3363b8 Revised rule description to be more accurate 2022-05-27 13:34:24 -07:00
78263e2a9a Changed rule description to match phrasing of assert comment 2022-05-26 14:39:10 -07:00
4dc0ff9fe3 Added assert message 2022-05-26 14:35:27 -07:00
1dd3b7a307 Made comment changes to Burnable and Pausable spec files 2022-05-26 14:10:49 -07:00
657a051062 replaced burn with generic function 2022-05-26 14:46:14 -04:00
da1cda69bf Merge branch 'certora/erc1155ext' of github.com:Certora/openzeppelin-contracts into certora/erc1155ext 2022-05-26 11:21:55 -07:00
428197be69 Added tester rule for only burn 2022-05-26 11:20:46 -07:00
5e69b54af1 added solc version 2022-05-25 16:20:45 -04:00
04382cd1d3 fixed a munging merge problem 2022-05-25 16:20:28 -04:00
d01f3ba925 unclobbered gitignore file 2022-05-25 16:07:55 -04:00
94eba74016 removed some patch cruft 2022-05-25 16:06:34 -04:00
8ec6785cb8 Merge branch 'master' into certora/erc1155ext. Resolved conflicts in
applyHarness by manually merging.
2022-05-25 16:04:16 -04:00
0321f38054 Added remaining rules, unclear if rules_sanity is passing 2022-05-24 16:11:18 -07:00
36327ce8c5 Added script to verify ERC1155Burnable 2022-05-23 10:00:09 -07:00
39f29ec3fd Added spec for ERC1155Burnable with rule sanity 2022-05-23 09:52:25 -07:00
7a2b502b9c Added harness for ERC1155Burnable 2022-05-23 09:32:50 -07:00
46cb74f3cf held tokens should exist passing 2022-05-20 16:27:09 -04:00
fa89068f2b 8.5/10 rules finished 2022-05-19 15:37:58 -07:00
793b88efd8 finalize fist 3 rules; fix old governor spec 2022-05-16 14:26:31 -07:00
c45f34adc8 fix typos 2022-05-11 12:28:28 -07:00
6add1e7718 setup GovLateQuorum and add 3 rules for deadlines 2022-05-11 11:35:24 -07:00
0deaee1217 Added unfinished invariant regarding user token sums and totalSupply 2022-05-10 17:36:19 -07:00
2fc3a5d4b8 implemented independence rule 2022-05-09 17:54:01 -04:00
da0fdc1aa0 harness setup for ERC1155Supply 2022-05-09 17:30:57 -04:00
aafb14461b made the spec run 2022-05-06 14:12:32 -04:00
70cbfffc74 created harness and script 2022-05-06 13:23:52 -04:00
4a3cddc529 temporarily moved old projects into old directory 2022-05-06 13:21:36 -04:00
cca337f5ae Merge branch 'certora/erc20' of github.com:Certora/openzeppelin-contracts into remotes/origin/certora/erc20 2022-04-11 13:56:37 -07:00
02de598056 removed sanity 2022-04-11 13:56:34 -07:00
8fc90f6779 fix in script 2022-04-11 16:55:54 -04:00
f15308f763 added python requirements file 2022-04-11 16:37:21 -04:00
f242abbf93 starting CI integration 2022-04-11 16:35:52 -04:00
135e21f35d comment cleanup 2022-04-11 13:26:46 -07:00
6662d0556f verify all - rules passing 2022-04-11 12:46:56 -07:00
d1454932b2 Merge branch 'certora/erc20' of github.com:Certora/openzeppelin-contracts into remotes/origin/certora/erc20 2022-04-10 19:55:27 -07:00
cab9b09b7b rough contracts all finished 2022-04-10 19:55:23 -07:00
741e9a8b6d timelock function moved 2022-04-08 20:57:53 +01:00
66c72f2b5d CI preparations 2022-04-08 20:52:38 +01:00
163a76f436 Merge branch 'certora/erc20' of github.com:Certora/openzeppelin-contracts into certora/erc20 2022-04-08 15:38:32 +01:00
75417fbf9f finilized rules 2022-04-08 15:38:26 +01:00
ec8f03ee96 Merge branch 'certora/erc20' of github.com:Certora/openzeppelin-contracts into remotes/origin/certora/erc20 2022-04-07 15:50:14 -07:00
140df5b7ce everything except Alex fix for totalVotes_sums_accounts 2022-04-07 15:49:37 -07:00
da674eced1 typos and cleaning 2022-04-04 22:34:51 +01:00
479118fcd1 push to report issues 2022-04-04 21:33:31 +01:00
8c86b250bc fixed rule description 2022-04-04 21:19:54 +01:00
a0b58c3071 flashMint finished 2022-04-04 21:16:15 +01:00
fe7d42dedd Merge branch 'certora/erc20' of github.com:Certora/openzeppelin-contracts into certora/erc20 2022-04-01 17:58:48 +01:00
44fba3e2eb ERC1155 finished 2022-04-01 17:58:41 +01:00
b2b72e7783 Merge branch 'certora/erc20' of github.com:Certora/openzeppelin-contracts into remotes/origin/certora/erc20 2022-03-31 14:40:36 -07:00
22827223c0 more passing 2022-03-31 14:40:20 -07:00
033f08972f Merge branch 'certora/erc20' of github.com:Certora/openzeppelin-contracts into certora/erc20 2022-03-31 21:08:21 +01:00
ec4e77397f AccessControl verification 2022-03-31 21:08:14 +01:00
50cf82823e one more TC cleaning 2022-03-31 21:08:00 +01:00
53b6ed80bb ERC1155 verification (not finished) 2022-03-31 21:07:28 +01:00
a982bee235 TC cleaning 2022-03-31 21:07:01 +01:00
92f07bae1b typechecker error and skipped require bug 2022-03-30 17:12:30 -07:00
4c74b2951d Merge branch 'certora/erc20' of github.com:Certora/openzeppelin-contracts into
remotes/origin/certora/erc20
2022-03-28 12:07:21 -07:00
3f1ee39910 call trace error 2022-03-28 12:05:33 -07:00
4b9500cf25 Merge branch 'certora/erc20' of github.com:Certora/openzeppelin-contracts into certora/erc20 2022-03-27 16:06:49 +01:00
a35ad6dfc3 wrapper and timelockController cleaning 2022-03-27 16:04:31 +01:00
140f019155 Merge branch 'certora/erc20' of github.com:Certora/openzeppelin-contracts into remotes/origin/certora/erc20 2022-03-25 12:57:21 -07:00
6895946f41 updated rules 2022-03-25 12:57:16 -07:00
5153c462d5 wrapper counterexample to check 2022-03-23 19:42:14 +00:00
8318470cca flashMint cleaning 2022-03-23 19:12:16 +00:00
89f9878ba2 Merge branch 'certora/erc20' of github.com:Certora/openzeppelin-contracts into remotes/origin/certora/erc20 2022-03-21 11:13:36 -07:00
6c5d33ba22 run scripts 2022-03-21 11:13:24 -07:00
8d9ab176d7 Timelock hash bug, example for Alex 2022-03-21 17:58:21 +00:00
62d60a5890 Timelock, erc20Wrapper and erc20FlashMint verification 2022-03-20 22:36:48 +00:00
7caa9bbb2c TimelockController wating for hash fix 2022-03-11 00:29:03 +00:00
2be84e627b Merge branch 'certora/erc20' of github.com:Certora/openzeppelin-contracts into remotes/origin/certora/erc20 2022-03-08 18:23:38 -08:00
1900c86c99 removed unnecessary harness from the first iteration 2022-03-08 19:58:23 +00:00
56e4ae9f4a Merge branch 'certora/erc20' of github.com:Certora/openzeppelin-contracts into remotes/origin/certora/erc20 2022-03-08 11:29:12 -08:00
3cb87abec1 removed flags for erc20Votes script 2022-03-08 19:20:55 +00:00
b3845e43d8 Merge branch 'master' of github.com:Certora/openzeppelin-contracts 2022-03-08 11:16:41 -08:00
61fa061ecf erc20votes pointers workaround and preset 2022-03-08 16:38:11 +00:00
ef8013ef79 sanity for TimelockController and Votes 2022-03-03 12:42:16 -08:00
7ab95baab8 Merge branch 'OpenZeppelin:master' into certora/erc20 2022-03-02 12:53:03 -05:00
99864fd2da Merge branch 'OpenZeppelin:master' into certora/erc20 2022-03-01 14:23:25 -05:00
1c3b17826e Merge branch 'OpenZeppelin:master' into master 2022-03-01 14:21:32 -05:00
97b2e1b12a sanity passes 2021-12-17 09:43:47 -05:00
2304dd7bb1 added script for checking token sanity 2021-12-17 09:36:01 -05:00
44cedd5ea2 made scripts executable 2021-12-17 09:30:30 -05:00
7ffbf6a3c8 renamed governor sanity script 2021-12-17 09:30:04 -05:00
b5980a569c reorganized governance verification in preparation for erc20 verification 2021-12-17 09:22:06 -05:00
7912b1af7d filtered out relay, since it is havocing 2021-12-16 14:58:55 -05:00
2a75aa19bd added munging to scripts 2021-12-09 17:17:49 -05:00
d95c3eeee1 removed some spurious comments 2021-12-09 14:47:57 -05:00
22de642692 simplified README somewhat, included additional information about munging 2021-12-09 14:43:40 -05:00
6bd525fd67 Merge branch 'master' into certora/governor
Rerunning verification against current master to ensure clean PR
2021-12-03 15:24:56 -05:00
8c0684ad13 Merge branch 'OpenZeppelin:master' into master 2021-12-03 15:22:52 -05:00
3c150953ed harnessing fix 2021-12-03 14:52:53 -05:00
d64869545d did some harnessing 2021-12-02 16:47:18 -05:00
5888bee853 fixed executeOnly rule 2021-12-02 15:16:26 -05:00
ec5d501791 filtered out timeouts 2021-12-02 15:06:29 -05:00
760edf9b87 tweaked script to run quickly 2021-12-02 14:01:44 -05:00
380b87dc0c switched harnesses to use munged contracts 2021-12-01 10:13:42 -05:00
f3087407c6 created applyHarness 2021-12-01 10:08:06 -05:00
749738f2aa moved contract modifications into munged directory 2021-12-01 10:03:21 -05:00
7d0eeab6f7 HarnessCleaning 2021-12-01 12:02:15 +02:00
dae72a7e1b FixingScriptsToWorkWithNewChanges 2021-12-01 11:59:59 +02:00
96c6120609 NewFileForRulesInProgress 2021-12-01 11:59:30 +02:00
de594921cc fix script 2021-11-30 18:10:20 +02:00
f40c48a83d madeVeryfyAllMoreFlexible 2021-11-27 20:22:25 +02:00
43e37f0184 executedImplyStartAndEndDateNonZero inv fix 2021-11-25 16:25:40 +02:00
1d25a22201 runAllwithoutTypeCheckAndPolishingIt 2021-11-25 13:33:36 +02:00
73080c79d0 cleaning in process 2021-11-25 13:30:09 +02:00
37725a0f2c CleaningAndScriptForAllAndReadme 2021-11-24 19:48:39 +02:00
b3dd1e0386 RulesCleaning 2021-11-24 17:53:01 +02:00
108be781a4 RemovedUnnecessaryHarnesses 2021-11-24 17:52:25 +02:00
0894724496 all rules checked no structure organization 2021-11-23 16:57:14 +02:00
9344f697f9 removed oneUserVotesInCast 2021-11-23 16:33:28 +02:00
4c3ad9c95a GovernorCountingSimple cleaning 2021-11-23 15:27:22 +02:00
38e42f92c2 helperFunctionArgumentEnv 2021-11-23 12:52:51 +02:00
c38babecd9 helper function name change 2021-11-23 12:47:21 +02:00
e01b285780 helper function fix plus reviewing up to noExecuteOrCancelBeforeDeadline including 2021-11-23 11:48:58 +02:00
1b4fb6c758 callPropose and castVoteWithReason removed 2021-11-23 11:48:07 +02:00
95321a3516 done up to noStartBeforeCreation including 2021-11-22 17:35:13 +02:00
ff8e17ec2f removedHarnessesAnsSummariesAddedComments 2021-11-22 12:17:41 +02:00
37fe8c292a FixinigTimeoutsAndTotalVotes 2021-11-22 09:51:11 +02:00
cd703a5ee0 cleaned up to doubleVoting (not included) 2021-11-21 18:03:11 +02:00
167f175f3a harness _execute() 2021-11-21 18:02:26 +02:00
a14abd0276 hashProposal summarization removed 2021-11-20 02:06:01 +02:00
0fbf745efe noVoteForSomeoneElse fix 2021-11-20 01:52:06 +02:00
92f5f0dfbb TryingToFixRules 2021-11-19 20:13:06 +02:00
0cbb98b92c uncommenting hook for oneUserVotesInCast 2021-11-18 16:42:32 +02:00
9f2a672240 moving updateQuorumNumerator to GovernorBase 2021-11-18 15:46:56 +02:00
0ecb5fce78 fix for oneUserVotesInCast 2021-11-18 15:43:21 +02:00
65af47d90d added filters to revert if exec and revert if canceled 2021-11-18 15:39:18 +02:00
f7049de567 envfreeViolationFix 2021-11-18 10:12:13 +02:00
61b011869c AddedLinkAndFixingGhost 2021-11-17 16:00:16 +02:00
a33b9b2bb0 FixedERC20VotesIssue 2021-11-17 13:33:43 +02:00
44113d58f5 NewWizardHarness 2021-11-17 11:56:24 +02:00
eb27bdd282 MoreRulesAndFixesOfExistedRules 2021-11-16 19:53:07 +02:00
daad23b3a7 comment noVoteForSomeoneElse 2021-11-16 18:35:09 +02:00
1da0a4ae7d allFunctionsRevertIfExecuted, allFunctionsRevertIfCanceled, executedOnlyAfterExecuteFunc passing as intended 2021-11-16 18:33:49 +02:00
5833f52879 Harness of castVoteWithReason to be able to impose requirement on the proposal ID 2021-11-16 18:32:38 +02:00
a16eaebb25 ManyNonWorkingRules 2021-11-15 18:22:36 +02:00
d297280617 oneUserVoteInCast, noVotesForSomeoneElse 2021-11-15 18:00:04 +02:00
eee306acda commenting helper function, executed only after exec, func revert if canceled or executed 2021-11-15 17:58:36 +02:00
c0a257fa0c overriding castVoteWithReason 2021-11-15 17:56:30 +02:00
c6365ef868 creating new ghost for 26 b 2021-11-14 15:44:29 +02:00
54fa59f879 proposeInitialized done 2021-11-14 15:33:30 +02:00
2baa9bd801 Merge branch 'certora/governor' of https://github.com/Certora/openzeppelin-contracts into certora/governor 2021-11-12 16:42:55 +02:00
a858ed7a2a codeCleaningNumberIDontKnow 2021-11-12 16:42:22 +02:00
921c668a59 reorganization + violated rules 2021-11-12 16:42:22 +02:00
0598a3ac43 CountingSimpleMoreCleanAndAddedMoreRules 2021-11-12 16:42:22 +02:00
0d724ca892 Cleaned harness + callPropose 2021-11-12 16:42:22 +02:00
b948e70258 aesthetic 2021-11-12 16:42:22 +02:00
5267eaac81 Changed deltaWeight type from uint to uin256 2021-11-12 16:42:22 +02:00
9b4634bebe FixedTypoInEnvfreeWord 2021-11-12 16:42:22 +02:00
f8a54d2ae2 RemovedInsertedBugForSumRule 2021-11-12 16:42:21 +02:00
92744a195a specificSpecForSumRule 2021-11-12 16:42:21 +02:00
bc9bbc2431 FirstWizardHarness 2021-11-12 16:42:21 +02:00
16e101bba9 cannot set if executed and canceled as rules (not working) 2021-11-12 16:42:21 +02:00
861fab8589 ghosts and invariant unfinished 2021-11-12 16:42:21 +02:00
8ed7f965bb added ghost and counter implementation for castWithReason and castBySig 2021-11-12 16:42:21 +02:00
53d4006806 fixed function revert if executed 2021-11-12 16:42:20 +02:00
2761ec0b66 MoreRulesToTheGodOfRules 2021-11-12 16:42:20 +02:00
d5c6520e4d idea for sum of votes 2021-11-12 16:42:20 +02:00
5ea1cc7a8a added invariants if executed or canceled always revert 2021-11-12 16:42:20 +02:00
c50cb000dd fix simple vote end before start 2021-11-12 16:42:20 +02:00
d4b9e9ab80 someCleaning 2021-11-12 16:42:20 +02:00
85b65befd5 WorkInProgress 2021-11-12 16:42:20 +02:00
77efd53f0c checkingInvariantsWithoutGhosts 2021-11-12 16:42:19 +02:00
364da56ab4 quotes on var in msg 2021-11-12 16:42:19 +02:00
9298482163 scripts settings added 2021-11-12 16:42:19 +02:00
91f8919876 hooks fixed 2021-11-12 16:42:19 +02:00
6323c9a73d slight changes in scripts + disableLocalTypeChecking 2021-11-12 16:42:19 +02:00
c08a73a6ca Harness private to public 2021-11-12 16:42:19 +02:00
547e7a8308 Harness private to public 2021-11-12 16:42:19 +02:00
6307b3bb64 slight changes change for convenience + disableLocalTypeChecking flag for the hooks 2021-11-12 16:42:18 +02:00
32ab301c9d Hooks fixed 2021-11-12 16:42:18 +02:00
788d4672d7 slight script changes and ghost fix 2021-11-12 16:42:18 +02:00
1c35a7dad0 multiple inheritance is tricky x2 2021-11-12 16:42:18 +02:00
2d33674870 multiple inheritance is tricky 2021-11-12 16:42:18 +02:00
e810379262 sanity rule preparations 2021-11-12 16:42:18 +02:00
d6036f9291 ignore certora's generated files 2021-11-12 16:42:17 +02:00
ea6baf2220 rule drafts 2021-11-12 16:42:17 +02:00
a0cb8cd446 fixes 2021-11-12 16:42:17 +02:00
8494fe20bc fixes 2021-11-12 16:42:17 +02:00
4a0077d685 Back to expected pattern? 2021-11-12 16:42:17 +02:00
9a194f24b8 start work on governor 2021-11-12 16:42:17 +02:00
4337957a6b codeCleaningNumberIDontKnow 2021-11-12 14:12:03 +02:00
2ecba5326b reorganization + violated rules 2021-11-12 09:02:51 +02:00
2a0532dacc CountingSimpleMoreCleanAndAddedMoreRules 2021-11-11 17:28:22 +02:00
f2c352366a Merge pull request #1 from OpenZeppelin/master
Synced Forked Repo
2021-11-11 11:27:32 +02:00
b52832ca7f Cleaned harness + callPropose 2021-11-10 15:26:29 +02:00
eb87bb4822 aesthetic 2021-11-10 15:10:37 +02:00
52924aaec0 Changed deltaWeight type from uint to uin256 2021-11-10 15:07:34 +02:00
85855b8cc7 FixedTypoInEnvfreeWord 2021-11-09 21:09:54 +02:00
6ac85d8d15 RemovedInsertedBugForSumRule 2021-11-09 15:16:44 +02:00
96df9799c3 specificSpecForSumRule 2021-11-09 15:10:07 +02:00
07d637980c FirstWizardHarness 2021-11-09 11:18:23 +02:00
44a8fed410 cannot set if executed and canceled as rules (not working) 2021-11-08 20:16:53 +02:00
34cb4bdc9c ghosts and invariant unfinished 2021-11-08 19:00:22 +02:00
c819e0b063 added ghost and counter implementation for castWithReason and castBySig 2021-11-08 17:57:53 +02:00
37a4975544 fixed function revert if executed 2021-11-08 17:51:28 +02:00
751277a1ab MoreRulesToTheGodOfRules 2021-11-08 17:18:36 +02:00
ad7993d7d5 idea for sum of votes 2021-11-08 15:57:53 +02:00
7a5bd86ef4 added invariants if executed or canceled always revert 2021-11-08 15:57:19 +02:00
ac729e0ecf fix simple vote end before start 2021-11-08 14:57:51 +02:00
0ebc0d5844 someCleaning 2021-11-08 11:44:04 +02:00
b133fee376 WorkInProgress 2021-11-07 17:55:03 +02:00
f08ee568b9 checkingInvariantsWithoutGhosts 2021-11-04 17:54:26 +02:00
bfa1dd3756 quotes on var in msg 2021-11-04 15:03:28 +02:00
f7cc2548f3 scripts settings added 2021-11-04 12:54:23 +02:00
a2960e22b9 hooks fixed 2021-11-04 12:35:37 +02:00
21b84349d4 slight changes in scripts + disableLocalTypeChecking 2021-11-04 12:35:11 +02:00
d6e79f4366 Harness private to public 2021-11-04 12:29:04 +02:00
c00d951e06 Harness private to public 2021-11-04 11:51:14 +02:00
6876df00ae slight changes change for convenience + disableLocalTypeChecking flag for the hooks 2021-11-04 11:50:40 +02:00
e888ea4ccb Hooks fixed 2021-11-04 11:48:55 +02:00
69f87ad916 slight script changes and ghost fix 2021-11-04 11:27:44 +02:00
a710435535 multiple inheritance is tricky x2 2021-11-03 17:24:35 +02:00
72d4e9c29c multiple inheritance is tricky 2021-11-03 17:09:27 +02:00
cac49bfc2e sanity rule preparations 2021-11-03 17:05:06 +02:00
6776cc6ee4 ignore certora's generated files 2021-11-02 14:01:48 +02:00
22030f2fd3 rule drafts 2021-10-07 11:58:47 +03:00
4c1d5e01c6 fixes 2021-09-26 01:43:16 +03:00
fdc4b0cf23 fixes 2021-09-26 01:39:27 +03:00
f239fa56dd Back to expected pattern? 2021-09-26 00:25:59 +03:00
2c08f85744 start work on governor 2021-09-26 00:21:08 +03:00
690 changed files with 25793 additions and 23146 deletions

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`ERC1155Receiver`: Removed in favor of `ERC1155Holder`.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`TimelockController`: Changed the role architecture to use `DEFAULT_ADMIN_ROLE` as the admin for all roles, instead of the bespoke `TIMELOCK_ADMIN_ROLE` that was used previously. This aligns with the general recommendation for `AccessControl` and makes the addition of new roles easier. Accordingly, the `admin` parameter and timelock will now be granted `DEFAULT_ADMIN_ROLE` instead of `TIMELOCK_ADMIN_ROLE`. ([#3799](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3799))

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': patch
---
`Initializable`: optimize `_disableInitializers` by using `!=` instead of `<`. ([#3787](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3787))

View File

@ -1,4 +0,0 @@
---
'openzeppelin-solidity': major
---
Use `abi.encodeCall` in place of `abi.encodeWithSelector` and `abi.encodeWithSignature` for improved type-checking of parameters

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`ERC2771Forwarder`: Added `deadline` for expiring transactions, batching, and more secure handling of `msg.value`.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': minor
---
`Math`: Make `ceilDiv` to revert on 0 division even if the numerator is 0

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`Governor`: Refactored internals to implement common queuing logic in the core module of the Governor. Added `queue` and `_queueOperations` functions that act at different levels. Modules that implement queuing via timelocks are expected to override `_queueOperations` to implement the timelock-specific logic. Added `_executeOperations` as the equivalent for execution.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`ERC20`, `ERC1155`: Deleted `_beforeTokenTransfer` and `_afterTokenTransfer` hooks, added a new internal `_update` function for customizations, and refactored all extensions using those hooks to use `_update` instead. ([#3838](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3838), [#3876](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3876))

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`ERC1155Supply`: add a `totalSupply()` function that returns the total amount of token circulating, this change will restrict the total tokens minted across all ids to 2\*\*256-1 .

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`Ownable`: Add an `initialOwner` parameter to the constructor, making the ownership initialization explicit.

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---
`ReentrancyGuard`: Add a `_reentrancyGuardEntered` function to expose the guard status. ([#3714](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3714))

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': patch
---
`Ownable2Step`: make `acceptOwnership` public virtual to enable usecases that require overriding it. ([#3960](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3960))

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---
`ERC721Wrapper`: add a new extension of the `ERC721` token which wraps an underlying token. Deposit and withdraw guarantee that the ownership of each token is backed by a corresponding underlying token with the same identifier.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': minor
---
`Proxy`: Removed redundant `receive` function.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': patch
---
Optimize `Strings.equal`

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`UUPSUpgradeable`, `TransparentUpgradeableProxy` and `ProxyAdmin`: Removed `upgradeTo` and `upgrade` functions, and made `upgradeToAndCall` and `upgradeAndCall` ignore the data argument if it is empty. It is no longer possible to invoke the receive function (or send value with empty data) along with an upgrade.

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---
`EnumerableMap`: add a `keys()` function that returns an array containing all the keys. ([#3920](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3920))

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': patch
---
`UUPSUpgradeable.sol`: Change visibility to the functions `upgradeTo ` and `upgradeToAndCall ` from `external` to `public`.

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': patch
---
`TimelockController`: Add the `CallSalt` event to emit on operation schedule.

View File

@ -1,7 +0,0 @@
---
'openzeppelin-solidity': minor
---
Replace some uses of `abi.encodePacked` with clearer alternatives (e.g. `bytes.concat`, `string.concat`). (#4504)[https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4504]
pr: #4296

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---
`Governor`: add a public `cancel(uint256)` function.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': minor
---
`Arrays`: Optimize `findUpperBound` by removing redundant SLOAD.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': patch
---
`ECDSA`: Use unchecked arithmetic for the `tryRecover` function that receives the `r` and `vs` short-signature fields separately.

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---
`Governor`: Enable timestamp operation for blockchains without a stable block time. This is achieved by connecting a Governor's internal clock to match a voting token's EIP-6372 interface.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`Checkpoints`: library moved from `utils` to `utils/structs`

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': patch
---
Reformatted codebase with latest version of Prettier Solidity. ([#3898](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3898))

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---
`Strings`: add `equal` method. ([#3774](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3774))

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`Governor`: Optimized use of storage for proposal data

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`ERC1967Utils`: Refactor the `ERC1967Upgrade` abstract contract as a library.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`TransparentUpgradeableProxy`: Admin is now stored in an immutable variable (set during construction) to avoid unnecessary storage reads on every proxy call. This removed the ability to ever change the admin. Transfer of the upgrade capability is exclusively handled through the ownership of the `ProxyAdmin`.

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---
`IERC5313`: Add an interface for EIP-5313 that is now final.

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': patch
---
`Math`: optimize `log256` rounding check. ([#3745](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3745))

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`ERC20`: Remove `Approval` event previously emitted in `transferFrom` to indicate that part of the allowance was consumed. With this change, allowances are no longer reconstructible from events. See the code for guidelines on how to re-enable this event if needed.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
Move the logic to validate ERC-1822 during an upgrade from `ERC1967Utils` to `UUPSUpgradeable`.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': minor
---
`Arrays`: Add `unsafeMemoryAccess` helpers to read from a memory array without checking the length.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`MessageHashUtils`: Add a new library for creating message digest to be used along with signing or recovery such as ECDSA or ERC-1271. These functions are moved from the `ECDSA` library.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': minor
---
`GovernorTimelockControl`: Clean up timelock id on execution for gas refund.

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': patch
---
`ERC20Votes`: optimize by using unchecked arithmetic. ([#3748](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3748))

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': minor
---
`EIP712`: Add internal getters for the name and version strings

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': patch
---
`Multicall`: annotate `multicall` function as upgrade safe to not raise a flag for its delegatecall. ([#3961](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3961))

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': minor
---
`TimelockController`: Add a state getter that returns an `OperationState` enum.

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---
`IERC4906`: Add an interface for ERC-4906 that is now Final.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
Replace revert strings and require statements with custom errors.

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---
`TransparentUpgradeableProxy`: support value passthrough for all ifAdmin function.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`Nonces`: Added a new contract to keep track of user nonces. Used for signatures in `ERC20Permit`, `ERC20Votes`, and `ERC721Votes`. ([#3816](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3816))

View File

@ -1,6 +0,0 @@
---
'openzeppelin-solidity': patch
---
`Governor`: Add validation in ERC1155 and ERC721 receiver hooks to ensure Governor is the executor.

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---
`StorageSlot`: Add support for `string` and `bytes`.

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': patch
---
`ERC20Pausable`, `ERC721Pausable`, `ERC1155Pausable`: Add note regarding missing public pausing functionality

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---
`Votes`, `ERC20Votes`, `ERC721Votes`: support timestamp checkpointing using EIP-6372.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
Switched to using explicit Solidity import statements. Some previously available symbols may now have to be separately imported.

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---
`ERC4626`: Add mitigation to the inflation attack through virtual shares and assets.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': patch
---
`Math`: Optimized stack operations in `mulDiv`.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`Governor`: Add support for casting votes with ERC-1271 signatures by using a `bytes memory signature` instead of `r`, `s` and `v` arguments in the `castVoteBySig` and `castVoteWithReasonAndParamsBySig` functions.

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---
`Strings`: add `toString` method for signed integers. ([#3773](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3773))

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---
`ERC20Wrapper`: Make the `underlying` variable private and add a public accessor.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': patch
---
`BeaconProxy`: Use an immutable variable to store the address of the beacon. It is no longer possible for a `BeaconProxy` to upgrade by changing to another beacon.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`GovernorTimelockControl`: Add the Governor instance address as part of the TimelockController operation `salt` to avoid operation id collisions between governors using the same TimelockController.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
Overrides are now used internally for a number of functions that were previously hardcoded to their default implementation in certain locations: `ERC1155Supply.totalSupply`, `ERC721.ownerOf`, `ERC721.balanceOf` and `ERC721.totalSupply` in `ERC721Enumerable`, `ERC20.totalSupply` in `ERC20FlashMint`, and `ERC1967._getImplementation` in `ERC1967Proxy`.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`ProxyAdmin`: Removed `getProxyAdmin` and `getProxyImplementation` getters. ([#3820](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3820))

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': patch
---
`ERC1155`: Optimize array allocation.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
Bump minimum compiler version required to 0.8.20

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---
`EIP712`: add EIP-5267 support for better domain discovery.

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---
`AccessControlDefaultAdminRules`: Add an extension of `AccessControl` with additional security rules for the `DEFAULT_ADMIN_ROLE`.

View File

@ -1,7 +0,0 @@
---
'openzeppelin-solidity': major
---
`ERC20Votes`: Changed internal vote accounting to reusable `Votes` module previously used by `ERC721Votes`. Removed implicit `ERC20Permit` inheritance. Note that the `DOMAIN_SEPARATOR` getter was previously guaranteed to be available for `ERC20Votes` contracts, but is no longer available unless `ERC20Permit` is explicitly used; ERC-5267 support is included in `ERC20Votes` with `EIP712` and is recommended as an alternative.
pr: #3816

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`Governor`: Add `voter` and `nonce` parameters in signed ballots, to avoid forging signatures for random addresses, prevent signature replay, and allow invalidating signatures. Add `voter` as a new parameter in the `castVoteBySig` and `castVoteWithReasonAndParamsBySig` functions.

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---
`SignatureChecker`: Add `isValidERC1271SignatureNow` for checking a signature directly against a smart contract using ERC-1271.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`TransparentUpgradeableProxy`: Removed `admin` and `implementation` getters, which were only callable by the proxy owner and thus not very useful. ([#3820](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3820))

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': patch
---
`ECDSA`: Add a function `toDataWithIntendedValidatorHash` that encodes data with version 0x00 following EIP-191.

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---
`SafeERC20`: Add a `forceApprove` function to improve compatibility with tokens behaving like USDT.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`ERC1155`: Remove check for address zero in `balanceOf`.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`access`: Move `AccessControl` extensions to a dedicated directory.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': patch
---
`ERC721Consecutive`: Add a `_firstConsecutiveId` internal function that can be overridden to change the id of the first token minted through `_mintConsecutive`.

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---
`ERC1967Upgrade`: removed contract-wide `oz-upgrades-unsafe-allow delegatecall` annotation, replaced by granular annotation in `UUPSUpgradeable`.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`DoubleEndedQueue`: refactor internal structure to use `uint128` instead of `int128`. This has no effect on the library interface.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': patch
---
`Governor`: Add a mechanism to restrict the address of the proposer using a suffix in the description.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': minor
---
`Governor`, `Initializable`, and `UUPSUpgradeable`: Use internal functions in modifiers to optimize bytecode size.

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': patch
---
`MerkleProof`: optimize by using unchecked arithmetic. ([#3745](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3745))

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`Strings`: Rename `toString(int256)` to `toStringSigned(int256)`.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`BeaconProxy`: Reject value in initialization unless a payable function is explicitly invoked.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': minor
---
`ERC1155`: Bubble errors triggered in the `onERC1155Received` and `onERC1155BatchReceived` hooks.

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---
`ECDSA`: optimize bytes32 computation by using assembly instead of `abi.encodePacked`.

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---
`ERC721URIStorage`: Emit ERC-4906 `MetadataUpdate` in `_setTokenURI`.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': patch
---
`ERC1155`: Optimize array accesses by skipping bounds checking when unnecessary.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': minor
---
`AccessControl`: Add a boolean return value to the internal `_grantRole` and `_revokeRole` functions indicating whether the role was granted or revoked.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': patch
---
`ERC2771Context`: Return the forwarder address whenever the `msg.data` of a call originating from a trusted forwarder is not long enough to contain the request signer address (i.e. `msg.data.length` is less than 20 bytes), as specified by ERC-2771.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': minor
---
Remove the `override` specifier from functions that only override a single interface function.

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---
`ShortStrings`: Added a library for handling short strings in a gas efficient way, with fallback to storage for longer strings.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': patch
---
`ERC2771Context`: Prevent revert in `_msgData()` when a call originating from a trusted forwarder is not long enough to contain the request signer address (i.e. `msg.data.length` is less than 20 bytes). Return the full calldata in that case.

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---
`SignatureChecker`: Allow return data length greater than 32 from EIP-1271 signers.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`GovernorStorage`: Added a new governor extension that stores the proposal details in storage, with an interface that operates on `proposalId`, as well as proposal enumerability. This replaces the old `GovernorCompatibilityBravo` module.

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`Math`: Renamed members of `Rounding` enum, and added a new rounding mode for "away from zero".

View File

@ -1,5 +0,0 @@
---
'openzeppelin-solidity': major
---
`SafeERC20`: Refactor `safeDecreaseAllowance` and `safeIncreaseAllowance` to support USDT-like tokens.

View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---
`UUPSUpgradeable`: added granular `oz-upgrades-unsafe-allow-reachable` annotation to improve upgrade safety checks on latest version of the Upgrades Plugins (starting with `@openzeppelin/upgrades-core@1.21.0`).

View File

@ -4,7 +4,6 @@ on:
push:
branches:
- master
- next-v*
- release-v*
pull_request: {}
workflow_dispatch: {}
@ -13,11 +12,9 @@ concurrency:
group: checks-${{ github.ref }}
cancel-in-progress: true
env:
NODE_OPTIONS: --max_old_space_size=5120
jobs:
lint:
if: github.repository != 'OpenZeppelin/openzeppelin-contracts-upgradeable'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
@ -29,6 +26,7 @@ jobs:
runs-on: ubuntu-latest
env:
FORCE_COLOR: 1
NODE_OPTIONS: --max_old_space_size=4096
GAS: true
steps:
- uses: actions/checkout@v3
@ -39,34 +37,19 @@ jobs:
- name: Check linearisation of the inheritance graph
run: npm run test:inheritance
- name: Check proceduraly generated contracts are up-to-date
if: github.repository != 'OpenZeppelin/openzeppelin-contracts-upgradeable'
run: npm run test:generation
- name: Compare gas costs
uses: ./.github/actions/gas-compare
with:
token: ${{ github.token }}
tests-upgradeable:
runs-on: ubuntu-latest
env:
FORCE_COLOR: 1
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0 # Include history so patch conflicts are resolved automatically
- name: Set up environment
uses: ./.github/actions/setup
- name: Transpile to upgradeable
run: bash scripts/upgradeable/transpile.sh
- name: Run tests
run: npm run test
- name: Check linearisation of the inheritance graph
run: npm run test:inheritance
- name: Check storage layout
uses: ./.github/actions/storage-layout
with:
token: ${{ github.token }}
tests-foundry:
foundry-tests:
if: github.repository != 'OpenZeppelin/openzeppelin-contracts-upgradeable'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
@ -80,17 +63,19 @@ jobs:
run: forge test -vv
coverage:
if: github.repository != 'OpenZeppelin/openzeppelin-contracts-upgradeable'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Set up environment
uses: ./.github/actions/setup
- run: npm run coverage
env:
NODE_OPTIONS: --max_old_space_size=4096
- uses: codecov/codecov-action@v3
with:
token: ${{ secrets.CODECOV_TOKEN }}
slither:
if: github.repository != 'OpenZeppelin/openzeppelin-contracts-upgradeable'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
@ -98,16 +83,14 @@ jobs:
uses: ./.github/actions/setup
- run: rm foundry.toml
- uses: crytic/slither-action@v0.3.0
with:
node-version: 18.15
codespell:
if: github.repository != 'OpenZeppelin/openzeppelin-contracts-upgradeable'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Run CodeSpell
uses: codespell-project/actions-codespell@v2.0
uses: codespell-project/actions-codespell@v1.0
with:
check_hidden: true
check_filenames: true
skip: package-lock.json,*.pdf

View File

@ -0,0 +1,55 @@
name: Formal verification
on:
push:
branches:
- master
- release-v*
- formal-verification
pull_request: {}
workflow_dispatch: {}
jobs:
list-scripts:
runs-on: ubuntu-latest
outputs:
matrix: ${{ steps.set-matrix.outputs.matrix }}
steps:
- uses: actions/checkout@v2
- id: set-matrix
run: echo ::set-output name=matrix::$(ls certora/scripts/{,**}/*.sh | grep -v '\WnoCI\W' | jq -Rsc 'split("\n")[:-1]')
verify:
runs-on: ubuntu-latest
needs: list-scripts
steps:
- uses: actions/checkout@v2
- name: Install python
uses: actions/setup-python@v2
with:
python-version: '3.10'
cache: 'pip'
- name: Install java
uses: actions/setup-java@v1
with:
java-version: '11'
java-package: 'jre'
- name: Install certora
run: pip install certora-cli
- name: Install solc
run: |
wget https://github.com/ethereum/solidity/releases/download/v0.8.19/solc-static-linux
sudo mv solc-static-linux /usr/local/bin/solc
chmod +x /usr/local/bin/solc
- name: Verify rule ${{ matrix.params }}
run: |
touch certora/applyHarness.patch
make -C certora munged
bash ${{ matrix.params }}
env:
CERTORAKEY: ${{ secrets.CERTORAKEY }}
strategy:
fail-fast: false
max-parallel: 4
matrix:
params: ${{ fromJson(needs.list-scripts.outputs.matrix) }}

View File

@ -1,68 +0,0 @@
name: formal verification
on:
pull_request:
types:
- opened
- reopened
- synchronize
- labeled
workflow_dispatch: {}
env:
PIP_VERSION: '3.10'
JAVA_VERSION: '11'
SOLC_VERSION: '0.8.20'
concurrency: ${{ github.workflow }}-${{ github.ref }}
jobs:
apply-diff:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Apply patches
run: make -C certora apply
verify:
runs-on: ubuntu-latest
if: github.event_name != 'pull_request' || contains(github.event.pull_request.labels.*.name, 'formal-verification')
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Set up environment
uses: ./.github/actions/setup
- name: identify specs that need to be run
id: arguments
run: |
if [[ ${{ github.event_name }} = 'pull_request' ]];
then
RESULT=$(git diff ${{ github.event.pull_request.head.sha }}..${{ github.event.pull_request.base.sha }} --name-only certora/specs/*.spec | while IFS= read -r file; do [[ -f $file ]] && basename "${file%.spec}"; done | tr "\n" " ")
else
RESULT='--all'
fi
echo "result=$RESULT" >> "$GITHUB_OUTPUT"
- name: Install python
uses: actions/setup-python@v4
with:
python-version: ${{ env.PIP_VERSION }}
cache: 'pip'
- name: Install python packages
run: pip install -r requirements.txt
- name: Install java
uses: actions/setup-java@v3
with:
distribution: temurin
java-version: ${{ env.JAVA_VERSION }}
- name: Install solc
run: |
wget https://github.com/ethereum/solidity/releases/download/v${{ env.SOLC_VERSION }}/solc-static-linux
sudo mv solc-static-linux /usr/local/bin/solc
chmod +x /usr/local/bin/solc
- name: Verify specification
run: |
make -C certora apply
node certora/run.js ${{ steps.arguments.outputs.result }} >> "$GITHUB_STEP_SUMMARY"
env:
CERTORAKEY: ${{ secrets.CERTORAKEY }}

View File

@ -192,8 +192,6 @@ jobs:
pull-requests: write
if: needs.state.outputs.merge == 'true'
runs-on: ubuntu-latest
env:
MERGE_BRANCH: merge/${{ github.ref_name }}
steps:
- uses: actions/checkout@v3
with:
@ -202,9 +200,7 @@ jobs:
uses: ./.github/actions/setup
- run: bash scripts/git-user-config.sh
- name: Create branch to merge
run: |
git checkout -B "$MERGE_BRANCH" "$GITHUB_REF_NAME"
git push -f origin "$MERGE_BRANCH"
run: bash scripts/release/workflow/prepare-release-merge.sh
- name: Create PR back to master
uses: actions/github-script@v6
with:
@ -212,7 +208,7 @@ jobs:
await github.rest.pulls.create({
owner: context.repo.owner,
repo: context.repo.repo,
head: process.env.MERGE_BRANCH,
head: 'merge/${{ github.ref_name }}',
base: 'master',
title: '${{ format('Merge {0} branch', github.ref_name) }}'
});

View File

@ -1,4 +1,4 @@
name: transpile upgradeable
name: Upgradeable Trigger
on:
push:
@ -7,24 +7,17 @@ on:
- release-v*
jobs:
transpile:
environment: push-upgradeable
trigger:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- id: app
uses: getsentry/action-github-app-token@v2
with:
repository: OpenZeppelin/openzeppelin-contracts-upgradeable
fetch-depth: 0
token: ${{ secrets.GH_TOKEN_UPGRADEABLE }}
- name: Fetch current non-upgradeable branch
run: |
git fetch "https://github.com/${{ github.repository }}.git" "$REF"
git checkout FETCH_HEAD
env:
REF: ${{ github.ref }}
- name: Set up environment
uses: ./.github/actions/setup
- run: bash scripts/git-user-config.sh
- name: Transpile to upgradeable
run: bash scripts/upgradeable/transpile-onto.sh ${{ github.ref_name }} origin/${{ github.ref_name }}
- run: git push origin ${{ github.ref_name }}
app_id: ${{ secrets.UPGRADEABLE_APP_ID }}
private_key: ${{ secrets.UPGRADEABLE_APP_PK }}
- run: |
curl -X POST \
https://api.github.com/repos/OpenZeppelin/openzeppelin-contracts-upgradeable/dispatches \
-H 'Accept: application/vnd.github.v3+json' \
-H 'Authorization: token ${{ steps.app.outputs.token }}' \
-d '{ "event_type": "Update", "client_payload": { "ref": "${{ github.ref }}" } }'

2
.gitignore vendored
View File

@ -68,4 +68,4 @@ contracts-exposed
.certora*
.last_confs
certora_*
.zip-output-url.txt
resource_errors.json

1
.gitmodules vendored
View File

@ -1,5 +1,4 @@
[submodule "lib/forge-std"]
branch = v1
path = lib/forge-std
url = https://github.com/foundry-rs/forge-std
[submodule "lib/erc4626-tests"]

Some files were not shown because too many files have changed in this diff Show More