NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,327 Commits 61 Branches 143 Tags
8204f6a71fcb1597e3c92117290600f4e752ca19
Commit Graph

1327 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Nicolás Venturo
8204f6a71f Improved some ERC721 internal shenanigans (#1450) 
* Made _clearApproval private, added clarifying comments in _addTokenTo and _removeTokenFrom.

* Added approval information.
 2018-10-18 19:07:34 -03:00
Nicolás Venturo
bbe804a14b Deleted unnecessary import. (#1437) 
* Deleted unnecessary import.

* Added back SafeMath.

* Removed another unnecessary import.
 2018-10-18 18:43:44 -03:00
Nicolás Venturo
28cf567e41 Made SampleCrowdsale a bit clearer. (#1448) 2018-10-18 18:43:12 -03:00
Nicolás Venturo
5bb865218f Now setting the finalized flag before doing finalization to prevent possbile reentrancy issues. (#1447) 2018-10-18 18:42:57 -03:00
Nicolás Venturo
94692acb14 Crowdsale docs improvements. (#1446) 
* Added a small Crowdsale fallback gas warning.

* Fixed a couple typos.
 2018-10-18 16:57:16 -03:00
Nicolás Venturo
384dff9abe Renamed internal ERC721 check function. (#1445) 2018-10-18 16:56:58 -03:00
Nicolás Venturo
5bf3907862 Made tokenURI external, as per the spec. (#1444) 2018-10-18 16:49:46 -03:00
Nicolás Venturo
c8220aeea8 ERC20Capped now capps _all_ minting, even internal calls. (#1443) 2018-10-18 16:49:31 -03:00
Nicolás Venturo
9155bfe27f IncPriceCrowdsale consistently returns 0 outside of the crowdsale window. (#1442) 2018-10-18 16:36:27 -03:00
Nicolás Venturo
1c5f16ae26 Closing time must be strictly after opening time. (#1440) 2018-10-18 16:36:11 -03:00
Nicolás Venturo
d9fdffe88e Internal crowdsales (#1439) 
* Made some internal crowdsale methods internal.

* Made all Crowdsale constructors internal.
 2018-10-18 16:35:57 -03:00
Aniket
315f426f5c Improved SafeERC20 allowance handling (#1407) 
* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776f4.

* updates

* fixes #1404

* approve failing test

* suggested changes done

* ISafeERC20 removed

* allowance methods in library

* Improved SafeERC20 tests.

* Fixed test coverage.
 2018-10-18 12:25:03 -03:00
Nicolás Venturo
67dac7ae99 TokenVesting improvements (#1431) 
* Improved TokenVesting events.

* Added extra checks to TokenVesting.

* Renamed the events.

* Fixed linter error.

* Fixed a test that failed to cover a require.

* Renamed TokensRevoked to TokenVestingRevoked.
 2018-10-18 11:27:46 -03:00
cardmaniac992
a07499796a SplitPayment improvements (#1417) 
* Renamed file, added events and set _addPayee to private

* unwanted file

* adjusted test

* adjusted test

* PaymentReceived event added

* Added event testing.

* Fix static tests
 2018-10-18 11:26:54 -03:00
Christopher Glisch
fcab9c89f2 Added address of pauser/unpauser in events (#1410) 
* Added address of pauser/unpauser in events

* Added the account to the Pausable tests.
 2018-10-18 11:26:39 -03:00
Aniket
cbe414864f Events added to Secondary (#1425) 
* Update contracts/ownership/Secondary.sol

* Update Secondary.sol

* Update Secondary.test.js

* Update Secondary.test.js

* Update Secondary.sol
 2018-10-18 11:00:33 -03:00
Nicolás Venturo
0231fac514 Added leading underscore to internal functions, renamed supportsInterfaces. (#1435) 2018-10-18 10:49:01 -03:00
Nicolás Venturo
ff0c048ad9 Added replay attack notice to SignatureBouncer. (#1434) 2018-10-18 10:47:55 -03:00
Nicolás Venturo
96d6103e0b Made some inherit-only contracts internal. (#1433) 
* Made some inherit-only contracts internal.

* Added OwnableMock.
 2018-10-18 10:47:35 -03:00
Nicolás Venturo
df3c113711 Made some TokenVesting public functions private. (#1427) 
* Made some TokenVesting public functions private.

* Fixed linter error.
 2018-10-17 18:18:41 -03:00
Nicolás Venturo
f3df2dab3d Moved Escrows into an escrow subdirectory, improved docs. (#1430) 
* Moved Escrows into an escrow subdirectory, improved docs.

* Fixed escrow mock.

* Fixed some more imports.
 2018-10-17 17:22:25 -03:00
Nicolás Venturo
cfef58361f Removed default value assignments. (#1432) 2018-10-17 17:00:12 -03:00
Nicolás Venturo
d8ab8a00f2 Moved some test files around to better reflect the directory layout. (#1428) 2018-10-17 16:58:49 -03:00
Nicolás Venturo
2733cb4a41 Now using hex for asm memory addresses. (#1429) 2018-10-17 16:58:36 -03:00
Paweł Winnicki
03765e08b9 Make state variables private (#1426) 
* added function to renounce ownership

* Make state variables private (#1411)
 2018-10-17 11:35:31 -03:00
Nicolás Venturo
9be0f100c4 Removed BreakInvariantBounty. (#1424) 2018-10-16 17:21:24 -03:00
Nicolás Venturo
a3e312d133 Added Math.sol docstrings. (#1423) 2018-10-16 17:21:08 -03:00
Nicolás Venturo
3341dd8899 Fixed a typo in a comment. (#1422) 2018-10-16 17:20:55 -03:00
Nicolás Venturo
3bd30f7382 Roles.add and remove now require pre-conditions on the account. (#1421) 2018-10-16 17:20:33 -03:00
Aniket
844a96d0b9 RefundEscrow's events renamed (#1418) 
* fixes #1414
 2018-10-16 10:37:04 -03:00
Mikhail Melnik
03dfb2965c Improve encapsulation on ERC165 and update code style guide (#1379) 
* use prefix underscore for internal state variables

* make _supportedInterfaces private
 2018-10-12 19:13:35 -03:00
Nicolás Venturo
9f822906b8 First test helpers tests (#1369) 
* Removed unused advanceToBlock.

* Added advanceBlock tests.

* Fixed advanceToBlock tests.

* Added single argument tests.

* Finished inLogs tests.

* Fixed linter errors.

* Fixed linter errors.
 2018-10-10 20:55:10 -03:00
Nicolás Venturo
eb92fd1f48 Fix typo in ARCHITECTURE.md (#1406) 2018-10-10 15:15:38 -03:00
Leo Arias
076cb7decd Add a code style rule to make all state variables private (#1390) 2018-10-10 12:06:22 -06:00
Aniket
da67e435b1 Non-constructor initialization removed (#1403) 
* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776f4.

* updates

* fixes #1391
 2018-10-10 09:33:26 -03:00
Nicolás Venturo
b0da0fded0 Replaced assertJump, assertRevert and expectThrow with shouldFail. (#1363) 
* Replaced assertJump, assertRevert and expectThrow with shouldFail.

* Fixed linter errors.

* Fixed typo.

* Made the helpers async.
 2018-10-09 16:23:55 -03:00
Aniket
58a42443df added a test helper with common constants (#1400) 
* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776f4.

* updates

* fixes #1206
 2018-10-09 15:46:09 -03:00
Aniket
af42c39e6c Improves Ownable events (#1397) 
* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776f4.

* updates

* fixes #1392

* event tests added

* constructor event added
 2018-10-09 13:32:45 -03:00
Nicolás Venturo
3acc2b4216 Added a constructor to BreakInvariantBounty. (#1395) 2018-10-08 17:01:35 -06:00
Jakub Bogacz
f7e53d90fa Add Arrays library with unit tests (#1209) (#1375) 
*     Add Arrays library with unit tests (#1209)

    * prepared due to snapshot token requirements
    * add library with method to find upper bound
    * add unit test for basic and edge cases

* Imporove documentation for Arrays library

Simplify Arrays.test.js to use short arrays as test date

* Added comment for uint256 mid variable.
* Explaned why uint256 mid variable calculated as Math.average is safe to use as index of array.
 2018-10-08 11:01:33 -03:00
Aniket
41f84f8b40 Removed selfdestruct from BreakInvariantBounty (#1385) 
* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776f4.

* updates

* fixes #1384

* introduced claimable and cancelBounty

* cancelBounty tests

* Update BreakInvariantBounty.test.js
 2018-10-08 10:51:06 -03:00
Nicolás Venturo
b17de011dc Removed old, unused mocks. (#1382) 2018-10-05 19:18:59 -06:00
Nicolás Venturo
308e5e9cc0 Removed unnecessary Secondary inheritance from RefundEscrow. (#1381) 2018-10-04 11:15:22 -03:00
Francisco Giordano
744f567f40 Separate ERC721Mintable (#1365) 
* separate part of ERC721Mintable into ERC721MetadataMintable

* remove mint and burn from 721 tests

* Fixed linter error.

* fix ERC721 mint tests

* Minor fixes.
 2018-10-04 11:10:08 -03:00
Aniket
b41b125c15 this is used in tests (#1380) 
* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776f4.

* updates

* fixes #1200

* suggested change
 2018-10-04 09:57:37 -03:00
Aniket
fd4de77651 Replaces amount with value for consistency (#1378) 
* fixes #1372

* done in ERC20Capped and ERC20Mintable
 2018-10-04 07:51:52 -03:00
Francisco Giordano
ace14d3ad7 Add note about compiling artifacts to releasing steps (#1377) 
* add note about compiling artifacts to release notes

* add explanation of truffle bug
 2018-10-03 23:17:06 -03:00
Francisco Giordano
5c228805ad Update issue templates (#1376) 
* Update issue templates

* improve pull request template

* remove previous issue template
 2018-10-03 23:13:46 -03:00
Aniket
c87433e0c2 Prevents Bounty from being claimed twice (#1374) 
* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776f4.

* updates

* fixes #1356

* Removed extra semicolon.
 2018-10-03 12:50:01 -03:00
Aniket
f3888bb0b0 Removing unrequired _burn() override (#1373) 
* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776f4.

* updates

* fixes #1371

* Removed extra whitespace
 2018-10-03 12:23:08 -03:00