2514959f34
Fixed a typo in a comment. ( #1422 )
...
(cherry picked from commit 3341dd8899
2018-10-20 22:01:54 +00:00
1b79b536cd
Roles.add and remove now require pre-conditions on the account. ( #1421 )
...
(cherry picked from commit 3bd30f7382
2018-10-20 22:01:22 +00:00
e990525c2e
RefundEscrow's events renamed ( #1418 )
...
* fixes #1414
(cherry picked from commit 844a96d0b9
2018-10-20 22:00:49 +00:00
2c40ffa011
Improve encapsulation on ERC165 and update code style guide ( #1379 )
...
* use prefix underscore for internal state variables
* make _supportedInterfaces private
(cherry picked from commit 03dfb2965c
2018-10-20 22:00:13 +00:00
10a5864fdf
First test helpers tests ( #1369 )
...
* Removed unused advanceToBlock.
* Added advanceBlock tests.
* Fixed advanceToBlock tests.
* Added single argument tests.
* Finished inLogs tests.
* Fixed linter errors.
* Fixed linter errors.
(cherry picked from commit 9f822906b8
2018-10-20 21:59:32 +00:00
7ec6079784
Fix typo in ARCHITECTURE.md ( #1406 )
...
(cherry picked from commit eb92fd1f48
2018-10-20 21:57:17 +00:00
5e82a64a01
Add a code style rule to make all state variables private ( #1390 )
...
(cherry picked from commit 076cb7decd
2018-10-20 21:56:56 +00:00
3266de1b5c
Non-constructor initialization removed ( #1403 )
...
* signing prefix added
* Minor improvement
* Tests changed
* Successfully tested
* Minor improvements
* Minor improvements
* Revert "Dangling commas are now required. (#1359 )"
This reverts commit a6889776f4fixes #1391
(cherry picked from commit da67e435b1
2018-10-20 21:56:18 +00:00
7cd0d5a452
Replaced assertJump, assertRevert and expectThrow with shouldFail. ( #1363 )
...
* Replaced assertJump, assertRevert and expectThrow with shouldFail.
* Fixed linter errors.
* Fixed typo.
* Made the helpers async.
(cherry picked from commit b0da0fded0
2018-10-20 21:54:50 +00:00
620d524398
Improves Ownable events ( #1397 )
...
* signing prefix added
* Minor improvement
* Tests changed
* Successfully tested
* Minor improvements
* Minor improvements
* Revert "Dangling commas are now required. (#1359 )"
This reverts commit a6889776f4fixes #1392
* event tests added
* constructor event added
(cherry picked from commit af42c39e6c
2018-10-20 21:53:33 +00:00
eae40c93b6
this is used in tests (#1380 )
...
* signing prefix added
* Minor improvement
* Tests changed
* Successfully tested
* Minor improvements
* Minor improvements
* Revert "Dangling commas are now required. (#1359 )"
This reverts commit a6889776f4fixes #1200
* suggested change
(cherry picked from commit b41b125c15
2018-10-20 21:35:26 +00:00
109eba9273
Replaces amount with value for consistency ( #1378 )
...
* fixes #1372
* done in ERC20Capped and ERC20Mintable
(cherry picked from commit fd4de77651
2018-10-20 21:32:45 +00:00
13fb1f662a
Fixed test path.
...
(cherry picked from commit f4d6f40442
2018-10-20 21:31:48 +00:00
2f3f0d3c8a
Created test utils directory
...
(cherry picked from commit 269981ee6a
2018-10-20 21:31:34 +00:00
0678f67289
Merged latestTime, increaseTime and duration into a time helper. ( #1364 )
...
(cherry picked from commit 34bc709bc2
2018-10-20 21:31:21 +00:00
b03932529c
Fix/#1355 test helper to check balance difference ( #1368 )
...
* signing prefix added
* Minor improvement
* Tests changed
* Successfully tested
* Minor improvements
* Minor improvements
* Revert "Dangling commas are now required. (#1359 )"
This reverts commit a6889776f4#1355
* linting
* suggested changes
* Update BreakInvariantBounty.test.js
(cherry picked from commit 6ae041bca6
2018-10-20 21:30:15 +00:00
c25a1e366f
Fix #1358 Test helper to send funds ( #1367 )
...
* signing prefix added
* Minor improvement
* Tests changed
* Successfully tested
* Minor improvements
* Minor improvements
* Revert "Dangling commas are now required. (#1359 )"
This reverts commit a6889776f4fixes #1358
* linting done
* suggested changes
(cherry picked from commit fa1dfbd113
2018-10-20 21:29:21 +00:00
598a0358fc
Dangling commas are now required. ( #1359 )
...
(cherry picked from commit a6889776f4
2018-10-20 21:23:12 +00:00
39db4b4b05
Feature/use expect event in test logs assertions #1232 ( #1343 )
...
* Add BigNumber support to expectEvent/inLogs (#1026 )
* switched direct logs array check to expectEvent method in AllowanceCrowdsale.test.js
* Refactor expectEvent.inLogs function to use simple value number check
* Introduced should.be.bignumber method to compare BigNumber values
* Use expectEvent to test logs (#1232 )
* Removed trailing space
(cherry picked from commit 536262f2ec
2018-10-20 21:22:54 +00:00
a9af619c59
Add BigNumber support to expectEvent/inLogs ( #1026 ) ( #1338 )
...
* Add BigNumber support to expectEvent/inLogs (#1026 )
* switched direct logs array check to expectEvent method in AllowanceCrowdsale.test.js
* Refactor expectEvent.inLogs function to use simple value number check
* Introduced should.be.bignumber method to compare BigNumber values
* Destructure transaction object to extract logs field
(cherry picked from commit 947de54cee
2018-10-20 21:22:05 +00:00
62ed8e2fe4
Removed BreakInvariantBounty. ( #1424 )
...
(cherry picked from commit 9be0f100c4
2018-10-20 21:20:57 +00:00
e7aa8dedbc
Turn off blank-lines Solium rule ( #1284 )
...
* turn off blank-lines rule
* remove triple newlines
(cherry picked from commit 9b37104655
2018-10-20 21:07:49 +00:00
49d2dd9e08
Add Mock suffix to variable names #1172 ( #1324 )
...
* Add Mock suffix to variable names #1172
* Add Impl suffix to variable names
(cherry picked from commit 4b21fcf5af
2018-10-20 20:59:51 +00:00
a3bb56769e
Remove lodash from tests ( #1323 )
...
(cherry picked from commit d062352de7
2018-10-20 20:59:13 +00:00
f8b0cec15b
Add unit test specific to Address utils ( #1251 ) ( #1316 )
...
(cherry picked from commit 7825caa1fd
2018-10-20 20:57:15 +00:00
7ea34d9e97
Update ERC20.sol ( #1313 )
...
correct typo in doc
(cherry picked from commit b644c72eb0
2018-10-20 20:56:34 +00:00
2a8146a45d
Fix README snippet typo
...
(cherry picked from commit 0b8296e525
2018-10-20 20:55:59 +00:00
2e14386eda
fix readme snippet so it is concrete
...
(cherry picked from commit 651f6d8b57
2018-10-20 20:54:53 +00:00
9f5b73df37
added a test helper with common constants ( #1400 )
...
* signing prefix added
* Minor improvement
* Tests changed
* Successfully tested
* Minor improvements
* Minor improvements
* Revert "Dangling commas are now required. (#1359 )"
This reverts commit a6889776f4fixes #1206
(cherry picked from commit 58a42443df
2018-10-18 19:05:17 -03:00
a811a0be28
Improves Ownable events ( #1397 )
...
* signing prefix added
* Minor improvement
* Tests changed
* Successfully tested
* Minor improvements
* Minor improvements
* Revert "Dangling commas are now required. (#1359 )"
This reverts commit a6889776f4fixes #1392
* event tests added
* constructor event added
(cherry picked from commit af42c39e6c
2018-10-18 19:03:56 -03:00
9c76d28245
Added a constructor to BreakInvariantBounty. ( #1395 )
...
(cherry picked from commit 3acc2b4216
2018-10-18 19:02:57 -03:00
8d6250cd5a
Add Arrays library with unit tests ( #1209 ) ( #1375 )
...
* Add Arrays library with unit tests (#1209 )
* prepared due to snapshot token requirements
* add library with method to find upper bound
* add unit test for basic and edge cases
* Imporove documentation for Arrays library
Simplify Arrays.test.js to use short arrays as test date
* Added comment for uint256 mid variable.
* Explaned why uint256 mid variable calculated as Math.average is safe to use as index of array.
(cherry picked from commit f7e53d90fa
2018-10-18 19:02:50 -03:00
66bad4ff2a
Removed selfdestruct from BreakInvariantBounty ( #1385 )
...
* signing prefix added
* Minor improvement
* Tests changed
* Successfully tested
* Minor improvements
* Minor improvements
* Revert "Dangling commas are now required. (#1359 )"
This reverts commit a6889776f4fixes #1384
* introduced claimable and cancelBounty
* cancelBounty tests
* Update BreakInvariantBounty.test.js
(cherry picked from commit 41f84f8b40
2018-10-18 19:02:42 -03:00
41e74dd8d8
Removed old, unused mocks. ( #1382 )
...
(cherry picked from commit b17de011dc
2018-10-18 18:53:09 -03:00
2d30918149
Release candidate v2.0.0-rc.3
2018-10-04 11:17:57 -03:00
0db1f8144d
Removed unnecessary Secondary inheritance from RefundEscrow. ( #1381 )
...
(cherry picked from commit 308e5e9cc0
2018-10-04 11:15:53 -03:00
ffeae0d83e
ERC20 internal transfer method ( #1370 )
...
(cherry picked from commit 43ebb4fc43
2018-10-04 11:14:05 -03:00
38ca422170
Removing unrequired _burn() override ( #1373 )
...
* signing prefix added
* Minor improvement
* Tests changed
* Successfully tested
* Minor improvements
* Minor improvements
* Revert "Dangling commas are now required. (#1359 )"
This reverts commit a6889776f4fixes #1371
* Removed extra whitespace
(cherry picked from commit f3888bb0b0
2018-10-04 11:13:05 -03:00
7c984968d8
Prevents Bounty from being claimed twice ( #1374 )
...
* signing prefix added
* Minor improvement
* Tests changed
* Successfully tested
* Minor improvements
* Minor improvements
* Revert "Dangling commas are now required. (#1359 )"
This reverts commit a6889776f4fixes #1356
* Removed extra semicolon.
(cherry picked from commit c87433e0c2
2018-10-04 11:12:45 -03:00
bd8345a153
Separate ERC721Mintable ( #1365 )
...
* separate part of ERC721Mintable into ERC721MetadataMintable
* remove mint and burn from 721 tests
* Fixed linter error.
* fix ERC721 mint tests
* Minor fixes.
(cherry picked from commit 744f567f40
2018-10-04 11:12:05 -03:00
76169cda40
Fixed a broken payment test (+ another small fix) ( #1318 )
...
* Fixed a broken payment test
* In PR template, npm run lint:fix, not lint:all:fix
* In SplitPayment test, replaced an await-in-loop with Promise.all
(cherry picked from commit b79196f911
2018-09-28 11:36:06 -03:00
08bf6bbed9
Add missing tests to ECSDA ( #1248 )
...
* fix: refactor sign.js and related tests
* fix: remove unused dep
* fix: update package.json correctly
* Add missing tests to ECRecovery
* fix lint
* Reorganize the tests
* Reuse signature
* fix static errors
* Apply suggestions by @frangion and @nventuro
* Remove only
* More suggestions
* Remove unnecessary max-len
* remove only
(cherry picked from commit 75c0a59bb4
2018-09-28 11:28:46 -03:00
8c394de450
Add SignatureBouncer test for when msg.data is too short ( #1360 )
...
* add test for msg.data too short
* fix test to hit that branch
* Update SignatureBouncer.test.js
(cherry picked from commit 1a4e5346ed
2018-09-28 09:38:48 -03:00
fa5ecd03cb
Improved bounty tests. ( #1350 )
...
* Improved bounty tests.
* Fixed linter errors.
* Addressed review comments.
(cherry picked from commit ae109f69cc
2018-09-26 16:37:31 -03:00
1b0c6b94b9
Removed mintingFinished. ( #1351 )
...
* Removed mintingFinished from ERC20Mintable.
* Removed MintingFinished from ERC721Mintable.
* Removed MintingFinished event.
(cherry picked from commit 5fdeaa81d5
2018-09-26 16:06:27 -03:00
652243b7c3
Removed assertions from Escrow and SplitPayment. ( #1349 )
...
(cherry picked from commit db2e1d2c74
2018-09-26 12:57:15 -03:00
c9e8a66e85
Add the missing test for ERC721Holder ( #1249 )
...
* Add the missing test for ERC721Holder
* fix lint
* Move the holder test to a separate file
(cherry picked from commit 396680b856
2018-09-26 12:15:08 -03:00
e7c99dd7dd
Roles now emit events in construction and when renouncing. ( #1329 )
...
* release candidate v2.0.0-rc.1
* fix linter error
(cherry picked from commit c12a1c689821198bf1c1
2018-09-26 12:14:34 -03:00
dac5bccf80
release candidate v2.0.0-rc.2
2018-09-18 19:22:04 -03:00
f22adbb742
Fixed relative imports. ( #1321 )
...
(cherry picked from commit 225b492109
2018-09-18 18:11:55 -03:00
