bd13be9174
lint
2019-05-23 18:20:36 -03:00
2f9ae975c8
merge api docs changes
...
Squashed commit of the following:
commit 06243c3e8e86074ff8e9e3f22b7829a2c315d707
Merge: 991882ec 99373558
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Thu May 23 18:15:37 2019 -0300
Merge branch 'api-docs' into api-docs-merge
commit 991882eca5bb8a3391995154bfb9d53d8a69cb4f
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Thu May 23 18:08:02 2019 -0300
manually apply docs changes and renamings
commit fa1f6e97dd67a76c3cd828d0a5e19b4ac6c37acb
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Thu May 23 17:36:03 2019 -0300
move functions to new order
commit 99373558e3af4905d29bc6f3f542ba93d28a24ab
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Thu May 23 16:23:40 2019 -0300
add missing docs links
commit d180d6c36a6f5460e85473ee5a18992d1449a6ff
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Thu May 23 16:14:12 2019 -0300
update solidity-docgen dependency
fixes uri encoded links
commit faab0e50da91cd2f0a409e3ad32e2db127ad319a
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Thu May 23 16:05:03 2019 -0300
update openzeppelin-docsite and solidity-docgen dependencies
add visibility specifiers
commit ef305268bb2735e488e35d16819a4b432b3a35e3
Author: Nicolás Venturo <nicolas.venturo@gmail.com >
Date: Thu May 23 15:36:45 2019 -0300
Fix guide links.
commit 339b20dbfa2d5f6ea02e63c2f3fdcba0fe879c3c
Author: Nicolás Venturo <nicolas.venturo@gmail.com >
Date: Thu May 23 13:37:51 2019 -0300
Fix typos.
commit 6c7b97460578b9eea90b53c280454e361f8f0052
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Thu May 23 15:26:29 2019 -0300
fix utilities guide links
commit 0e7692a8fd8516a11becc4121d77d792439600b1
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Thu May 23 15:23:19 2019 -0300
update solidity-docgen dependency
commit ebb8a8651516ece21736c6c3b2577eb1b3487651
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Thu May 23 15:15:01 2019 -0300
fix utilities guide links
commit 5ec47d62785e1d6e5f8e91edca58f2dc7f87d7a3
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Thu May 23 15:14:49 2019 -0300
fix escrow docs ordering
commit cdcdc909b16f219a9a3272036b6a8f21e34b48ef
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Thu May 23 13:35:07 2019 -0300
add wip notice
commit 987e2951ae93211c8c70c8288e30573555c57830
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Thu May 23 13:09:35 2019 -0300
update openzeppelin-docsite dependency
fixes links to old versions
commit b00d22c0affac2e2108df8b773dfa1706afcb44e
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Thu May 23 13:09:28 2019 -0300
fix guide links
commit f112a9400c5e5ad495c8e0fdb972e26987b34244
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Wed May 22 20:42:37 2019 -0300
update docsite
commit 68aacdd56a29e35a84f6732f9293612bbcaf7520
Author: Nicolás Venturo <nicolas.venturo@gmail.com >
Date: Wed May 22 20:00:39 2019 -0300
ERC20Capped
commit 4edce78bab2c6d140f3ea3f33db71e92ca4d8aaf
Author: Nicolás Venturo <nicolas.venturo@gmail.com >
Date: Wed May 22 19:52:30 2019 -0300
Unnecessary polish on token docs.
commit 2a4c91cf49c2736dc09c1c03cf383911def1a1b2
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Wed May 22 19:20:05 2019 -0300
rename guides
commit 61dd818ea76d4c170c4ab175c6be0d6067d21a29
Author: Nicolás Venturo <nicolas.venturo@gmail.com >
Date: Wed May 22 17:04:09 2019 -0300
ERC1820 docs.
commit 77b5f0353123b76358dc6d86bdc646c86c9b0bea
Author: Nicolás Venturo <nicolas.venturo@gmail.com >
Date: Wed May 22 16:17:34 2019 -0300
Introspection and ERC165.
commit 76641a253b3b70279802c5134dd107532eea4b2c
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Wed May 22 17:59:53 2019 -0300
update docgen
commit 7be98bc3fbd3566231f943f01b9acb58567d755b
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Wed May 22 17:23:50 2019 -0300
update solidity-docgen
commit f7268e6e010f8ef9ac83df241a803f91efc08c0c
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Wed May 22 16:58:31 2019 -0300
update docgen
commit 2a8c7a378e8962a5baeb334b2492815f05075f98
Author: Nicolás Venturo <nicolas.venturo@gmail.com >
Date: Wed May 22 14:36:35 2019 -0300
Util docs.
commit 327ae8ff45a1a523c7591bf4996c4a9b52d7ec7a
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Wed May 22 13:08:50 2019 -0300
add missing drafts
commit 5e7f71335ac8423c0e363ae8c7ad9b2977f202f8
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Wed May 22 12:47:41 2019 -0300
tweak ierc20 docs
commit cd0e86a0b712f74ffd406e072d4b1fbf4dd2c176
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Wed May 22 12:46:45 2019 -0300
add some erc721 docs
commit e081184159417f71da14bc0fc110b7b11e29d75d
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Wed May 22 12:41:46 2019 -0300
update docsite
commit 0beb75784022419d47123c2a9fe7a5f1eb87f9b2
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Wed May 22 12:22:27 2019 -0300
correct drafts structure
commit 2e94b287c7cead7a6c0603205670566461c31abb
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Wed May 22 11:56:25 2019 -0300
fix docsite-start script
commit 0fa4160484309d0851584fe57c0d81a3600977db
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Wed May 22 11:47:44 2019 -0300
improve docsite start script (automatically watch docgen)
commit 9d571897cc03bee92035964cf7a2cfeda1e2f690
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Wed May 22 11:30:37 2019 -0300
update solidity-docgen
commit 82980f5aefbdfb8a9815a3b7b0e88e970b65dd5d
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Tue May 21 19:15:13 2019 -0300
edit docs for Secondary
commit 00d7a005b0530bee730b77a1b69a95f1b4ffe315
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Tue May 21 19:15:13 2019 -0300
edit docs for ownable
commit b0c4c2bdf83eca5d4a71792daac603236733d46e
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Tue May 21 18:27:13 2019 -0300
change title of Math section
commit deb788583f191780e55b7f673520eaf13a5c7e23
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Tue May 21 18:26:59 2019 -0300
capitalization
commit f2bcf85d343ea4a0739fe22a77b1e22c2296ddea
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Tue May 21 18:26:06 2019 -0300
edit docs for Pausable
commit 73ba0cf43dbb44c39c1bf2ee63ef9fe558faa919
Author: Nicolás Venturo <nicolas.venturo@gmail.com >
Date: Sat May 18 19:08:06 2019 -0300
Crypto docs.
commit 9d6fc6223f51cf2321b2e3217c512579654c3917
Merge: 7e21f8f7 9f1cec12
Author: Nicolás Venturo <nicolas.venturo@gmail.com >
Date: Fri May 17 17:23:15 2019 -0300
Merge branch 'api-docs-777' into api-docs
commit 9f1cec12e3351fb1b5fc0b59f5ded39928064a56
Author: Nicolás Venturo <nicolas.venturo@gmail.com >
Date: Fri May 17 17:22:54 2019 -0300
ERC777 done.
commit 7e21f8f7b6982d2f92df302cdf6ec62522d8ffff
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Fri May 17 16:39:47 2019 -0300
add math docs
commit f18d1f17023b6e5b42ae04fc38aa1170e6863864
Author: Nicolás Venturo <nicolas.venturo@gmail.com >
Date: Thu May 16 20:01:46 2019 -0300
First draft of ERC777 docs.
commit 985c5d3053nicolas.venturo@gmail.com >
Date: Thu May 16 19:14:32 2019 -0300
Final draft for IERC777.
commit bf53f133d987b67f938a329e6d659ba3483aab0b
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Thu May 16 19:13:37 2019 -0300
more work on ERC20 api docs
commit b7c250b7cbnicolas.venturo@gmail.com >
Date: Thu May 16 17:08:47 2019 -0300
Fix typo.
commit 197bbfbfc6nicolas.venturo@gmail.com >
Date: Thu May 16 17:05:14 2019 -0300
Initial draft of IERC777.
commit 7dc3b55161c860437a8f13a2ce5808b1c3dd70a2
Author: Francisco Giordano <frangio.1@gmail.com >
Date: Thu May 16 11:58:32 2019 -0300
add payment docs structure
commit da16fc4480nicolas.venturo@gmail.com >
Date: Thu May 16 16:05:33 2019 -0300
Initial ERC777 docstrings.
commit 9f6a7e35bdfrangio.1@gmail.com >
Date: Wed May 15 22:13:17 2019 -0300
partial pass through ERC20 docs
2019-05-23 18:17:18 -03:00
ee7ff81728
Improve prepack script ( #1747 )
...
* improve prepack script
* remove .npmignore
* make prepack use pkg.files
* fix linter errors
(cherry picked from commit cc19ccfdb3
2019-05-22 19:14:03 -03:00
9ab93f8ae4
Update transferFrom to modify allowance in-between hook calls. ( #1751 )
...
* Fix transferFrom not updating allowance before calling receiver.
* Fix from being passed as operator.
(cherry picked from commit 2ccc12b328
2019-05-16 16:07:45 -03:00
f7ff3e7e67
Disallow ERC20._transfer from the zero address. ( #1752 )
...
* Add requirement of non-zero from to ERC20 transfer.
* Add test for transferFrom zero address to behavior.
* Create ERC20.transfer behavior.
* Add tests for _transfer.
* Add changelog entry.
* Fix linter error.
* Delete repeated test.
* Fix hardcoded error prefix.
* Update CHANGELOG.md
Co-Authored-By: Francisco Giordano <frangio.1@gmail.com >
* Address review comments.
(cherry picked from commit ad18098d65
2019-05-16 16:07:37 -03:00
2ccc12b328
Update transferFrom to modify allowance in-between hook calls. ( #1751 )
...
* Fix transferFrom not updating allowance before calling receiver.
* Fix from being passed as operator.
2019-05-16 16:01:02 -03:00
ad18098d65
Disallow ERC20._transfer from the zero address. ( #1752 )
...
* Add requirement of non-zero from to ERC20 transfer.
* Add test for transferFrom zero address to behavior.
* Create ERC20.transfer behavior.
* Add tests for _transfer.
* Add changelog entry.
* Fix linter error.
* Delete repeated test.
* Fix hardcoded error prefix.
* Update CHANGELOG.md
Co-Authored-By: Francisco Giordano <frangio.1@gmail.com >
* Address review comments.
2019-05-16 11:50:54 -03:00
cc19ccfdb3
Improve prepack script ( #1747 )
...
* improve prepack script
* remove .npmignore
* make prepack use pkg.files
* fix linter errors
2019-05-14 16:04:40 -03:00
81d04101ff
Fix linter.
...
(cherry picked from commit c92b75305e
2019-05-08 16:17:59 -03:00
1292b6abab
Move ERC1820 and ERC777 out of drafts ( #1742 )
...
* Moved ERC1820 related contracts out of drafts and into introspection.
* Moved ERC777 related contracts out of drafts and into token.
(cherry picked from commit c794c96617
2019-05-08 16:15:39 -03:00
44590fe0b6
Inline keccak256 result ( #1741 )
...
* inline keccak256 result
* Update ERC777.sol
* switch hex constant style
* Update ERC777.sol
(cherry picked from commit e60c7904d4
2019-05-08 16:15:28 -03:00
6c2b7c260d
Add ERC20 compatibility to ERC777. ( #1735 )
...
* Add ERC20 compatibility.
* Reusing ERC20 tests for ERC777.
* Improve documentation.
* Add changelog entry.
* Improved ERC20 behavior tests.
* Add revert reasons to ERC777.
* ERC20 methods allow sending tokens to contracts with no interface.
* Register ERC20 interface.
* Add comment about avoidLockingTokens.
* Improve revert reason string.
* Make ERC777 implement IERC20.
* Fix test revert string.
* Remove unnecesary require.
* Add private _transfer.
* Update contracts/drafts/ERC777/ERC777.sol
Co-Authored-By: nventuro <nicolas.venturo@gmail.com >
* Update private helper names.
(cherry picked from commit aa4c9feabd
2019-05-08 16:15:19 -03:00
835c23d6f7
Hardcode ERC777 granularity to 1, remove tests. ( #1739 )
...
* Hardcode ERC777 granularity to 1, remove tests.
* Add clarifying title comment.
(cherry picked from commit 376820d55c
2019-05-08 16:15:04 -03:00
c794c96617
Move ERC1820 and ERC777 out of drafts ( #1742 )
...
* Moved ERC1820 related contracts out of drafts and into introspection.
* Moved ERC777 related contracts out of drafts and into token.
2019-05-08 16:11:00 -03:00
c92b75305e
Fix linter.
2019-05-08 16:09:30 -03:00
e60c7904d4
Inline keccak256 result ( #1741 )
...
* inline keccak256 result
* Update ERC777.sol
* switch hex constant style
* Update ERC777.sol
2019-05-08 15:12:13 -03:00
aa4c9feabd
Add ERC20 compatibility to ERC777. ( #1735 )
...
* Add ERC20 compatibility.
* Reusing ERC20 tests for ERC777.
* Improve documentation.
* Add changelog entry.
* Improved ERC20 behavior tests.
* Add revert reasons to ERC777.
* ERC20 methods allow sending tokens to contracts with no interface.
* Register ERC20 interface.
* Add comment about avoidLockingTokens.
* Improve revert reason string.
* Make ERC777 implement IERC20.
* Fix test revert string.
* Remove unnecesary require.
* Add private _transfer.
* Update contracts/drafts/ERC777/ERC777.sol
Co-Authored-By: nventuro <nicolas.venturo@gmail.com >
* Update private helper names.
2019-05-08 13:13:19 -03:00
376820d55c
Hardcode ERC777 granularity to 1, remove tests. ( #1739 )
...
* Hardcode ERC777 granularity to 1, remove tests.
* Add clarifying title comment.
2019-05-07 17:05:12 -03:00
ae919629cd
Revert Solidity version bump. ( #1729 )
...
(cherry picked from commit 67bca857ee
2019-04-24 19:33:32 -03:00
67bca857ee
Revert Solidity version bump. ( #1729 )
2019-04-24 19:32:08 -03:00
2f8e844514
Fix remaining revert reasons.
2019-04-24 11:25:09 -03:00
3682c6575c
Added message string for require() ( #1704 )
...
* Error handling in ERC20 and ERC721
* Added message string for require.
* Fixed solhint errors.
* Updated PR as per issue #1709
* changes as per #1709 and openzeppelin forum.
* Changes in require statement
* Changes in require statement
* build pipeline fix
* Changes as per @nventuro's comment.
* Update revert reason strings.
* Fianal update of revert reason strings.
* WIP: Updating reason strings in test cases
* WIP: Added changes to ERC20 and ERC721
* Fixes linting errors in *.tes.js files
* Achieved 100% code coverage
* Updated the test cases with shouldFail.reverting.withMessage()
* Fix package-lock.
* address review comments
* fix linter issues
* fix remaining revert reasons
2019-04-24 11:17:08 -03:00
97a9ca5681
Add a vault to PostDeliveryCrowdsale. ( #1721 )
...
* Add a vault to PostDeliveryCrowdsale.
* Add changelog entry.
* Apply suggestions from code review
Co-Authored-By: nventuro <nicolas.venturo@gmail.com >
* Rename TokenVault.
* add solhint ignore directive
2019-04-23 19:06:09 -03:00
19c7414052
Bump minimum Solidity version to 0.5.7 ( #1724 )
...
* Bump Solidity version to 0.5.7
* Add changelog entry.
2019-04-23 16:18:08 -03:00
ed5652b0aa
New documentation setup ( #1708 )
...
* initial docsite setup
* switch from pushd to cd
* install and set up solidity-docgen
* use the docsite branch next for now
* make it clear that env var is a repository
* add a clarifying comment about a relative path
* change relative to absolute path in docsite script
* add docgen script
* add first few READMEs for contract documentation
* update solidity-docgen
* add docsite as dependency and adjust script
* update openzeppelin-docsite
* update solidity-docgen
* remove dummy text
* update docgen and docsite
* update openzeppelin-docsite
* add netlify.toml
* udpate tokens guide for 2.2
* add DOCUMENTATION.md
* Update docs/learn-about-utilities.md
Co-Authored-By: frangio <frangio.1@gmail.com >
* fix PaymentSplitter docs wording
* update solidity-docgen
* add missing ERC20 contracts
* update solidity-docgen
* trigger deploy with cleared cache
* update solidity-docgen
* update openzeppelin-docsite
* remove travis docs setup
* update openzeppelin-docsite
* switch to published solidity-docgen
2019-04-23 12:25:22 -03:00
0df0e1b250
Fixes/Improves constants inline documentation. ( #1707 )
...
* Fixes/Improves constants inline documentation.
* Fixed solhint error.
* Moved the comment before the variable
2019-04-17 16:38:33 -03:00
5a2b349992
Feature/erc777 #1159 ( #1684 )
...
* IERC777 from specs, constants returned, up to defaultOperators. (#1159 )
* IERC777 oprarator approvals (#1159 )
* ERC777 oprarator approvals fixes and tests
* IERC777 send and receive with ERC820 (#1159 )
* ERC777 Add burn functions and fix send functions (#1159 )
* ERC777 Make expectEvent compatible with web3.js 1.0 (#1159 )
* ERC777 Add ERC820 deploy script (#1159 )
* ERC777 Complete implementation of ERC777 (#1159 )
This implementation conforms to the current EIP
* ERC777 Update ERC820 Registry contract to final version (#1159 )
* ERC777 Move contracts to 'drafts' folder (#1159 )
* ERC777: Update to ERC1820 registry and linter error fix (#1159 )
* ERC777: implement recent changes of EIP777 (#1159 )
* ERC777 Fix formatting (#1159 )
* ERC777 Update to solc 0.5.2 (#1159 )
* ERC777 Fix travis CI errors (#1159 )
* ERC777 Fix linter errors again... (#1159 )
* ERC777 Fix unit test (#1159 )
* ERC777 Fix unit test again (#1159 )
* Remove extra newlines.
* Rename ERC777Base to ERC777.
* Remove 'Token' from contract names.
* Replace ops for operators.
* Move operator check out of _send.
* Remove ERC777Burnable.
* Remove ERC1820Client, now using the interface directly.
* Minor internal refactors in contracts.
* Delete extra test helpers.
* Simplified tests.
* Add basic 777 tests.
* Add granularity send test.
* Add first operator send tests.
* Add burn tests.
* Refactor send and burn tests.
* Improve send burn refactor.
* Greatly improve test module.
* Burn instead of send removed tokens.
* Add operator tests.
* Improve send tests under changing operators.
* Refactor and merge send and burn tests.
* Add missing and not-implemented tests.
* Make _burn private.
* Fix typo.
* Greatly improve tokensToSend tests.
* Refactor hook tests.
* Fix hook tests.
* Update openzeppelin-test-helpers and ERC1820 address.
* Fix natspec indentation.
* Make interface functions external.
* Remove redundant private revoke and authorize functions.
* Improved readability of if statement.
* Remove unnecessary asserts.
* Add non-one granularity test.
* Fix hook call order in _mint.
* Fix _mint not reverting on failure to implement tokensReceived.
* Remove special case in operatorFn when from is 0.
* Refactor ERC777SenderMock.
* Add tokensReceived tests.
* switch to updated ganache-cli-coverage fork
* Fix linter errors.
* Add mint tests.
* Fix linter errors.
* Fix tests.
* Update test/drafts/ERC777/ERC777.test.js
Co-Authored-By: nventuro <nicolas.venturo@gmail.com >
* Add changelog entry.
2019-04-16 13:13:46 -03:00
1ebeef7ffd
Remove unnecessary SLOAD. ( #1715 )
2019-04-10 12:29:58 -03:00
b353f7e18c
Add more extensive documentation to PaymentSplitter ( #1713 )
...
* Update PaymentSplitter.sol
* add back private function docs
* add non-zero address requirement
* add comprehensive contract-level docs
* use capital E for Ether
2019-04-09 19:47:20 -03:00
35d8e860ad
Remove unused files ( #1698 )
...
* Remove unused dependencies.
* Remove unused mock contracts.
2019-04-01 15:00:39 -03:00
3cb4a00fce
Added basic punctuation to @dev docs ( #1697 ) ( #1700 )
...
* Added basic punctuation to @dev docs (#1697 )
* add missing uppercase
2019-03-30 16:48:17 -03:00
7ccd224567
Update SafeERC20.sol ( #1693 )
2019-03-25 14:27:26 -03:00
308a4c9907
Draft EIP 1820 ( #1677 )
...
* Add barebones EIP1820 support.
* Update openzeppelin-test-helpers dependency to have ERC1820 support.
* Add tests for ERC1820.
* Improve inline documentation.
* Add changelog entry.
* Update test-helpers, refactor tests to use new helpers.
* Rename ERC1820 to ERC1820Implementer.
* Improve implementer docstring.
* Remove _implementsInterfaceForAddress.
* update openzeppelin-test-helpers to 0.2.0
* Update contracts/drafts/ERC1820Implementer.sol
Co-Authored-By: nventuro <nicolas.venturo@gmail.com >
* Fix how solidity coverage is run to allow for free events.
* Fix coverage testing script.
2019-03-19 15:13:55 -03:00
269e096c5a
Remove unused return variables. ( #1686 )
2019-03-19 11:51:46 -03:00
4c706480e5
Fix typo in ERC20Snapshot. ( #1670 )
2019-03-12 13:15:08 -03:00
79dd498b16
Signature Malleability: ( #1622 )
...
* Transaction Malleability:
If you allow for both values 0/1 and 27/28, you allow two different
signatures both resulting in a same valid recovery. (r,s,0/1) and
(r,s,27/28) would both be valid, recover the same public key and sign
the same data. Furthermore, given (r,s,0/1), (r,s,27/28) can be
constructed by anyone.
* Transaction Malleability:
EIP-2 still allows signature malleabality for ecrecover(), remove this
possibility and force the signature to be unique.
* Added a reference to appendix F to the yellow paper and improved
comment.
* better test description for testing the version 0, which returns
a zero address
* Check that the conversion from 0/1 to 27/28 only happens if its 0/1
* improved formatting
* Refactor ECDSA code a bit.
* Refactor ECDSA tests a bit.
* Add changelog entry.
* Add high-s check test.
2019-03-07 12:44:28 -03:00
547a5f242a
Add extcodesize check to SafeERC20. ( #1662 )
...
* Add extcodesize check to SafeERC20.
* Clarify some comments.
* Replace inline assembly with Address.sol.
2019-03-06 14:11:08 -03:00
352ec94579
Add TimedCrowdsale::_extendTime ( #1636 )
...
* Add TimedCrowdsale::_extendTime
* Add tests for TimedCrowdsale extending method
* Reverse event arguments order
* Rename method argument
* Refactor TimedCrowdsale test
* Simplify TimedCrowdsaleImpl
* Fix extendTime method behaviour to deny TimedCrowdsale re-opening after it was ended
* Append chengelog
* Update CHANGELOG.md
Co-Authored-By: k06a <k06aaa@gmail.com >
* Update contracts/crowdsale/validation/TimedCrowdsale.sol
Co-Authored-By: k06a <k06aaa@gmail.com >
* Improve tests
2019-03-06 11:38:57 -03:00
3772233cf5
Add guard to ERC20Migrator migrate function ( #1659 )
...
* Add guard to ERC20Migrator migrate function
* Add tests for premature migration in ERC20Migrator
These tests apply to the new guard condition, but they don't
fail without it, since the functions revert anyway.
They are added for completeness and to ensure full code coverage.
* Use context block around premature migration tests
We should use context blocks for situational details
and describe for features or functions.
2019-03-02 12:36:36 -03:00
8cc3349d1f
Fix typo: "an uint256" -> "a uint256" ( #1658 )
...
Using "a" instead of "an" makes this consistent with the comment on `allowance`.
2019-03-01 10:03:19 -05:00
41aa39afbc
Add no-return-data ERC20 support to SafeERC20. ( #1655 )
...
* Add no-return-data ERC20 support to SafeERC20.
* Add changelog entry.
* Replace abi.encodeWithSignature for encodeWithSelector.
* Remove SafeERC20 test code duplication.
* Replace assembly for abi.decode.
* Fix linter errors.
2019-02-28 17:34:46 -03:00
0dded493a0
Nonfunctional typos #1643 ( #1652 )
...
* Add IntelliJ IDE config to .gitignore
* Fix variable name in ERC20 function comments
* Fix typos in Arrays function comment
* Fix typos in ownership test names
* Fix typo in Pausable test name
* Fix grammar in Ownable function comment
* Fix grammar in Crowdsale contract comment
* Fix typo in Counters contract comment
* Fix typo in ERC721Enumerable comment
* Fix typo in ERC721PausedToken test name
* Fix typo in Crowdsale function comment
* Fix typo in IncreasingPriceCrowdsale function comment
* Fix grammar in IncreasingPriceCrowdsale test name
* Fix typo in AllowanceCrowdsale test name
* Fix typo in RefundEscrow function comment
* Fix typo in ERC20Migrator contract comment
* Fix typos in SignatureBouncer comments
* Fix typo in SignedSafeMath test name
* Fix typo in TokenVesting contract comment
* Move Ownable comment from @notice section to @dev
The Ownable contract has a comment explaining that renouncing
ownership will prevent execution of functions with the onlyOwner
modifier.
This commit moves that comment to the @dev section and replaces it
with a description suitable for a generic user.
* Clarify purpose of ERC20 transfer function
* Clarify registration of ERC721Enumerable interface
* Clarify purpose of AllowanceCrowdsale test
* Increase specificity of inheritance comments
FinalizableCrowdsale and RefundableCrowsale both have comments
indicating that they are extensions of the Crowdsale contract.
This commit refines those comments to the most immediate ancestor
( TimedCrowdsale and RefundableCrowdsale respectively )
* Remove unused parameter in PaymentSplitter test
* Rename parameter in SignatureBouncer functions
The SignatureBouncer contract has modifiers to validate the
message sender is authorised to perform an action. They pass
msg.sender to internal functions as the variable `account`, but
the function comments refer to the variable as `sender`
This commit changes the variable name to `sender`
* Clarify comments in SignatureBouncer functions
The SignatureBouncer has comments that use the description
`sender` to refer to the variable `account`.
This commit updates the comments for consistency.
Maintainer Note: this reverts changes in the previous commit,
which renamed the variable `account` instead.
2019-02-28 11:46:13 -03:00
3111291b4a
Merge pull request #1647 from nventuro/safeerc20-bugfix
...
Fix SafeERC20.safeApprove bug
2019-02-26 12:39:02 -03:00
14ec984cc4
Merge pull request #1646 from fulldecent/patch99
...
Use canonical EIP reference format
2019-02-25 15:27:48 -03:00
b14c9f4b68
Fix SafeERC20.safeApprove bug, improve test coverage.
2019-02-25 14:41:26 -03:00
fc17a1d9f5
Add usage docs to ERC20 Snapshot ( #1639 )
2019-02-25 10:36:16 -05:00
c44e40c293
Clarify the ERC20Snapshot contract comment ( #1638 )
2019-02-25 10:28:14 -05:00
2fc0aaabb3
Use canonical EIP reference format
2019-02-24 11:52:22 -05:00
99a07493f2
Update to preferred citation formation for ERC-721
2019-02-23 16:56:47 -05:00
328d03a7f4
Merge pull request #1637 from elopio/review/snapshot/1-minime-link
...
Add a link to the minime token
2019-02-20 16:17:56 -03:00
