NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unnecessary SLOAD. (#1715)

Browse Source
This commit is contained in:
Nicolás Venturo
2019-04-10 12:29:58 -03:00
committed by GitHub
parent b353f7e18c
commit 1ebeef7ffd
2 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
contracts/access/Roles.sol
View File

@ -13,7 +13,6 @@ library Roles {
* @dev Give an account access to this role.
*/
function add(Role storage role, address account) internal {
require(account != address(0));
require(!has(role, account));
role.bearer[account] = true;
@ -23,7 +22,6 @@ library Roles {
* @dev Remove an account's access to this role.
*/
function remove(Role storage role, address account) internal {
require(account != address(0));
require(has(role, account));
role.bearer[account] = false;

6
test/access/Roles.test.js
View File

@ -8,7 +8,7 @@ contract('Roles', function ([_, authorized, otherAuthorized, anyone]) {
this.roles = await RolesMock.new();
});
it('reverts when querying roles for the null account', async function () {
it('reverts when querying roles for the zero account', async function () {
await shouldFail.reverting(this.roles.has(ZERO_ADDRESS));
});
@ -31,7 +31,7 @@ contract('Roles', function ([_, authorized, otherAuthorized, anyone]) {
await shouldFail.reverting(this.roles.add(authorized));
});
it('reverts when adding roles to the null account', async function () {
it('reverts when adding roles to the zero account', async function () {
await shouldFail.reverting(this.roles.add(ZERO_ADDRESS));
});
});
@ -54,7 +54,7 @@ contract('Roles', function ([_, authorized, otherAuthorized, anyone]) {
await shouldFail.reverting(this.roles.remove(anyone));
});
it('reverts when removing roles from the null account', async function () {
it('reverts when removing roles from the zero account', async function () {
await shouldFail.reverting(this.roles.remove(ZERO_ADDRESS));
});
});