NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

removed unnecessary require and renaming of null to zero (#1717)

Browse Source 
* removed unnecessary require

* build pipeline fix

* kept as it is

* Added require
This commit is contained in:
Prince Sinha
2019-04-16 00:33:44 +05:30
committed by Nicolás Venturo
parent bbe0eefd9f
commit 963f1eb35b
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
test/token/ERC20/ERC20.test.js
View File

@ -323,11 +323,11 @@ contract('ERC20', function ([_, initialHolder, recipient, anotherAccount]) {
describe('_mint', function () {
const amount = new BN(50);
it('rejects a null account', async function () {
it('rejects a zero account', async function () {
await shouldFail.reverting(this.token.mint(ZERO_ADDRESS, amount));
});
describe('for a non null account', function () {
describe('for a non zero account', function () {
beforeEach('minting', async function () {
const { logs } = await this.token.mint(recipient, amount);
this.logs = logs;
@ -354,11 +354,11 @@ contract('ERC20', function ([_, initialHolder, recipient, anotherAccount]) {
});
describe('_burn', function () {
it('rejects a null account', async function () {
it('rejects a zero account', async function () {
await shouldFail.reverting(this.token.burn(ZERO_ADDRESS, new BN(1)));
});
describe('for a non null account', function () {
describe('for a non zero account', function () {
it('rejects burning more than balance', async function () {
await shouldFail.reverting(this.token.burn(initialHolder, initialSupply.addn(1)));
});
@ -405,11 +405,11 @@ contract('ERC20', function ([_, initialHolder, recipient, anotherAccount]) {
await this.token.approve(spender, allowance, { from: initialHolder });
});
it('rejects a null account', async function () {
it('rejects a zero account', async function () {
await shouldFail.reverting(this.token.burnFrom(ZERO_ADDRESS, new BN(1)));
});
describe('for a non null account', function () {
describe('for a non zero account', function () {
it('rejects burning more than allowance', async function () {
await shouldFail.reverting(this.token.burnFrom(initialHolder, allowance.addn(1)));
});

2
test/token/ERC721/ERC721.test.js
View File

@ -15,7 +15,7 @@ contract('ERC721', function ([_, creator, tokenOwner, other, ...accounts]) {
const tokenId = new BN('5042');
describe('_mint(address, uint256)', function () {
it('reverts with a null destination address', async function () {
it('reverts with a zero destination address', async function () {
await shouldFail.reverting(this.token.mint(ZERO_ADDRESS, tokenId));
});