* Error handling in ERC20 and ERC721 * Added message string for require. * Fixed solhint errors. * Updated PR as per issue #1709 * changes as per #1709 and openzeppelin forum. * Changes in require statement * Changes in require statement * build pipeline fix * Changes as per @nventuro's comment. * Update revert reason strings. * Fianal update of revert reason strings. * WIP: Updating reason strings in test cases * WIP: Added changes to ERC20 and ERC721 * Fixes linting errors in *.tes.js files * Achieved 100% code coverage * Updated the test cases with shouldFail.reverting.withMessage() * Fix package-lock. * address review comments * fix linter issues * fix remaining revert reasons
52 lines
1.8 KiB
JavaScript
52 lines
1.8 KiB
JavaScript
const { constants, expectEvent, shouldFail } = require('openzeppelin-test-helpers');
|
|
const { ZERO_ADDRESS } = constants;
|
|
|
|
function shouldBehaveLikeOwnable (owner, [other]) {
|
|
describe('as an ownable', function () {
|
|
it('should have an owner', async function () {
|
|
(await this.ownable.owner()).should.equal(owner);
|
|
});
|
|
|
|
it('changes owner after transfer', async function () {
|
|
(await this.ownable.isOwner({ from: other })).should.be.equal(false);
|
|
const { logs } = await this.ownable.transferOwnership(other, { from: owner });
|
|
expectEvent.inLogs(logs, 'OwnershipTransferred');
|
|
|
|
(await this.ownable.owner()).should.equal(other);
|
|
(await this.ownable.isOwner({ from: other })).should.be.equal(true);
|
|
});
|
|
|
|
it('should prevent non-owners from transferring', async function () {
|
|
await shouldFail.reverting.withMessage(
|
|
this.ownable.transferOwnership(other, { from: other }),
|
|
'Ownable: caller is not the owner'
|
|
);
|
|
});
|
|
|
|
it('should guard ownership against stuck state', async function () {
|
|
await shouldFail.reverting.withMessage(
|
|
this.ownable.transferOwnership(ZERO_ADDRESS, { from: owner }),
|
|
'Ownable: new owner is the zero address'
|
|
);
|
|
});
|
|
|
|
it('loses owner after renouncement', async function () {
|
|
const { logs } = await this.ownable.renounceOwnership({ from: owner });
|
|
expectEvent.inLogs(logs, 'OwnershipTransferred');
|
|
|
|
(await this.ownable.owner()).should.equal(ZERO_ADDRESS);
|
|
});
|
|
|
|
it('should prevent non-owners from renouncement', async function () {
|
|
await shouldFail.reverting.withMessage(
|
|
this.ownable.renounceOwnership({ from: other }),
|
|
'Ownable: caller is not the owner'
|
|
);
|
|
});
|
|
});
|
|
}
|
|
|
|
module.exports = {
|
|
shouldBehaveLikeOwnable,
|
|
};
|