* Error handling in ERC20 and ERC721 * Added message string for require. * Fixed solhint errors. * Updated PR as per issue #1709 * changes as per #1709 and openzeppelin forum. * Changes in require statement * Changes in require statement * build pipeline fix * Changes as per @nventuro's comment. * Update revert reason strings. * Fianal update of revert reason strings. * WIP: Updating reason strings in test cases * WIP: Added changes to ERC20 and ERC721 * Fixes linting errors in *.tes.js files * Achieved 100% code coverage * Updated the test cases with shouldFail.reverting.withMessage() * Fix package-lock. * address review comments * fix linter issues * fix remaining revert reasons
93 lines
3.5 KiB
JavaScript
93 lines
3.5 KiB
JavaScript
const { balance, ether, expectEvent, shouldFail } = require('openzeppelin-test-helpers');
|
|
|
|
function shouldBehaveLikeEscrow (primary, [payee1, payee2]) {
|
|
const amount = ether('42');
|
|
|
|
describe('as an escrow', function () {
|
|
describe('deposits', function () {
|
|
it('can accept a single deposit', async function () {
|
|
await this.escrow.deposit(payee1, { from: primary, value: amount });
|
|
|
|
(await balance.current(this.escrow.address)).should.be.bignumber.equal(amount);
|
|
|
|
(await this.escrow.depositsOf(payee1)).should.be.bignumber.equal(amount);
|
|
});
|
|
|
|
it('can accept an empty deposit', async function () {
|
|
await this.escrow.deposit(payee1, { from: primary, value: 0 });
|
|
});
|
|
|
|
it('only the primary account can deposit', async function () {
|
|
await shouldFail.reverting.withMessage(this.escrow.deposit(payee1, { from: payee2 }),
|
|
'Secondary: caller is not the primary account'
|
|
);
|
|
});
|
|
|
|
it('emits a deposited event', async function () {
|
|
const { logs } = await this.escrow.deposit(payee1, { from: primary, value: amount });
|
|
expectEvent.inLogs(logs, 'Deposited', {
|
|
payee: payee1,
|
|
weiAmount: amount,
|
|
});
|
|
});
|
|
|
|
it('can add multiple deposits on a single account', async function () {
|
|
await this.escrow.deposit(payee1, { from: primary, value: amount });
|
|
await this.escrow.deposit(payee1, { from: primary, value: amount.muln(2) });
|
|
|
|
(await balance.current(this.escrow.address)).should.be.bignumber.equal(amount.muln(3));
|
|
|
|
(await this.escrow.depositsOf(payee1)).should.be.bignumber.equal(amount.muln(3));
|
|
});
|
|
|
|
it('can track deposits to multiple accounts', async function () {
|
|
await this.escrow.deposit(payee1, { from: primary, value: amount });
|
|
await this.escrow.deposit(payee2, { from: primary, value: amount.muln(2) });
|
|
|
|
(await balance.current(this.escrow.address)).should.be.bignumber.equal(amount.muln(3));
|
|
|
|
(await this.escrow.depositsOf(payee1)).should.be.bignumber.equal(amount);
|
|
|
|
(await this.escrow.depositsOf(payee2)).should.be.bignumber.equal(amount.muln(2));
|
|
});
|
|
});
|
|
|
|
describe('withdrawals', async function () {
|
|
it('can withdraw payments', async function () {
|
|
const balanceTracker = await balance.tracker(payee1);
|
|
|
|
await this.escrow.deposit(payee1, { from: primary, value: amount });
|
|
await this.escrow.withdraw(payee1, { from: primary });
|
|
|
|
(await balanceTracker.delta()).should.be.bignumber.equal(amount);
|
|
|
|
(await balance.current(this.escrow.address)).should.be.bignumber.equal('0');
|
|
(await this.escrow.depositsOf(payee1)).should.be.bignumber.equal('0');
|
|
});
|
|
|
|
it('can do an empty withdrawal', async function () {
|
|
await this.escrow.withdraw(payee1, { from: primary });
|
|
});
|
|
|
|
it('only the primary account can withdraw', async function () {
|
|
await shouldFail.reverting.withMessage(this.escrow.withdraw(payee1, { from: payee1 }),
|
|
'Secondary: caller is not the primary account'
|
|
);
|
|
});
|
|
|
|
it('emits a withdrawn event', async function () {
|
|
await this.escrow.deposit(payee1, { from: primary, value: amount });
|
|
const { logs } = await this.escrow.withdraw(payee1, { from: primary });
|
|
expectEvent.inLogs(logs, 'Withdrawn', {
|
|
payee: payee1,
|
|
weiAmount: amount,
|
|
});
|
|
});
|
|
});
|
|
});
|
|
}
|
|
|
|
module.exports = {
|
|
shouldBehaveLikeEscrow,
|
|
};
|