* Add IntelliJ IDE config to .gitignore * Fix variable name in ERC20 function comments * Fix typos in Arrays function comment * Fix typos in ownership test names * Fix typo in Pausable test name * Fix grammar in Ownable function comment * Fix grammar in Crowdsale contract comment * Fix typo in Counters contract comment * Fix typo in ERC721Enumerable comment * Fix typo in ERC721PausedToken test name * Fix typo in Crowdsale function comment * Fix typo in IncreasingPriceCrowdsale function comment * Fix grammar in IncreasingPriceCrowdsale test name * Fix typo in AllowanceCrowdsale test name * Fix typo in RefundEscrow function comment * Fix typo in ERC20Migrator contract comment * Fix typos in SignatureBouncer comments * Fix typo in SignedSafeMath test name * Fix typo in TokenVesting contract comment * Move Ownable comment from @notice section to @dev The Ownable contract has a comment explaining that renouncing ownership will prevent execution of functions with the onlyOwner modifier. This commit moves that comment to the @dev section and replaces it with a description suitable for a generic user. * Clarify purpose of ERC20 transfer function * Clarify registration of ERC721Enumerable interface * Clarify purpose of AllowanceCrowdsale test * Increase specificity of inheritance comments FinalizableCrowdsale and RefundableCrowsale both have comments indicating that they are extensions of the Crowdsale contract. This commit refines those comments to the most immediate ancestor ( TimedCrowdsale and RefundableCrowdsale respectively ) * Remove unused parameter in PaymentSplitter test * Rename parameter in SignatureBouncer functions The SignatureBouncer contract has modifiers to validate the message sender is authorised to perform an action. They pass msg.sender to internal functions as the variable `account`, but the function comments refer to the variable as `sender` This commit changes the variable name to `sender` * Clarify comments in SignatureBouncer functions The SignatureBouncer has comments that use the description `sender` to refer to the variable `account`. This commit updates the comments for consistency. Maintainer Note: this reverts changes in the previous commit, which renamed the variable `account` instead.
43 lines
1.6 KiB
JavaScript
43 lines
1.6 KiB
JavaScript
const { constants, expectEvent, shouldFail } = require('openzeppelin-test-helpers');
|
|
const { ZERO_ADDRESS } = constants;
|
|
|
|
function shouldBehaveLikeOwnable (owner, [anyone]) {
|
|
describe('as an ownable', function () {
|
|
it('should have an owner', async function () {
|
|
(await this.ownable.owner()).should.equal(owner);
|
|
});
|
|
|
|
it('changes owner after transfer', async function () {
|
|
(await this.ownable.isOwner({ from: anyone })).should.be.equal(false);
|
|
const { logs } = await this.ownable.transferOwnership(anyone, { from: owner });
|
|
expectEvent.inLogs(logs, 'OwnershipTransferred');
|
|
|
|
(await this.ownable.owner()).should.equal(anyone);
|
|
(await this.ownable.isOwner({ from: anyone })).should.be.equal(true);
|
|
});
|
|
|
|
it('should prevent non-owners from transferring', async function () {
|
|
await shouldFail.reverting(this.ownable.transferOwnership(anyone, { from: anyone }));
|
|
});
|
|
|
|
it('should guard ownership against stuck state', async function () {
|
|
await shouldFail.reverting(this.ownable.transferOwnership(ZERO_ADDRESS, { from: owner }));
|
|
});
|
|
|
|
it('loses owner after renouncement', async function () {
|
|
const { logs } = await this.ownable.renounceOwnership({ from: owner });
|
|
expectEvent.inLogs(logs, 'OwnershipTransferred');
|
|
|
|
(await this.ownable.owner()).should.equal(ZERO_ADDRESS);
|
|
});
|
|
|
|
it('should prevent non-owners from renouncement', async function () {
|
|
await shouldFail.reverting(this.ownable.renounceOwnership({ from: anyone }));
|
|
});
|
|
});
|
|
}
|
|
|
|
module.exports = {
|
|
shouldBehaveLikeOwnable,
|
|
};
|