f0e12d5301
ether and shouldFail tests ( #1513 )
...
* Added ether tests.
* Added shouldFail base function and tests.
* Updated test descriptions.
* Reduced gas limit on out-of-gas tests.
2018-11-27 17:20:21 -03:00
5471fc808a
Updated code style to 4 space indentation and 120 characters per line. ( #1508 )
...
* Updated code style to 4 spaces and 120 max characters per line.
* Update contracts/token/ERC721/ERC721Pausable.sol
Co-Authored-By: nventuro <nicolas.venturo@gmail.com >
* Update contracts/token/ERC721/IERC721.sol
Co-Authored-By: nventuro <nicolas.venturo@gmail.com >
2018-11-22 16:53:30 -03:00
bb6a24e6aa
Renamed roles private variables to adhere to code style. ( #1507 )
2018-11-20 16:03:22 -03:00
83bc045a56
Remove extraneous quantity check, fixes #1454 ( #1455 )
2018-11-02 07:16:35 -03:00
6363a776f7
Remove redundant require statements ( #1409 )
...
* Remove redundant require statements
Now that SafeMath uses require, the require statements are redundant. They were also previously inconsistent because they were only included in some functions, but not others
* Update ERC20.sol
2018-11-02 07:14:06 -03:00
32bc7a6fe5
add an address typecast to this per issue #1457 ( #1471 )
2018-11-02 06:56:50 -03:00
1186520617
add improvement in simpletoken example #1458 ( #1473 )
...
* add improvement in simpletoken example #1458
* fix not calling decimals get function in initial supply
2018-11-01 16:16:21 -03:00
4f356e35a9
The beneficiary parameter of claimRefund is replaced with refundee ( #1481 )
...
* signing prefix added
* Minor improvement
* Tests changed
* Successfully tested
* Minor improvements
* Minor improvements
* Revert "Dangling commas are now required. (#1359 )"
This reverts commit a6889776f4fixes #1404
* approve failing test
* suggested changes done
* ISafeERC20 removed
* conflict fixes
* fixes #1456
2018-11-01 15:38:54 -03:00
79eb94d3cd
fix ERC20.sol#L174 and ERC20.sol#L187 should be casted to an address type. ( #1470 )
2018-11-01 15:27:51 -03:00
18552a8d5f
Fix/add comment erc721 burnable #1464 ( #1469 )
...
* fix Add a comment to ERC721Enumerable #1465
* fix Add comments to ERC721Burnable #1464
2018-11-01 15:15:04 -03:00
80458ebc72
Add warning about trading tokens before refundable crowdsale goal is met ( #1452 )
...
This attack was reported in https://github.com/OpenZeppelin/openzeppelin-solidity/issues/877
2018-10-19 17:35:04 -06:00
6d415c508b
Crowdsale.buyTokens is now nonReentrant. ( #1438 )
2018-10-19 14:42:20 -06:00
a936cbf5fb
InitialRate must be strictly larger than finalRate. ( #1441 )
2018-10-19 12:37:24 -06:00
1ac1ac984e
Fixed how allowance crowdsale checks remaining tokens. ( #1449 )
2018-10-19 12:12:16 -06:00
8204f6a71f
Improved some ERC721 internal shenanigans ( #1450 )
...
* Made _clearApproval private, added clarifying comments in _addTokenTo and _removeTokenFrom.
* Added approval information.
2018-10-18 19:07:34 -03:00
bbe804a14b
Deleted unnecessary import. ( #1437 )
...
* Deleted unnecessary import.
* Added back SafeMath.
* Removed another unnecessary import.
2018-10-18 18:43:44 -03:00
28cf567e41
Made SampleCrowdsale a bit clearer. ( #1448 )
2018-10-18 18:43:12 -03:00
5bb865218f
Now setting the finalized flag before doing finalization to prevent possbile reentrancy issues. ( #1447 )
2018-10-18 18:42:57 -03:00
94692acb14
Crowdsale docs improvements. ( #1446 )
...
* Added a small Crowdsale fallback gas warning.
* Fixed a couple typos.
2018-10-18 16:57:16 -03:00
384dff9abe
Renamed internal ERC721 check function. ( #1445 )
2018-10-18 16:56:58 -03:00
5bf3907862
Made tokenURI external, as per the spec. ( #1444 )
2018-10-18 16:49:46 -03:00
c8220aeea8
ERC20Capped now capps _all_ minting, even internal calls. ( #1443 )
2018-10-18 16:49:31 -03:00
9155bfe27f
IncPriceCrowdsale consistently returns 0 outside of the crowdsale window. ( #1442 )
2018-10-18 16:36:27 -03:00
1c5f16ae26
Closing time must be strictly after opening time. ( #1440 )
2018-10-18 16:36:11 -03:00
d9fdffe88e
Internal crowdsales ( #1439 )
...
* Made some internal crowdsale methods internal.
* Made all Crowdsale constructors internal.
2018-10-18 16:35:57 -03:00
315f426f5c
Improved SafeERC20 allowance handling ( #1407 )
...
* signing prefix added
* Minor improvement
* Tests changed
* Successfully tested
* Minor improvements
* Minor improvements
* Revert "Dangling commas are now required. (#1359 )"
This reverts commit a6889776f4fixes #1404
* approve failing test
* suggested changes done
* ISafeERC20 removed
* allowance methods in library
* Improved SafeERC20 tests.
* Fixed test coverage.
2018-10-18 12:25:03 -03:00
67dac7ae99
TokenVesting improvements ( #1431 )
...
* Improved TokenVesting events.
* Added extra checks to TokenVesting.
* Renamed the events.
* Fixed linter error.
* Fixed a test that failed to cover a require.
* Renamed TokensRevoked to TokenVestingRevoked.
2018-10-18 11:27:46 -03:00
a07499796a
SplitPayment improvements ( #1417 )
...
* Renamed file, added events and set _addPayee to private
* unwanted file
* adjusted test
* adjusted test
* PaymentReceived event added
* Added event testing.
* Fix static tests
2018-10-18 11:26:54 -03:00
fcab9c89f2
Added address of pauser/unpauser in events ( #1410 )
...
* Added address of pauser/unpauser in events
* Added the account to the Pausable tests.
2018-10-18 11:26:39 -03:00
cbe414864f
Events added to Secondary ( #1425 )
...
* Update contracts/ownership/Secondary.sol
* Update Secondary.sol
* Update Secondary.test.js
* Update Secondary.test.js
* Update Secondary.sol
2018-10-18 11:00:33 -03:00
0231fac514
Added leading underscore to internal functions, renamed supportsInterfaces. ( #1435 )
2018-10-18 10:49:01 -03:00
ff0c048ad9
Added replay attack notice to SignatureBouncer. ( #1434 )
2018-10-18 10:47:55 -03:00
96d6103e0b
Made some inherit-only contracts internal. ( #1433 )
...
* Made some inherit-only contracts internal.
* Added OwnableMock.
2018-10-18 10:47:35 -03:00
df3c113711
Made some TokenVesting public functions private. ( #1427 )
...
* Made some TokenVesting public functions private.
* Fixed linter error.
2018-10-17 18:18:41 -03:00
f3df2dab3d
Moved Escrows into an escrow subdirectory, improved docs. ( #1430 )
...
* Moved Escrows into an escrow subdirectory, improved docs.
* Fixed escrow mock.
* Fixed some more imports.
2018-10-17 17:22:25 -03:00
cfef58361f
Removed default value assignments. ( #1432 )
2018-10-17 17:00:12 -03:00
2733cb4a41
Now using hex for asm memory addresses. ( #1429 )
2018-10-17 16:58:36 -03:00
03765e08b9
Make state variables private ( #1426 )
...
* added function to renounce ownership
* Make state variables private (#1411 )
2018-10-17 11:35:31 -03:00
9be0f100c4
Removed BreakInvariantBounty. ( #1424 )
2018-10-16 17:21:24 -03:00
a3e312d133
Added Math.sol docstrings. ( #1423 )
2018-10-16 17:21:08 -03:00
3341dd8899
Fixed a typo in a comment. ( #1422 )
2018-10-16 17:20:55 -03:00
3bd30f7382
Roles.add and remove now require pre-conditions on the account. ( #1421 )
2018-10-16 17:20:33 -03:00
844a96d0b9
RefundEscrow's events renamed ( #1418 )
...
* fixes #1414
2018-10-16 10:37:04 -03:00
03dfb2965c
Improve encapsulation on ERC165 and update code style guide ( #1379 )
...
* use prefix underscore for internal state variables
* make _supportedInterfaces private
2018-10-12 19:13:35 -03:00
9f822906b8
First test helpers tests ( #1369 )
...
* Removed unused advanceToBlock.
* Added advanceBlock tests.
* Fixed advanceToBlock tests.
* Added single argument tests.
* Finished inLogs tests.
* Fixed linter errors.
* Fixed linter errors.
2018-10-10 20:55:10 -03:00
eb92fd1f48
Fix typo in ARCHITECTURE.md ( #1406 )
2018-10-10 15:15:38 -03:00
da67e435b1
Non-constructor initialization removed ( #1403 )
...
* signing prefix added
* Minor improvement
* Tests changed
* Successfully tested
* Minor improvements
* Minor improvements
* Revert "Dangling commas are now required. (#1359 )"
This reverts commit a6889776f4fixes #1391
2018-10-10 09:33:26 -03:00
af42c39e6c
Improves Ownable events ( #1397 )
...
* signing prefix added
* Minor improvement
* Tests changed
* Successfully tested
* Minor improvements
* Minor improvements
* Revert "Dangling commas are now required. (#1359 )"
This reverts commit a6889776f4fixes #1392
* event tests added
* constructor event added
2018-10-09 13:32:45 -03:00
3acc2b4216
Added a constructor to BreakInvariantBounty. ( #1395 )
2018-10-08 17:01:35 -06:00
f7e53d90fa
Add Arrays library with unit tests ( #1209 ) ( #1375 )
...
* Add Arrays library with unit tests (#1209 )
* prepared due to snapshot token requirements
* add library with method to find upper bound
* add unit test for basic and edge cases
* Imporove documentation for Arrays library
Simplify Arrays.test.js to use short arrays as test date
* Added comment for uint256 mid variable.
* Explaned why uint256 mid variable calculated as Math.average is safe to use as index of array.
2018-10-08 11:01:33 -03:00
