66c1968913
Changed SplitPayment require to assert. ( #1188 )
2018-08-12 15:34:37 -03:00
a2e7103869
Improved SafeMath inline comments.
2018-08-10 17:34:34 -03:00
c9e91586e7
feat: use require in SafeMath ( #1187 )
...
* feat: use require in SafeMath
* fix: grammar with revert
2018-08-10 15:41:06 -03:00
e819416d04
SafeMath is now more consistent with itself. ( #1168 )
2018-08-08 11:21:23 -03:00
17309e5924
Change uint to uint256 ( #1160 )
...
This is a minor change, aligning to the same convention used in the other contracts.
2018-08-07 15:05:56 -03:00
94797978bb
SplitPayment now requires payees. ( #1131 )
...
* SplitPayment now requires payees.
* Improved test phrasing.
2018-08-06 16:21:34 -03:00
31ac59b224
reentrancy mutex gas optimization ( #1155 )
...
* reentrancy mutex gas optimization
* 1) uint => uint256 2) ++ to += 1
2018-08-06 15:22:08 -03:00
bf34911857
Remove Math.min64 and Math.max64 ( #1156 )
...
* remove Math.min64 and Math.max64
* refactor Math tests to use return values
* enhance Math coverage
2018-08-06 15:18:19 -03:00
ef347ffccc
Consolidated ERC20 Interface and Implementation Files ( #1125 )
...
* Consolidted ERC20 Interface and Implementation Files
* Fixed CanReclaimToken's tests to use StandardTokenMock instead of BasicTokenMock
* Changed token's variable type in TokenTimelock to ERC20
* Merged the StandardBurnableToken with BurnableToken since it now inherits from StandardToken; Fixed TokenTimelock so it uses SafeERC20 for ERC20
* Fixed variable type for _token in TokenTimelock constructor
* Fixed linting warning in BurnableToken
* Added back burnFrom tests.
2018-08-02 23:12:31 -03:00
3d86c58d2c
Crowdsale inheritance order ( #1128 )
...
* Changed Crowdsale inheritance order.
* Changed FinalizableCrowdsale inheritance order.
2018-08-02 17:57:17 -03:00
f49721576f
Remove abbreviations from parameters ( #1142 )
...
* Add an initial document for our code style
* Remove abbreviations from parameters
* Rename the param in AddressUtils
* fix comment
2018-08-02 16:38:54 -03:00
ca9e317259
Update Truffle and Solium ( #1105 )
...
* fixed visibility warnings
* solved visibility and line length warning
* change a test assertion that fails due to chai dependence update
* linter, constructor style and solved visibility warnings
* Changed Windows line endings to Unix.
2018-08-01 10:11:37 -03:00
9638ecd87a
Typo fix.
2018-08-01 08:31:05 -03:00
56735a706c
Use address(this) instead of this ( #1134 )
...
* Use address(this) instead of this
It's preferred to use `address(this)` vs `this`
* Change to address(this) vs this
2018-07-31 13:36:38 -03:00
2765350248
Prefix all parameters with underscore ( #1133 )
2018-07-31 13:06:53 -03:00
1200969eb6
Refactor/reentrancy guard gas optimization #1056 ( #1057 )
...
* optimizing ReentrancyGuard gas usage
* style fixed
2018-07-27 22:36:17 -03:00
90b98a7bef
Add pure to tokenFallback function ( #1122 )
...
Silences warning
2018-07-27 22:25:39 -03:00
16429b1522
Making visibility explicit for storage variables ( #759 )
...
* Making visibility explicit for storage variables
* Made BasicToken's variables internal.
2018-07-27 17:50:33 -03:00
4c6575bf2f
fix: solium linting errors ( #1113 )
...
* fix: solium linting errors, fixes #1092
* fix: remove uppercase requirement
2018-07-26 23:53:24 -03:00
e6c15b34da
Remove chai-as-promised ( #1116 )
...
* Test: Remove chai-as-promised calls
* Test/Helpers: expectThrow accepts optional message
* NPM: Remove chai-as-promised
* Contracts/DestructibleMock: Fix lint
2018-07-26 11:53:33 -03:00
afe9113b18
fix: move RBAC to //access ( #1114 )
2018-07-25 12:03:25 -03:00
73be06412f
Remove payable from Destructible constructor ( #1107 )
...
* Destructible no longer has a payable constructor.
* Fixed linter errors.
2018-07-23 15:44:14 -03:00
23074676c4
Improved documentation for _preValidatePurchase method in Crowdsale ( #1101 )
...
* Improved documentation for _preValidatePurchase in Crowdsale
* Added newline at EOF
2018-07-22 14:41:34 -03:00
6bd8842ab5
removed and tested unecessary gas cost ( #1017 )
...
* removed and tested unecessary gas cost
* linted
* Revert package-lock.json update.
This reverts commit 054598ce7f
2018-07-20 16:57:39 -03:00
d20d03c149
Remove redundant modifiers from safeTransferFrom ( #1029 ) ( #1030 )
2018-07-20 16:18:24 -03:00
ebd4b5e73d
decrease approval condition fix (greater than and equal to) ( #1063 )
...
* decrease approval condition fix (greater than and equal to)
* sol lint fixed
* Improved standard token decreaseApprovalTests.
2018-07-20 14:52:22 -03:00
1ecda54449
Input check sequence modification for gas efficiency ( #1043 )
...
* Update StandardToken.sol
* Slight improvement in gas efficiency
Users tend to attempt to over-spend more than they attempt to burn non-burnable tokens. If the contract checks for overspending before assuring tokens are not being burnt a slight amount of gas might be saved in the long term.
2018-07-20 14:52:02 -03:00
67b67b791e
Changed before for beforeAll, refactored Bouncer tests. ( #1094 )
...
* Changed before for beforeAll, refactored Bouncer tests.
* Fixed linter errors.
* fix: updates for SignatureBouncer tests and voucher construction
2018-07-20 12:25:40 -03:00
ce0c3274ee
made remaining public fallback functions external ( #1080 )
2018-07-20 12:25:25 -03:00
90b3050ad7
minor RBAC.sol documentation fix ( #1060 )
2018-07-20 12:09:47 -03:00
c95ea5125d
Fix MerkleProof natspec comments ( #1083 )
2018-07-19 22:32:34 -03:00
11266b0d56
Fix ReentrancyGuard comments ( #1084 )
2018-07-19 22:10:15 -03:00
45d6943913
Fix typos ( #1082 )
2018-07-19 21:48:20 -03:00
5f6d511af9
Fix typo in Crowdsale.sol ( #1035 )
2018-07-19 21:47:53 -03:00
3318b91697
feat: add AutoIncrementing contract ( #1023 )
...
* feat: add AutoIncrementing contract
* feat: allow multiple counters per instance
* fix: some linting errors
* feat: use recommended implementaiton
* fix: remove .only in tests
* fix: PR notes
* fix: add note about incrementing counter
2018-07-18 16:38:07 -07:00
99e4b081dc
ECRecover test should revert because of wrong calldata size ( #1050 )
...
* Assume that token is mintable.
* ECRecover test should revert because of wrong calldata size
* fix: use expectThrow
* fix: ignore failing test until solc^0.5.0
2018-07-16 18:38:57 -04:00
b120b9aff7
moved ERC165 interface IDs from ERC721 implementation files to the interface file ( #1070 )
2018-07-15 11:05:45 -04:00
8fd072cf8e
Escrows ( #1014 )
...
* Added basic Escrow
* PullPayment now uses an Escrow, removing all trust from the contract
* Abstracted the Escrow tests to a behaviour
* Added ConditionalEscrow
* Added RefundableEscrow.
* RefundableCrowdsale now uses a RefundEscrow, removed RefundVault.
* Renaming after code review.
* Added log test helper.
* Now allowing empty deposits and withdrawals.
* Style fixes.
* Minor review comments.
* Add Deposited and Withdrawn events, removed Refunded
* The base Escrow is now Ownable, users of it (owners) must provide methods to access it.
2018-07-03 18:54:55 -03:00
c2ad8c3f57
Update the use of call() with selector only. ( #1033 )
2018-06-30 17:55:03 -03:00
7d8e3ca8b2
Align ERC721 Receiver with current ERC721 standard. ( #1047 )
...
* Align ERC721 Receiver with current ERC721 standard.
Adds a second address field to onERC721Received
onERC721Received(address,address,uint256,bytes)
Updates the function signature to 0x150b7a02 from 0xf0b9e5ba
* Add _operator to onERC721Received
* Fix error caused by formatOnSave
* Fixed comments on ERC721Receiver
Removed "Must use 50,000 gas or less"
Corrected the function signature
2018-06-28 20:11:18 -07:00
6b37ba36a1
Remove ERC827 token. ( #1045 )
...
Implementing this token is unsafe as per comments here:
https://github.com/ethereum/EIPs/issues/827#issuecomment-397857455
2018-06-28 13:32:07 -03:00
dc1e352cc4
Don't emit Approval event when approval is cleared on transfer ( #1039 )
2018-06-24 23:04:57 -07:00
f18c3bc438
feat: initial implementation of ERC1046 ( #933 )
...
* feat: initial implementation of ERC1046
2018-06-17 16:21:05 -07:00
74a62a1314
using SafeERC20 to implement safeTransfer in Crowdsale ( #1006 )
...
* introduced safeTransfer to Crowdsale
* Removed .node-xmlhttprequest-sync-7601
2018-06-16 12:46:19 -03:00
92b695f2fb
Fix/whitelisted crowdsale ( #981 )
...
* fix: swithc WhitelistedCrowdsale to use Whitelist.sol
* feat: refactor whitelist.sol, rbac.sol and whitelistedcrowdsale.sol
* feat: add event arg assets and update whitelist
* fix: update modifier comment and also test isWhitelisted
* fix: remove onlyWhitelisted backwards compat attempt, fix explicit inheritance
* fix: remove underscore prefix from event args
* fix: user access/Whitelist
2018-06-15 14:11:50 -07:00
ee78f67985
fixing comment - changing '_to' to '_spender' ( #1007 )
2018-06-15 12:08:28 -03:00
07020e9544
Remove redundant @dev tags ( #995 )
...
* Remove redundant @dev tags
* Remove redundant @notice tags
2018-06-14 15:19:59 -07:00
b4406d385f
Use abi.encodeWithSignature together with raw call() ( #1008 )
2018-06-14 18:50:39 -03:00
78e39aa2ad
Do not use implicit type conversion for address literals ( #1002 )
...
Uses the explicit address(0) for the zero address
2018-06-13 16:21:24 -07:00
e4ed8f0705
Added explicit integer sizes to uint variables in StandardToken ( #1004 )
2018-06-13 11:54:54 -07:00
