b982e2a808
Update ERC721.behavior.js
2023-07-14 08:38:46 +02:00
12f63b3b1b
add test
2023-07-13 17:28:04 +02:00
20048ca3b9
Changes suggested in the PR discussions
2023-07-13 11:00:11 +02:00
365aca6d60
Improve tests for ERC1155 and ERC721 error handling ( #3781 )
...
Co-authored-by: Francisco <fg@frang.io >
2023-06-20 03:20:02 +00:00
b425a72240
Replace revert strings with custom errors ( #4261 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com >
Co-authored-by: Francisco <fg@frang.io >
2023-06-12 23:41:52 +00:00
94cd8ef12e
Add ERC721 Wrapper ( #3863 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com >
2023-02-09 13:43:34 -06:00
a28aafdc85
Use Prettier for JS files ( #3913 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com >
2023-01-04 15:03:40 +01:00
c1d9da4052
Use hardhat-exposed to reduce the need for mocks ( #3666 )
...
Co-authored-by: Francisco <fg@frang.io >
2023-01-03 14:38:13 +00:00
2336bd3e8e
Simplify ESLint config ( #3903 )
2022-12-29 17:08:12 -03:00
fbf235661e
Improve grammar in transfer error messages ( #3542 )
2022-07-25 17:01:14 -03:00
96163c87e3
Implicitly clear ERC721 approval on burn ( #3538 )
2022-07-09 10:25:45 +02:00
e02c378745
Implicitly clear ERC721 approval on transfers ( #3481 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com >
Co-authored-by: Francisco Giordano <frangio.1@gmail.com >
2022-07-04 15:29:15 -03:00
62f2c0531b
Simplify ERC721 revert reasons ( #3438 )
2022-06-01 18:22:13 -03:00
82a63f6389
Remove redundant require in ERC721 ( #3434 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com >
2022-05-26 22:22:35 -03:00
488dd562fb
Improve error messages for ERC721 and 1155 ( #3254 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com >
2022-05-27 00:52:43 +00:00
d4e6236b2b
Fix deprecated expectEvent.inLogs #3332 ( #3333 )
2022-04-23 10:20:55 -03:00
742e85be7c
Change zero address revert message in the balanceOf function of ERC721 and ERC1155 ( #3314 )
2022-04-02 12:13:33 +02:00
0c858e2071
Improve revert reason in ERC721 ( #2975 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com >
2021-12-09 23:42:18 +00:00
d89f2a4ac6
Update ERC721.behavior.js ( #2801 )
2021-08-05 19:44:13 +02:00
f782943099
Move variable declaration to top of test file ( #2806 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com >
2021-08-03 14:19:21 +00:00
e1c0f3eaef
Update tests for RFC 2606 ( #2802 )
2021-08-02 23:41:13 +00:00
24a0bc23cf
Reorganize the repo structure ( #2503 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com >
2021-02-22 16:44:16 +00:00
09734e8028
Remove enumerable from ERC721 and add an ERC721Enumerable extension ( #2511 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com >
2021-02-19 13:24:39 -03:00
24c37c1f9e
Bundle ERC721 extensions into base contract ( #2149 )
...
* Add IERC721Metadata implementation into ERC721
* Add IERC721Enumerable into ERC721
* Update ERC721Pausable and ERC721Burnable
* Delete ERC721Metadata, ERC721Enumerable and ERC721 (now ERC721)
* Update mocks
* Update tests
* Update contracts/token/ERC721/ERC721.sol
Co-Authored-By: Francisco Giordano <frangio.1@gmail.com >
* Make ERC721Pausable and ERC721Burnable abstract
Co-authored-by: Francisco Giordano <frangio.1@gmail.com >
2020-03-27 17:27:41 -03:00
5dfe7215a9
Migrate Contracts to Solidity v0.6 ( #2080 )
...
* Initial migration to Solidity 0.6.x - v3.0 first steps (#2063 )
* Initial migration, missing GSN, 721, 777 and Crowdsales.
* Add _beforeTokenOperation and _afterTokenOperation.
* Add documentation for hooks.
* Add hooks doc
* Add missing drafts
* Add back ERC721 with hooks
* Bring back ERC777
* Notes on hooks
* Bring back GSN
* Make functions virtual
* Make GSN overrides explicit
* Fix ERC20Pausable tests
* Remove virtual from some view functions
* Update linter
* Delete examples
* Remove unnecessary virtual
* Remove roles from Pausable
* Remove roles
* Remove users of roles
* Adapt ERC20 tests
* Fix ERC721 tests
* Add all ERC721 hooks
* Add ERC777 hooks
* Fix remaining tests
* Bump compiler version
* Move 721BurnableMock into mocks directory
* Remove _before hooks
* Fix tests
* Upgrade linter
* Put modifiers last
* Remove _beforeTokenApproval and _beforeOperatorApproval hooks
2020-02-14 11:12:32 -03:00
7d7cbcad14
Fix/improve revert reason #1727 ( #2018 )
...
* adding mock contacts, test code
* adding changes to ERC721.sol per @frangio's comments on original PR #1943
* fix solhint warnings
* Update contracts/token/ERC721/ERC721.sol
Co-Authored-By: Francisco Giordano <frangio.1@gmail.com >
* same revert wording per @frangio's review suggestion
* per @frangio's feedback, changing the inline assembly to accomplish: we want to ignore the first 4 bytes of content, so we should read the length and decrease it by 4, then take the memory location and add 4 to it, then store the new length at the new memory location, then that is the new byte array that we want.
* change revert msg assembly per PR comment by @frangio
* unify revert msg in test code
* fix some failed tests, wording change
* Update contracts/token/ERC721/ERC721.sol
Co-Authored-By: Francisco Giordano <frangio.1@gmail.com >
* Update contracts/token/ERC721/ERC721.sol
Co-Authored-By: Francisco Giordano <frangio.1@gmail.com >
* fix test case, revert without reason
* fix 'ERC721ReceiverRevertsMock: Transaction rejected by receiver'
* style change per review by @frangio
* fix revert reason forwarding
* remove duplicate contracts/mocks/ERC721ReceiverRevertsMock.sol per review https://github.com/OpenZeppelin/openzeppelin-contracts/pull/2018\#issuecomment-574381034
* Add changelog entry
* Fix tests
* Make tests more clear
Co-authored-by: Francisco Giordano <frangio.1@gmail.com >
Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com >
2020-01-23 16:33:09 -03:00
5f92adc2e7
Migrate from truffle to test-environment ( #2007 )
...
* Sketch
* Migrate all tests to test-env
* Finish migration to test-env
* Add config
* Work on GSN tests
* Migrate to newer test-env version and loader syntax
* Add GSN setup
* Finish test-env migration
* Setup coverage using test-env
* Migrate to npm package
* Fix package.json
* Add compile step to CI
* Add comment on coverage setup
* Remove dependency on @truffle/contract
* Fix package-lock merge
* Fix linter errors
* Upgrade test-environment, depend locally on ganche-coverage
* Improve coverage script
* Improve sign.js API
* Move accounts destructuring to describe block
* Switch to prebuilt ethereumjs-vm package
* Upgrade test-enviroment version
* use workspace in circleci config
* remove unnecessary npx
2019-11-28 15:46:42 -03:00
3274d9db00
Upgrade to @openzeppelin/test-helpers@0.5.1 ( #1942 )
2019-10-10 19:38:23 -03:00
635a381460
Fix Part 1 : added tests for getApproved ( #1820 )
...
* added tests for getApproved
* added tests for getApproved
* added to changelog
* Corrected some linting issues
* Removed unneccrary tests as pointed out here: b49c2de086 (r307927816)
2019-08-26 20:59:22 -03:00
377431bc4c
Fix/add erc721 safe mint safe transfer from #1736 ( #1816 )
...
* added _safeTransferFrom function
* added safeMint functions
* added package-lock.json for consistency, don't know why it changes
* added initial suggestions/modifications
* change _safeTransferFrom to internal, reverted package-lock.json to original, and changed ERC721Pausable to override _transferFrom instead of transferFrom
* included tests for safeMint functions
* modified safeMint tests to be on ERC721Mock contract
* added safeMint to ERC721Mintable & respective test to ERC721MintBurn.behavior.js
2019-07-29 12:16:55 -03:00
489d2e85f1
Replace chai.should with chai.expect ( #1780 )
...
* changed exxpect to expect wherever applicable
* Merged with latest branch
* Updated merkleTree helper to latest master branch
* Made linting fixes
* Fix for test build
* updated for Coverage
* Updated Address.test.js
* Undo package-lock changes.
2019-06-24 17:40:05 -03:00
a71c3bce32
Update test-helpers to v0.4.0. ( #1770 )
2019-05-24 13:36:15 -03:00
2f8e844514
Fix remaining revert reasons.
2019-04-24 11:25:09 -03:00
3682c6575c
Added message string for require() ( #1704 )
...
* Error handling in ERC20 and ERC721
* Added message string for require.
* Fixed solhint errors.
* Updated PR as per issue #1709
* changes as per #1709 and openzeppelin forum.
* Changes in require statement
* Changes in require statement
* build pipeline fix
* Changes as per @nventuro's comment.
* Update revert reason strings.
* Fianal update of revert reason strings.
* WIP: Updating reason strings in test cases
* WIP: Added changes to ERC20 and ERC721
* Fixes linting errors in *.tes.js files
* Achieved 100% code coverage
* Updated the test cases with shouldFail.reverting.withMessage()
* Fix package-lock.
* address review comments
* fix linter issues
* fix remaining revert reasons
2019-04-24 11:17:08 -03:00
19c705d928
Fix/rename anyone account #1357 ( #1718 )
...
* replacing all instances of from: anyone with from: other
* replacing all instances of from: anyone with from: other
* replacing all instances of from: anyone with from: other
* changing anyone to other
* changing anyone to other
2019-04-11 12:34:10 -03:00
3e82db2f6f
Migration to truffle 5 (and web3 1.0 (and BN)) ( #1601 )
...
* Now compiling using truffle 5.
* Migrated some test files, missing BN scientific notation usage.
* Now using BN time values.
* Migrate ERC20 tests.
* Migrate all ERC20 tests.
* Migrate utils, payment and ownership tests.
* All tests save ERC721 migrated.
* Migrated ERC721 tests.
* Fix lint errors.
* Delete old test helpers.
* Fix remaining crowdsale tests.
* Fix signature bouncer tests.
* Update how constants is used.
* Compile script pre-removes the build dir.
* Fix SafeMath tests.
* Revert "Compile script pre-removes the build dir."
This reverts commit 247e745113
2019-01-14 19:11:55 -03:00
70fd243e3b
Test setup helper added ( #1482 )
...
* signing prefix added
* Minor improvement
* Tests changed
* Successfully tested
* Minor improvements
* Minor improvements
* Revert "Dangling commas are now required. (#1359 )"
This reverts commit a6889776f4fixes #1404
* approve failing test
* suggested changes done
* ISafeERC20 removed
* conflict fixes
* fixes #1205
* minor change
* suggested changes
* reviewed changes
* final update
2018-12-07 13:32:48 -03:00
c0bda4db88
Updated sendTransaction, added tests. ( #1528 )
...
* Renamed sendTransaction to send, improved API.
* Added send tests.
* Now using promisified web3
2018-12-01 02:47:32 -03:00
c2de8ffd14
Now testing events in constructors! ( #1511 )
...
* Added inTransaction tests.
* Added expectEvent.inConstructor.
* Changed inTransaction, removed decodeLogs.
* Flipped comparison to improve the error message.
* Improved expectEvent tests.
* Migrated tests to use expectEvent.
* Added roles constructor tests.
* Fixed linter errors.
* Made lodash a dev dependency.
* Added more inLogs tests.
* Update expectEvent.test.js
* Removed lodash.
* Moved role constructor tests to public role behavior.
* Revert "Flipped comparison to improve the error message."
This reverts commit 438c57833d
2018-11-27 17:56:26 -03:00
b0da0fded0
Replaced assertJump, assertRevert and expectThrow with shouldFail. ( #1363 )
...
* Replaced assertJump, assertRevert and expectThrow with shouldFail.
* Fixed linter errors.
* Fixed typo.
* Made the helpers async.
2018-10-09 16:23:55 -03:00
58a42443df
added a test helper with common constants ( #1400 )
...
* signing prefix added
* Minor improvement
* Tests changed
* Successfully tested
* Minor improvements
* Minor improvements
* Revert "Dangling commas are now required. (#1359 )"
This reverts commit a6889776f4fixes #1206
2018-10-09 15:46:09 -03:00
a6889776f4
Dangling commas are now required. ( #1359 )
2018-09-28 19:20:43 -06:00
536262f2ec
Feature/use expect event in test logs assertions #1232 ( #1343 )
...
* Add BigNumber support to expectEvent/inLogs (#1026 )
* switched direct logs array check to expectEvent method in AllowanceCrowdsale.test.js
* Refactor expectEvent.inLogs function to use simple value number check
* Introduced should.be.bignumber method to compare BigNumber values
* Use expectEvent to test logs (#1232 )
* Removed trailing space
2018-09-27 11:33:28 -03:00
4b21fcf5af
Add Mock suffix to variable names #1172 ( #1324 )
...
* Add Mock suffix to variable names #1172
* Add Impl suffix to variable names
2018-09-18 16:24:51 -03:00
d062352de7
Remove lodash from tests ( #1323 )
2018-09-17 17:21:01 -03:00
4b33eaefa2
Improved ERC721 granularity ( #1304 )
...
* Split enumerable and metadata implementations.
* Renamed ERC721Basic to ERC721, and ERC721 to ERC721Full.
* Fixed linter errors.
2018-09-07 14:04:42 -03:00
