NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
3,335 Commits 61 Branches 143 Tags
b982e2a808eebc0e2aa7c4bc7dc621fb86fecc15
Commit Graph

54 Commits

Author SHA1 Message Date
Ernesto García
63bfab1a0c Enable ERC-1271 signature checks in Governor castVoteBySig (#4418) 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Francisco <fg@frang.io>
 2023-07-05 15:11:29 +02:00
Renan Souza
e3adf91e50 Add state getter in TimelockController using OperationState enum (#4358) 
Co-authored-by: Francisco <fg@frang.io>
Co-authored-by: Ernesto García <ernestognw@gmail.com>
 2023-07-04 15:23:44 -03:00
Ernesto García
6e21422737 Add Governor signature nonces (#4378) 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Francisco <fg@frang.io>
Co-authored-by: Sergei Tikhomirov <sergey.s.tikhomirov@gmail.com>
Co-authored-by: Renan Souza <renan.rodrigues.souza1@gmail.com>
 2023-07-03 22:29:30 +02:00
Ernesto García
bb64458928 Implement recommendations from 5.0 audit Phase 1A (#4398) 
Co-authored-by: Francisco Giordano <fg@frang.io>
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
 2023-07-03 15:02:06 -03:00
Francisco
874c2d3c02 Use explicit imports (#4399) 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: ernestognw <ernestognw@gmail.com>
 2023-06-29 20:12:26 +00:00
Claudia Barcelo
cd48b3eab3 Add validation in Governor on ERC-721 or ERC-1155 received (#4314) 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Francisco <fg@frang.io>
Co-authored-by: Ernesto García <ernestognw@gmail.com>
 2023-06-15 21:43:17 -03:00
Hadrien Croubois
7cc2cbfeb5 Cleanup the structure of GovernorTimelockControl.test.js (#4302) 2023-06-14 16:00:38 +02:00
Ernesto García
b425a72240 Replace revert strings with custom errors (#4261) 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Francisco <fg@frang.io>
 2023-06-12 23:41:52 +00:00
Hadrien Croubois
d9474327a4 Merge pull request from GHSA-5h3x-9wvq-w4m2 
Co-authored-by: Francisco <fg@frang.io>
Co-authored-by: Ernesto García <ernestognw@gmail.com>
 2023-06-06 21:32:14 -03:00
Francisco
3902a410f1 Remove DOMAIN_SEPARATOR from Votes and update docs examples (#4297) 
Co-authored-by: Qiwei Yang <yangqiwei97@gmail.com>
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
 2023-06-02 12:02:57 -03:00
Hadrien Croubois
15c5c71795 Remove TokenTimelock, PaymentSplitter, ERC20Snapshot, ERC20VotesComp, GovernorVotesComp (#4276) 2023-05-26 23:30:00 +01:00
Francisco Giordano
8de6eba8a3 Merge branch 'master' into next-v5.0 2023-05-16 00:07:07 -03:00
Ernesto García
ab2604ac5b Add reentrancy test cases for TimelockController (#4200) 
Co-authored-by: Francisco <fg@frang.io>
 2023-05-02 11:36:56 +02:00
Francisco
91df66c4a9 Implement suggestions from audit of 4.9 (#4176) 
Co-authored-by: Ernesto García <ernestognw@gmail.com>
 2023-04-21 08:35:07 -03:00
Hadrien Croubois
8d633cb7d1 Merge pull request from GHSA-93hq-5wgc-jc82 
Co-authored-by: Francisco <fg@frang.io>
 2023-04-13 15:47:51 -03:00
Hadrien Croubois
790cc5b65a Add timestamp based governor with EIP-6372 and EIP-5805 (#3934) 
Co-authored-by: Francisco Giordano <fg@frang.io>
Co-authored-by: Ernesto García <ernestognw@gmail.com>
Co-authored-by: Francisco <frangio.1@gmail.com>
 2023-02-09 22:33:55 +01:00
Hadrien Croubois
5b027e517e Add missing await in tests (#4037) 2023-02-08 21:03:27 +00:00
Hadrien Croubois
d625cb45ea Include EIP-5267 discovery in EIP-712 (#3969) 
Co-authored-by: Francisco <frangio.1@gmail.com>
Co-authored-by: Francisco <fg@frang.io>
 2023-02-08 15:53:57 +01:00
JulissaDantes
bc6de21fe2 Create ProposalSalt event for TimelockController (#4001) 
Co-authored-by: Francisco <frangio.1@gmail.com>
 2023-01-27 15:47:43 -03:00
Hadrien Croubois
5e28952cbd Add a public Governor.cancel function (#3983) 2023-01-26 20:46:11 +01:00
Hadrien Croubois
147dc89054 Merge branch 'master' into next-v5.0 2023-01-14 18:51:03 -03:00
Hadrien Croubois
7c6e289782 Prepare tests for hardhat-exposed transition (#3930) 
Co-authored-by: Francisco <frangio.1@gmail.com>
 2023-01-12 09:51:29 +01:00
Francisco
a28aafdc85 Use Prettier for JS files (#3913) 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
 2023-01-04 15:03:40 +01:00
Hadrien Croubois
c1d9da4052 Use hardhat-exposed to reduce the need for mocks (#3666) 
Co-authored-by: Francisco <fg@frang.io>
 2023-01-03 14:38:13 +00:00
Pierre Grimaud
b0db207e4e Fix typos in testing files (#3899) 2022-12-28 20:16:56 -03:00
JulissaDantes
e2d2ebc8fc Make ERC20Votes independent from ERC20Permit (#3816) 
Co-authored-by: Francisco <frangio.1@gmail.com>
 2022-11-29 11:25:52 -03:00
JulissaDantes
887985413c Use default admin role in TimelockController (#3799) 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Francisco <frangio.1@gmail.com>
 2022-11-09 13:18:27 -03:00
Hadrien Croubois
ed12acfb0a Add support for EOA target in Governor.relay (#3730) 2022-09-26 15:27:33 -03:00
Hadrien Croubois
408055dfab Change admin role allocation in TimelockControler constructor (#3722) 
Co-authored-by: Francisco <frangio.1@gmail.com>
 2022-09-23 16:58:56 +02:00
Hadrien Croubois
8ea1fc87c9 Keep track of historical quorum values (#3561) 
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
 2022-07-27 13:23:10 -03:00
Andrew Fleming
4135bf9707 Fix typos in timelock test (#3461) 
fix typos
 2022-06-11 09:31:30 +02:00
Hadrien Croubois
35090c1bf1 Add tests for improved coverage (#3448) 
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
 2022-06-02 23:01:55 +00:00
onlineSoftwareDevOK
cd2da98d4d Refactor magic constant in TimelocController test (#3397) 2022-05-12 22:23:56 +00:00
Niccolò Petti
d4e6236b2b Fix deprecated expectEvent.inLogs #3332 (#3333) 2022-04-23 10:20:55 -03:00
Mihir Wadekar
76eee35971 Improve revert message in Governor (#3275) 
* Fixed typo

* fix testing and adding changelog

Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
 2022-03-25 11:02:15 +01:00
Ashwin Yardi
76fca3aec8 Add ERC721 and ERC1155 receiver support in Governor, Timelock (#3230) 
* add ERC721 and ERC1155 receiver support in Governor, Timelock and MinimalForwarder (#3174)

* revert the nft receiver hooks from MinimalForwarder and linting updates

* add ERC165 support & simplify test

* add changelog entry

Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
 2022-03-24 01:25:00 +01:00
Pandapip1
faf5820f03 Fix many spelling errors (#3274) 2022-03-22 18:16:20 -03:00
Hadrien Croubois
6a5bbfc4cb Refactor governor testing (#3194) 
* starting a governor test refactor

* improve governor tests

* refactor compatibility tests using the governor helper

* improve governor helper

* improve governor helper

* refactor governor tests

* refactor testing

* fix testing (still TODO)

* fix tests

* fix tests

* fix spelling

* use different instances of GovernorHelper

* add vote with params support

* coverage

* simplify ERC165 helper

* remove unused proposal argument

* refactor setProposal

* lint

* refactor setProposal return values

* add a data default value

* improve proposal reconstruction and storage in helper

* proposal object refactoring

* lint

Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
 2022-03-11 09:30:30 +01:00
Hadrien Croubois
8b162e39b5 Add a canceller role to the TimelockController (#3165) 
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
 2022-03-08 18:28:20 -03:00
Ben DiFrancesco
fd07cc6290 Extend Governor with parameterized votes (#3043) 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
 2022-03-01 17:55:20 -03:00
Hadrien Croubois
af7ec04b78 Improve security of the onlyGovernance modifier (#3147) 
* add a protection mechanism to prevent relaying transaction that are not
part of an execute operation

* more accurate relay authorization

* force reset the relay authorizations after executions

* refactor of the onlyGovernor modifier

* only whitelist when executor is not governor itself

* fix lint

* add private function for call permission management

* use deque

* fix lint

* remove unecessary dependency

* remove unecessary dependency

* comment rephrasing

* Update contracts/governance/Governor.sol

Co-authored-by: Francisco Giordano <frangio.1@gmail.com>

* cache keccak256(_msgData())

* use Context

* lint

* conditionnal clear

* add test to cover queue.clear()

* lint

* write more extended docs for onlyGovernance

* add changelog entry

Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
 2022-02-18 21:03:03 +01:00
Hadrien Croubois
c366de3626 Fix encoding of signature+calldata in GovernorCompatibilityBravo (#3100) 
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
 2022-01-11 15:45:06 -03:00
JulissaDantes
b42b05311b Add ERC721Votes for NFT-based governance (#2944) 
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
Co-authored-by: Hadrien Croubois <hadrien@openzeppelin.com>
 2021-12-10 18:58:45 -03:00
Hadrien Croubois
abf6024faf Add a governor module to protect against late quorum (#2973) 
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
 2021-12-01 13:56:31 -03:00
Hadrien Croubois
6089f11c2f Add a relay mechanism in the governor (#2926) 
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
 2021-11-30 17:19:20 -03:00
Hadrien Croubois
a57e638f57 Improve GovernorTimelockControl.state() to detect direct cancel (#2977) 2021-11-18 09:53:05 -03:00
Hadrien Croubois
b12af48a7d Add Governor module for governance-settable parameters (#2904) 
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
 2021-10-19 15:33:02 -03:00
Hadrien Croubois
abeb0fbf5c Delay the Pending state until strictly after proposal.voteStart (#2892) 
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
 2021-10-06 19:29:57 -03:00
Francisco Giordano
b174f067df Fix typo casted -> cast 2021-08-13 18:44:44 -03:00
Francisco Giordano
4b152bd8ce Improve Governor (#2794) 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
 2021-08-04 18:29:13 -03:00