* Add Arrays library with unit tests (#1209) * prepared due to snapshot token requirements * add library with method to find upper bound * add unit test for basic and edge cases * Imporove documentation for Arrays library Simplify Arrays.test.js to use short arrays as test date * Added comment for uint256 mid variable. * Explaned why uint256 mid variable calculated as Math.average is safe to use as index of array.
This commit is contained in:
committed by
Nicolás Venturo
parent
41f84f8b40
commit
f7e53d90fa
56
contracts/utils/Arrays.sol
Normal file
56
contracts/utils/Arrays.sol
Normal file
@ -0,0 +1,56 @@
|
||||
pragma solidity ^0.4.23;
|
||||
|
||||
import "../math/Math.sol";
|
||||
|
||||
|
||||
/**
|
||||
* @title Arrays
|
||||
* @dev Utility library of inline array functions
|
||||
*/
|
||||
library Arrays {
|
||||
|
||||
/**
|
||||
* @dev Upper bound search function which is kind of binary search algoritm. It searches sorted
|
||||
* array to find index of the element value. If element is found then returns it's index otherwise
|
||||
* it returns index of first element which is grater than searched value. If searched element is
|
||||
* bigger than any array element function then returns first index after last element (i.e. all
|
||||
* values inside the array are smaller than the target). Complexity O(log n).
|
||||
* @param array The array sorted in ascending order.
|
||||
* @param element The element's value to be find.
|
||||
* @return The calculated index value. Returns 0 for empty array.
|
||||
*/
|
||||
function findUpperBound(
|
||||
uint256[] storage array,
|
||||
uint256 element
|
||||
)
|
||||
internal
|
||||
view
|
||||
returns (uint256)
|
||||
{
|
||||
if (array.length == 0) {
|
||||
return 0;
|
||||
}
|
||||
|
||||
uint256 low = 0;
|
||||
uint256 high = array.length;
|
||||
|
||||
while (low < high) {
|
||||
uint256 mid = Math.average(low, high);
|
||||
|
||||
// Note that mid will always be strictly less than high (i.e. it will be a valid array index)
|
||||
// because Math.average rounds down (it does integer division with truncation).
|
||||
if (array[mid] > element) {
|
||||
high = mid;
|
||||
} else {
|
||||
low = mid + 1;
|
||||
}
|
||||
}
|
||||
|
||||
// At this point `low` is the exclusive upper bound. We will return the inclusive upper bound.
|
||||
if (low > 0 && array[low - 1] == element) {
|
||||
return low - 1;
|
||||
} else {
|
||||
return low;
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user