NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove abbreviations from parameters (#1142)

Browse Source 
* Add an initial document for our code style

* Remove abbreviations from parameters

* Rename the param in AddressUtils

* fix comment
This commit is contained in:
Leo Arias
2018-08-02 13:38:54 -06:00
committed by Nicolás Venturo
parent 7fdca7b025
commit f49721576f
10 changed files with 68 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
contracts/mocks/BouncerMock.sol
View File

@ -4,33 +4,33 @@ import "../access/SignatureBouncer.sol";
contract SignatureBouncerMock is SignatureBouncer {
function checkValidSignature(address _address, bytes _sig)
function checkValidSignature(address _address, bytes _signature)
public
view
returns (bool)
{
return isValidSignature(_address, _sig);
return isValidSignature(_address, _signature);
}
function onlyWithValidSignature(bytes _sig)
function onlyWithValidSignature(bytes _signature)
public
onlyValidSignature(_sig)
onlyValidSignature(_signature)
view
{
}
function checkValidSignatureAndMethod(address _address, bytes _sig)
function checkValidSignatureAndMethod(address _address, bytes _signature)
public
view
returns (bool)
{
return isValidSignatureAndMethod(_address, _sig);
return isValidSignatureAndMethod(_address, _signature);
}
function onlyWithValidSignatureAndMethod(bytes _sig)
function onlyWithValidSignatureAndMethod(bytes _signature)
public
onlyValidSignatureAndMethod(_sig)
onlyValidSignatureAndMethod(_signature)
view
{
@ -40,18 +40,18 @@ contract SignatureBouncerMock is SignatureBouncer {
address _address,
bytes,
uint,
bytes _sig
bytes _signature
)
public
view
returns (bool)
{
return isValidSignatureAndData(_address, _sig);
return isValidSignatureAndData(_address, _signature);
}
function onlyWithValidSignatureAndData(uint, bytes _sig)
function onlyWithValidSignatureAndData(uint, bytes _signature)
public
onlyValidSignatureAndData(_sig)
onlyValidSignatureAndData(_signature)
view
{

4
contracts/mocks/ECRecoveryMock.sol
View File

@ -7,12 +7,12 @@ import "../ECRecovery.sol";
contract ECRecoveryMock {
using ECRecovery for bytes32;
function recover(bytes32 _hash, bytes _sig)
function recover(bytes32 _hash, bytes _signature)
public
pure
returns (address)
{
return _hash.recover(_sig);
return _hash.recover(_signature);
}
function toEthSignedMessageHash(bytes32 _hash)

6
contracts/mocks/RBACMock.sol
View File

@ -55,15 +55,15 @@ contract RBACMock is RBACWithAdmin {
}
// admins can remove advisor's role
function removeAdvisor(address _addr)
function removeAdvisor(address _account)
public
onlyAdmin
{
// revert if the user isn't an advisor
// (perhaps you want to soft-fail here instead?)
checkRole(_addr, ROLE_ADVISOR);
checkRole(_account, ROLE_ADVISOR);
// remove the advisor's role
removeRole(_addr, ROLE_ADVISOR);
removeRole(_account, ROLE_ADVISOR);
}
}