NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove abbreviations from parameters (#1142)

Browse Source 
* Add an initial document for our code style

* Remove abbreviations from parameters

* Rename the param in AddressUtils

* fix comment
This commit is contained in:
Leo Arias
2018-08-02 13:38:54 -06:00
committed by Nicolás Venturo
parent 7fdca7b025
commit f49721576f
10 changed files with 68 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
contracts/ECRecovery.sol
View File

@ -13,9 +13,9 @@ library ECRecovery {
/**
* @dev Recover signer address from a message by using their signature
* @param _hash bytes32 message, the hash is the signed message. What is recovered is the signer address.
* @param _sig bytes signature, the signature is generated using web3.eth.sign()
* @param _signature bytes signature, the signature is generated using web3.eth.sign()
*/
function recover(bytes32 _hash, bytes _sig)
function recover(bytes32 _hash, bytes _signature)
internal
pure
returns (address)
@ -25,7 +25,7 @@ library ECRecovery {
uint8 v;
// Check the signature length
if (_sig.length != 65) {
if (_signature.length != 65) {
return (address(0));
}
@ -34,9 +34,9 @@ library ECRecovery {
// currently is to use assembly.
// solium-disable-next-line security/no-inline-assembly
assembly {
r := mload(add(_sig, 32))
s := mload(add(_sig, 64))
v := byte(0, mload(add(_sig, 96)))
r := mload(add(_signature, 32))
s := mload(add(_signature, 64))
v := byte(0, mload(add(_signature, 96)))
}
// Version of signature should be 27 or 28, but 0 and 1 are also possible versions