NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add ability to create clones with initial value in Clones.sol (#4936)

Browse Source 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: ernestognw <ernestognw@gmail.com>
This commit is contained in:
Anton Bukov
2024-03-06 20:44:42 +01:00
committed by GitHub
parent 8b2f29ceb0
commit e83142944f
19 changed files with 182 additions and 102 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
test/proxy/Clones.behaviour.js
View File

@ -13,6 +13,25 @@ module.exports = function shouldBehaveLikeClone() {
});
};
describe('construct with value', function () {
const value = 10n;
it('factory has enough balance', async function () {
await this.deployer.sendTransaction({ to: this.factory, value });
const instance = await this.createClone({ deployValue: value });
await expect(instance.deploymentTransaction()).to.changeEtherBalances([this.factory, instance], [-value, value]);
expect(await ethers.provider.getBalance(instance)).to.equal(value);
});
it('factory does not have enough balance', async function () {
await expect(this.createClone({ deployValue: value }))
.to.be.revertedWithCustomError(this.factory, 'InsufficientBalance')
.withArgs(0n, value);
});
});
describe('initialization without parameters', function () {
describe('non payable', function () {
const expectedInitializedValue = 10n;
@ -23,7 +42,7 @@ module.exports = function shouldBehaveLikeClone() {
describe('when not sending balance', function () {
beforeEach('creating proxy', async function () {
this.proxy = await this.createClone(this.initializeData);
this.proxy = await this.createClone({ initData: this.initializeData });
});
assertProxyInitialization({
@ -36,7 +55,7 @@ module.exports = function shouldBehaveLikeClone() {
const value = 10n ** 6n;
it('reverts', async function () {
await expect(this.createClone(this.initializeData, { value })).to.be.reverted;
await expect(this.createClone({ initData: this.initializeData, initValue: value })).to.be.reverted;
});
});
});
@ -50,7 +69,7 @@ module.exports = function shouldBehaveLikeClone() {
describe('when not sending balance', function () {
beforeEach('creating proxy', async function () {
this.proxy = await this.createClone(this.initializeData);
this.proxy = await this.createClone({ initData: this.initializeData });
});
assertProxyInitialization({
@ -63,7 +82,7 @@ module.exports = function shouldBehaveLikeClone() {
const value = 10n ** 6n;
beforeEach('creating proxy', async function () {
this.proxy = await this.createClone(this.initializeData, { value });
this.proxy = await this.createClone({ initData: this.initializeData, initValue: value });
});
assertProxyInitialization({
@ -86,7 +105,7 @@ module.exports = function shouldBehaveLikeClone() {
describe('when not sending balance', function () {
beforeEach('creating proxy', async function () {
this.proxy = await this.createClone(this.initializeData);
this.proxy = await this.createClone({ initData: this.initializeData });
});
assertProxyInitialization({
@ -99,7 +118,7 @@ module.exports = function shouldBehaveLikeClone() {
const value = 10n ** 6n;
it('reverts', async function () {
await expect(this.createClone(this.initializeData, { value })).to.be.reverted;
await expect(this.createClone({ initData: this.initializeData, initValue: value })).to.be.reverted;
});
});
});
@ -115,7 +134,7 @@ module.exports = function shouldBehaveLikeClone() {
describe('when not sending balance', function () {
beforeEach('creating proxy', async function () {
this.proxy = await this.createClone(this.initializeData);
this.proxy = await this.createClone({ initData: this.initializeData });
});
assertProxyInitialization({
@ -128,7 +147,7 @@ module.exports = function shouldBehaveLikeClone() {
const value = 10n ** 6n;
beforeEach('creating proxy', async function () {
this.proxy = await this.createClone(this.initializeData, { value });
this.proxy = await this.createClone({ initData: this.initializeData, initValue: value });
});
assertProxyInitialization({