NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

remove all checks for short address attack (fixes #261)

Browse Source
This commit is contained in:
Francisco Giordano
2017-06-26 15:03:58 -03:00
parent 79b3a1b1a2
commit e33d9bb41b
2 changed files with 2 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
contracts/token/BasicToken.sol
View File

@ -14,22 +14,12 @@ contract BasicToken is ERC20Basic {
mapping(address => uint256) balances; mapping(address => uint256) balances;
/**
* @dev Fix for the ERC20 short address attack.
*/
modifier onlyPayloadSize(uint256 size) {
if(msg.data.length < size + 4) {
throw;
}
_;
}
/** /**
* @dev transfer token for a specified address * @dev transfer token for a specified address
* @param _to The address to transfer to. * @param _to The address to transfer to.
* @param _value The amount to be transferred. * @param _value The amount to be transferred.
*/ */
function transfer(address _to, uint256 _value) onlyPayloadSize(2 * 32) { function transfer(address _to, uint256 _value) {
balances[msg.sender] = balances[msg.sender].sub(_value); balances[msg.sender] = balances[msg.sender].sub(_value);
balances[_to] = balances[_to].add(_value); balances[_to] = balances[_to].add(_value);
Transfer(msg.sender, _to, _value); Transfer(msg.sender, _to, _value);

2
contracts/token/StandardToken.sol
View File

@ -23,7 +23,7 @@ contract StandardToken is BasicToken, ERC20 {
* @param _to address The address which you want to transfer to * @param _to address The address which you want to transfer to
* @param _value uint256 the amout of tokens to be transfered * @param _value uint256 the amout of tokens to be transfered
*/ */
function transferFrom(address _from, address _to, uint256 _value) onlyPayloadSize(3 * 32) { function transferFrom(address _from, address _to, uint256 _value) {
var _allowance = allowed[_from][msg.sender]; var _allowance = allowed[_from][msg.sender];
// Check is not needed because sub(_allowance, _value) will already throw if this condition is not met // Check is not needed because sub(_allowance, _value) will already throw if this condition is not met