NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename "amount" to "value" in permit (#2445)

Browse Source
This commit is contained in:
Mikhail Melnik
2020-12-23 18:09:16 +03:00
committed by GitHub
parent c23d5e0143
commit da00d28cb7
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
contracts/drafts/ERC20Permit.sol
View File

@ -35,7 +35,7 @@ abstract contract ERC20Permit is ERC20, IERC20Permit, EIP712 {
/** /**
* @dev See {IERC20Permit-permit}. * @dev See {IERC20Permit-permit}.
*/ */
function permit(address owner, address spender, uint256 amount, uint256 deadline, uint8 v, bytes32 r, bytes32 s) public virtual override { function permit(address owner, address spender, uint256 value, uint256 deadline, uint8 v, bytes32 r, bytes32 s) public virtual override {
// solhint-disable-next-line not-rely-on-time // solhint-disable-next-line not-rely-on-time
require(block.timestamp <= deadline, "ERC20Permit: expired deadline"); require(block.timestamp <= deadline, "ERC20Permit: expired deadline");
@ -44,7 +44,7 @@ abstract contract ERC20Permit is ERC20, IERC20Permit, EIP712 {
_PERMIT_TYPEHASH, _PERMIT_TYPEHASH,
owner, owner,
spender, spender,
amount, value,
_nonces[owner].current(), _nonces[owner].current(),
deadline deadline
) )
@ -56,7 +56,7 @@ abstract contract ERC20Permit is ERC20, IERC20Permit, EIP712 {
require(signer == owner, "ERC20Permit: invalid signature"); require(signer == owner, "ERC20Permit: invalid signature");
_nonces[owner].increment(); _nonces[owner].increment();
_approve(owner, spender, amount); _approve(owner, spender, value);
} }
/** /**

4
contracts/drafts/IERC20Permit.sol
View File

@ -12,7 +12,7 @@ pragma solidity >=0.6.0 <0.8.0;
*/ */
interface IERC20Permit { interface IERC20Permit {
/** /**
* @dev Sets `amount` as the allowance of `spender` over `owner`'s tokens, * @dev Sets `value` as the allowance of `spender` over `owner`'s tokens,
* given `owner`'s signed approval. * given `owner`'s signed approval.
* *
* IMPORTANT: The same issues {IERC20-approve} has related to transaction * IMPORTANT: The same issues {IERC20-approve} has related to transaction
@ -32,7 +32,7 @@ interface IERC20Permit {
* https://eips.ethereum.org/EIPS/eip-2612#specification[relevant EIP * https://eips.ethereum.org/EIPS/eip-2612#specification[relevant EIP
* section]. * section].
*/ */
function permit(address owner, address spender, uint256 amount, uint256 deadline, uint8 v, bytes32 r, bytes32 s) external; function permit(address owner, address spender, uint256 value, uint256 deadline, uint8 v, bytes32 r, bytes32 s) external;
/** /**
* @dev Returns the current nonce for `owner`. This value must be * @dev Returns the current nonce for `owner`. This value must be