NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix memory leak in merkle verification (#3039)

Browse Source
This commit is contained in:
Hadrien Croubois
2021-12-21 21:01:28 +01:00
committed by GitHub
parent e667ec9533
commit cafd900ad6
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
contracts/utils/cryptography/MerkleProof.sol
View File

@ -41,12 +41,20 @@ library MerkleProof {
bytes32 proofElement = proof[i]; bytes32 proofElement = proof[i];
if (computedHash <= proofElement) { if (computedHash <= proofElement) {
// Hash(current computed hash + current element of the proof) // Hash(current computed hash + current element of the proof)
computedHash = keccak256(abi.encodePacked(computedHash, proofElement)); computedHash = _efficientHash(computedHash, proofElement);
} else { } else {
// Hash(current element of the proof + current computed hash) // Hash(current element of the proof + current computed hash)
computedHash = keccak256(abi.encodePacked(proofElement, computedHash)); computedHash = _efficientHash(proofElement, computedHash);
} }
} }
return computedHash; return computedHash;
} }
function _efficientHash(bytes32 a, bytes32 b) private pure returns (bytes32 value) {
assembly {
mstore(0x00, a)
mstore(0x20, b)
value := keccak256(0x00, 0x40)
}
}
} }