NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: use require in SafeMath (#1187)

Browse Source 
* feat: use require in SafeMath

* fix: grammar with revert
This commit is contained in:
Brett Sun
2018-08-10 19:41:06 +01:00
committed by Nicolás Venturo
parent 6dab31288e
commit c9e91586e7
2 changed files with 18 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
test/math/SafeMath.test.js
View File

@ -1,4 +1,4 @@
const { assertJump } = require('../helpers/assertJump');
const { assertRevert } = require('../helpers/assertRevert');
const BigNumber = web3.BigNumber;
const SafeMathMock = artifacts.require('SafeMathMock');
@ -22,11 +22,11 @@ contract('SafeMath', () => {
result.should.be.bignumber.equal(a.plus(b));
});
it('throws an error on addition overflow', async function () {
it('throws a revert error on addition overflow', async function () {
const a = MAX_UINT;
const b = new BigNumber(1);
await assertJump(this.safeMath.add(a, b));
await assertRevert(this.safeMath.add(a, b));
});
});
@ -39,11 +39,11 @@ contract('SafeMath', () => {
result.should.be.bignumber.equal(a.minus(b));
});
it('throws an error if subtraction result would be negative', async function () {
it('throws a revert error if subtraction result would be negative', async function () {
const a = new BigNumber(1234);
const b = new BigNumber(5678);
await assertJump(this.safeMath.sub(a, b));
await assertRevert(this.safeMath.sub(a, b));
});
});
@ -64,11 +64,11 @@ contract('SafeMath', () => {
result.should.be.bignumber.equal(a.times(b));
});
it('throws an error on multiplication overflow', async function () {
it('throws a revert error on multiplication overflow', async function () {
const a = MAX_UINT;
const b = new BigNumber(2);
await assertJump(this.safeMath.mul(a, b));
await assertRevert(this.safeMath.mul(a, b));
});
});
@ -81,11 +81,11 @@ contract('SafeMath', () => {
result.should.be.bignumber.equal(a.div(b));
});
it('throws an error on zero division', async function () {
it('throws a revert error on zero division', async function () {
const a = new BigNumber(5678);
const b = new BigNumber(0);
await assertJump(this.safeMath.div(a, b));
await assertRevert(this.safeMath.div(a, b));
});
});
});