feat: use extcodesize for isContract to reduce gas (#2311)

* feat: use extcodesize for isContract to reduce gas

* feat: add changelog entry
This commit is contained in:
Julian M. Rodriguez
2020-07-14 17:08:41 -03:00
committed by GitHub
parent 98e862e162
commit c801c8d2bb
2 changed files with 12 additions and 7 deletions

View File

@ -24,14 +24,14 @@ library Address {
* ====
*/
function isContract(address account) internal view returns (bool) {
// According to EIP-1052, 0x0 is the value returned for not-yet created accounts
// and 0xc5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470 is returned
// for accounts without code, i.e. `keccak256('')`
bytes32 codehash;
bytes32 accountHash = 0xc5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470;
// This method relies in extcodesize, which returns 0 for contracts in
// construction, since the code is only stored at the end of the
// constructor execution.
uint256 size;
// solhint-disable-next-line no-inline-assembly
assembly { codehash := extcodehash(account) }
return (codehash != accountHash && codehash != 0x0);
assembly { size := extcodesize(account) }
return size > 0;
}
/**