NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use hardhat-exposed to reduce the need for mocks (#3666)

Browse Source 
Co-authored-by: Francisco <fg@frang.io>
This commit is contained in:
Hadrien Croubois
2023-01-03 15:38:13 +01:00
committed by GitHub
parent a81b0d0b21
commit c1d9da4052
190 changed files with 2297 additions and 4311 deletions
Download Patch File Download Diff File Expand all files Collapse all files

74
test/utils/Create2.test.js
View File

@ -1,39 +1,39 @@
const { balance, BN, ether, expectRevert, send } = require('@openzeppelin/test-helpers');
const { balance, ether, expectEvent, expectRevert, send } = require('@openzeppelin/test-helpers');
const { computeCreate2Address } = require('../helpers/create2');
const { expect } = require('chai');
const Create2Impl = artifacts.require('Create2Impl');
const ERC20Mock = artifacts.require('ERC20Mock');
const ERC1820Implementer = artifacts.require('ERC1820Implementer');
const Create2 = artifacts.require('$Create2');
const VestingWallet = artifacts.require('VestingWallet');
const ERC1820Implementer = artifacts.require('$ERC1820Implementer');
contract('Create2', function (accounts) {
const [deployerAccount] = accounts;
const [ deployerAccount, other ] = accounts;
const salt = 'salt message';
const saltHex = web3.utils.soliditySha3(salt);
const encodedParams = web3.eth.abi.encodeParameters(
['string', 'string', 'address', 'uint256'],
['MyToken', 'MTKN', deployerAccount, 100],
[ 'address', 'uint64', 'uint64' ],
[ other, 0, 0 ],
).slice(2);
const constructorByteCode = `${ERC20Mock.bytecode}${encodedParams}`;
const constructorByteCode = `${VestingWallet.bytecode}${encodedParams}`;
beforeEach(async function () {
this.factory = await Create2Impl.new();
this.factory = await Create2.new();
});
describe('computeAddress', function () {
it('computes the correct contract address', async function () {
const onChainComputed = await this.factory
.computeAddress(saltHex, web3.utils.keccak256(constructorByteCode));
const onChainComputed =
await this.factory.$computeAddress(saltHex, web3.utils.keccak256(constructorByteCode));
const offChainComputed =
computeCreate2Address(saltHex, constructorByteCode, this.factory.address);
expect(onChainComputed).to.equal(offChainComputed);
});
it('computes the correct contract address with deployer', async function () {
const onChainComputed = await this.factory
.computeAddressWithDeployer(saltHex, web3.utils.keccak256(constructorByteCode), deployerAccount);
const onChainComputed =
await this.factory.$computeAddress(saltHex, web3.utils.keccak256(constructorByteCode), deployerAccount);
const offChainComputed =
computeCreate2Address(saltHex, constructorByteCode, deployerAccount);
expect(onChainComputed).to.equal(offChainComputed);
@ -42,19 +42,27 @@ contract('Create2', function (accounts) {
describe('deploy', function () {
it('deploys a ERC1820Implementer from inline assembly code', async function () {
const offChainComputed =
computeCreate2Address(saltHex, ERC1820Implementer.bytecode, this.factory.address);
await this.factory.deployERC1820Implementer(0, saltHex);
const offChainComputed = computeCreate2Address(saltHex, ERC1820Implementer.bytecode, this.factory.address);
expectEvent(
await this.factory.$deploy(0, saltHex, ERC1820Implementer.bytecode),
'return$deploy',
{ addr: offChainComputed },
);
expect(ERC1820Implementer.bytecode).to.include((await web3.eth.getCode(offChainComputed)).slice(2));
});
it('deploys a ERC20Mock with correct balances', async function () {
it('deploys a contract with constructor arguments', async function () {
const offChainComputed = computeCreate2Address(saltHex, constructorByteCode, this.factory.address);
await this.factory.deploy(0, saltHex, constructorByteCode);
expectEvent(
await this.factory.$deploy(0, saltHex, constructorByteCode),
'return$deploy',
{ addr: offChainComputed },
);
const erc20 = await ERC20Mock.at(offChainComputed);
expect(await erc20.balanceOf(deployerAccount)).to.be.bignumber.equal(new BN(100));
expect(await VestingWallet.at(offChainComputed).then(instance => instance.beneficiary())).to.be.equal(other);
});
it('deploys a contract with funds deposited in the factory', async function () {
@ -62,29 +70,39 @@ contract('Create2', function (accounts) {
await send.ether(deployerAccount, this.factory.address, deposit);
expect(await balance.current(this.factory.address)).to.be.bignumber.equal(deposit);
const onChainComputed = await this.factory
.computeAddressWithDeployer(saltHex, web3.utils.keccak256(constructorByteCode), this.factory.address);
const offChainComputed = computeCreate2Address(saltHex, constructorByteCode, this.factory.address);
await this.factory.deploy(deposit, saltHex, constructorByteCode);
expect(await balance.current(onChainComputed)).to.be.bignumber.equal(deposit);
expectEvent(
await this.factory.$deploy(deposit, saltHex, constructorByteCode),
'return$deploy',
{ addr: offChainComputed },
);
expect(await balance.current(offChainComputed)).to.be.bignumber.equal(deposit);
});
it('fails deploying a contract in an existent address', async function () {
await this.factory.deploy(0, saltHex, constructorByteCode, { from: deployerAccount });
expectEvent(
await this.factory.$deploy(0, saltHex, constructorByteCode),
'return$deploy',
);
await expectRevert(
this.factory.deploy(0, saltHex, constructorByteCode, { from: deployerAccount }), 'Create2: Failed on deploy',
this.factory.$deploy(0, saltHex, constructorByteCode),
'Create2: Failed on deploy',
);
});
it('fails deploying a contract if the bytecode length is zero', async function () {
await expectRevert(
this.factory.deploy(0, saltHex, '0x', { from: deployerAccount }), 'Create2: bytecode length is zero',
this.factory.$deploy(0, saltHex, '0x'),
'Create2: bytecode length is zero',
);
});
it('fails deploying a contract if factory contract does not have sufficient balance', async function () {
await expectRevert(
this.factory.deploy(1, saltHex, constructorByteCode, { from: deployerAccount }),
this.factory.$deploy(1, saltHex, constructorByteCode),
'Create2: insufficient balance',
);
});