NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix GovernorPreventLateQuorum.spec

Browse Source
This commit is contained in:
Hadrien Croubois
2023-02-28 18:35:03 +01:00
parent 6c4ffe783f
commit bf73fb4013
2 changed files with 24 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
certora/scripts/passes/verifyGovernorPreventLateQuorum.sh
View File

@ -8,6 +8,5 @@ certoraRun \
--link GovernorFullHarness:token=ERC20VotesHarness \ --link GovernorFullHarness:token=ERC20VotesHarness \
--optimistic_loop \ --optimistic_loop \
--loop_iter 1 \ --loop_iter 1 \
--send_only \
--rules deadlineNeverReduced againstVotesDontCount hasVotedCorrelationNonzero canExtendDeadlineOnce deadlineChangeEffects quorumReachedCantChange quorumLengthGt0 cantExtendWhenQuorumUnreached quorumNumerLTEDenom deprecatedQuorumStateIsUninitialized \ --rules deadlineNeverReduced againstVotesDontCount hasVotedCorrelationNonzero canExtendDeadlineOnce deadlineChangeEffects quorumReachedCantChange quorumLengthGt0 cantExtendWhenQuorumUnreached quorumNumerLTEDenom deprecatedQuorumStateIsUninitialized \
$@ $@

8
certora/specs/GovernorPreventLateQuorum.spec
View File

@ -50,7 +50,6 @@ methods {
quorumDenominator() returns uint256 envfree quorumDenominator() returns uint256 envfree
votingPeriod() returns uint256 envfree votingPeriod() returns uint256 envfree
lateQuorumVoteExtension() returns uint64 envfree lateQuorumVoteExtension() returns uint64 envfree
propose(address[], uint256[], bytes[], string)
// harness // harness
getDeprecatedQuorumNumerator() returns uint256 envfree getDeprecatedQuorumNumerator() returns uint256 envfree
@ -59,9 +58,6 @@ methods {
getExtendedDeadlineIsUnset(uint256) returns bool envfree getExtendedDeadlineIsUnset(uint256) returns bool envfree
getExtendedDeadlineIsStarted(uint256) returns bool envfree getExtendedDeadlineIsStarted(uint256) returns bool envfree
getExtendedDeadline(uint256) returns uint64 envfree getExtendedDeadline(uint256) returns uint64 envfree
getAgainstVotes(uint256) returns uint256 envfree
getAbstainVotes(uint256) returns uint256 envfree
getForVotes(uint256) returns uint256 envfree
getPastTotalSupply(uint256) returns (uint256) envfree getPastTotalSupply(uint256) returns (uint256) envfree
// more robust check than f.selector == _castVote(...).selector // more robust check than f.selector == _castVote(...).selector
@ -241,7 +237,7 @@ rule hasVotedCorrelationNonzero(uint256 pId, method f, env e) filtered {
uint256 forBefore = votesFor(); uint256 forBefore = votesFor();
uint256 abstainBefore = votesAbstain(); uint256 abstainBefore = votesAbstain();
bool hasVotedBefore = hasVoted(e, pId, acc); bool hasVotedBefore = hasVoted(pId, acc);
helperFunctionsWithRevertOnlyCastVote(pId, f, e); // should be f(e, args) helperFunctionsWithRevertOnlyCastVote(pId, f, e); // should be f(e, args)
@ -249,7 +245,7 @@ rule hasVotedCorrelationNonzero(uint256 pId, method f, env e) filtered {
uint256 forAfter = votesFor(); uint256 forAfter = votesFor();
uint256 abstainAfter = votesAbstain(); uint256 abstainAfter = votesAbstain();
bool hasVotedAfter = hasVoted(e, pId, acc); bool hasVotedAfter = hasVoted(pId, acc);
// want all vote categories to not decrease and at least one category to increase // want all vote categories to not decrease and at least one category to increase
assert assert