From bc14f8dc8924a17e225975a3a31752da7cbc26fb Mon Sep 17 00:00:00 2001
From: Hadrien Croubois <hadrien.croubois@gmail.com>
Date: Fri, 29 Jul 2022 09:31:02 +0200
Subject: [PATCH] Fix contract bytecode length comparaison

---
 scripts/checks/compareGasReports.js | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/scripts/checks/compareGasReports.js b/scripts/checks/compareGasReports.js
index c3bfd99ca..77ad50ba3 100755
--- a/scripts/checks/compareGasReports.js
+++ b/scripts/checks/compareGasReports.js
@@ -24,11 +24,11 @@ function average (...args) {
   return sum(...args) / args.length;
 }
 
-function variation (current, previous) {
+function variation (current, previous, offset = 0) {
   return {
     value: current,
     delta: current - previous,
-    prcnt: 100 * (current - previous) / (previous - BASE_TX_COST),
+    prcnt: 100 * (current - previous) / (previous - offset),
   };
 }
 
@@ -58,7 +58,7 @@ class Report {
       }, {
         contract: contract.name,
         method: '[construction cost]',
-        avg: variation(...[contract.gasData, contract.previousVersion.gasData].map(x => Math.round(average(...x)))),
+        avg: variation(...[contract.gasData, contract.previousVersion.gasData].map(x => Math.round(average(...x))), BASE_TX_COST),
       }])
       .sort((a, b) => `${a.contract}:${a.method}`.localeCompare(`${b.contract}:${b.method}`));
 
@@ -69,9 +69,9 @@ class Report {
       .map(key => ({
         contract: ref.info.methods[key].contract,
         method: ref.info.methods[key].fnSig,
-        min: variation(...[update, ref].map(x => Math.min(...x.info.methods[key].gasData))),
-        max: variation(...[update, ref].map(x => Math.max(...x.info.methods[key].gasData))),
-        avg: variation(...[update, ref].map(x => Math.round(average(...x.info.methods[key].gasData)))),
+        min: variation(...[update, ref].map(x => Math.min(...x.info.methods[key].gasData)), BASE_TX_COST),
+        max: variation(...[update, ref].map(x => Math.max(...x.info.methods[key].gasData)), BASE_TX_COST),
+        avg: variation(...[update, ref].map(x => Math.round(average(...x.info.methods[key].gasData))), BASE_TX_COST),
       }))
       .sort((a, b) => `${a.contract}:${a.method}`.localeCompare(`${b.contract}:${b.method}`));