NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added rule comments re burn method rules holding for burnBatch method

Browse Source
This commit is contained in:
Thomas Adams
2022-06-03 12:24:03 -07:00
parent 93928e3e19
commit bab9528dc1
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
certora/specs/ERC1155Burnable.spec
View File

@ -5,6 +5,9 @@ methods {
/// If a method call reduces account balances, the caller must be either the /// If a method call reduces account balances, the caller must be either the
/// holder of the account or approved to act on the holder's behalf. /// holder of the account or approved to act on the holder's behalf.
/// n.b. This rule is passing for all methods except `_burn` and `_burnBatch`,
/// ordinarily internal methods that are callable by our tool only because they
/// were changed to public for the purposes of verification.
rule onlyHolderOrApprovedCanReduceBalance { rule onlyHolderOrApprovedCanReduceBalance {
address holder; uint256 token; uint256 amount; address holder; uint256 token; uint256 amount;
uint256 balanceBefore = balanceOf(holder, token); uint256 balanceBefore = balanceOf(holder, token);
@ -20,6 +23,8 @@ rule onlyHolderOrApprovedCanReduceBalance {
/// Burning a larger amount of a token must reduce that token's balance more /// Burning a larger amount of a token must reduce that token's balance more
/// than burning a smaller amount. /// than burning a smaller amount.
/// n.b. This rule holds for `burnBatch` as well due to rules establishing
/// appropriate equivance between `burn` and `burnBatch` methods.
rule burnAmountProportionalToBalanceReduction { rule burnAmountProportionalToBalanceReduction {
storage beforeBurn = lastStorage; storage beforeBurn = lastStorage;
env e; env e;
@ -73,6 +78,8 @@ rule burnBatchAmountProportionalToBalanceReduction { // TODO implement rule or r
/// Two sequential burns must be equivalent to a single burn of the sum of their /// Two sequential burns must be equivalent to a single burn of the sum of their
/// amounts. /// amounts.
/// n.b. This rule holds for `burnBatch` as well due to rules establishing
/// appropriate equivance between `burn` and `burnBatch` methods.
rule sequentialBurnsEquivalentToSingleBurnOfSum { rule sequentialBurnsEquivalentToSingleBurnOfSum {
storage beforeBurns = lastStorage; storage beforeBurns = lastStorage;
env e; env e;