Ignore reentrancy inexecuteBatch and update Slither config (#3955)

Co-authored-by: Francisco <fg@frang.io>
2023-01-13 11:29:53 -06:00
parent d89e51ac42
commit a5af0adce4
3 changed files with 5 additions and 4 deletions
--- a/contracts/governance/TimelockController.sol
+++ b/contracts/governance/TimelockController.sol
@ -311,6 +311,9 @@ contract TimelockController is AccessControl, IERC721Receiver, IERC1155Receiver
     *
     * - the caller must have the 'executor' role.
     */
+    // This function can reenter, but it doesn't pose a risk because _afterCall checks that the proposal is pending,
+    // thus any modifications to the operation during reentrancy should be caught.
+    // slither-disable-next-line reentrancy-eth
    function executeBatch(
        address[] calldata targets,
        uint256[] calldata values,