Move security directory contents to utils (#4551)

test/utils/Pausable.test.js

@@ -0,0 +1,86 @@
+const { expectEvent } = require('@openzeppelin/test-helpers');
+const { expect } = require('chai');
+
+const { expectRevertCustomError } = require('../helpers/customError');
+
+const PausableMock = artifacts.require('PausableMock');
+
+contract('Pausable', function (accounts) {
+  const [pauser] = accounts;
+
+  beforeEach(async function () {
+    this.pausable = await PausableMock.new();
+  });
+
+  context('when unpaused', function () {
+    beforeEach(async function () {
+      expect(await this.pausable.paused()).to.equal(false);
+    });
+
+    it('can perform normal process in non-pause', async function () {
+      expect(await this.pausable.count()).to.be.bignumber.equal('0');
+
+      await this.pausable.normalProcess();
+      expect(await this.pausable.count()).to.be.bignumber.equal('1');
+    });
+
+    it('cannot take drastic measure in non-pause', async function () {
+      await expectRevertCustomError(this.pausable.drasticMeasure(), 'ExpectedPause', []);
+      expect(await this.pausable.drasticMeasureTaken()).to.equal(false);
+    });
+
+    context('when paused', function () {
+      beforeEach(async function () {
+        this.receipt = await this.pausable.pause({ from: pauser });
+      });
+
+      it('emits a Paused event', function () {
+        expectEvent(this.receipt, 'Paused', { account: pauser });
+      });
+
+      it('cannot perform normal process in pause', async function () {
+        await expectRevertCustomError(this.pausable.normalProcess(), 'EnforcedPause', []);
+      });
+
+      it('can take a drastic measure in a pause', async function () {
+        await this.pausable.drasticMeasure();
+        expect(await this.pausable.drasticMeasureTaken()).to.equal(true);
+      });
+
+      it('reverts when re-pausing', async function () {
+        await expectRevertCustomError(this.pausable.pause(), 'EnforcedPause', []);
+      });
+
+      describe('unpausing', function () {
+        it('is unpausable by the pauser', async function () {
+          await this.pausable.unpause();
+          expect(await this.pausable.paused()).to.equal(false);
+        });
+
+        context('when unpaused', function () {
+          beforeEach(async function () {
+            this.receipt = await this.pausable.unpause({ from: pauser });
+          });
+
+          it('emits an Unpaused event', function () {
+            expectEvent(this.receipt, 'Unpaused', { account: pauser });
+          });
+
+          it('should resume allowing normal process', async function () {
+            expect(await this.pausable.count()).to.be.bignumber.equal('0');
+            await this.pausable.normalProcess();
+            expect(await this.pausable.count()).to.be.bignumber.equal('1');
+          });
+
+          it('should prevent drastic measure', async function () {
+            await expectRevertCustomError(this.pausable.drasticMeasure(), 'ExpectedPause', []);
+          });
+
+          it('reverts when re-unpausing', async function () {
+            await expectRevertCustomError(this.pausable.unpause(), 'ExpectedPause', []);
+          });
+        });
+      });
+    });
+  });
+});

test/utils/ReentrancyGuard.test.js

@@ -0,0 +1,44 @@
+const { expectRevert } = require('@openzeppelin/test-helpers');
+const { expect } = require('chai');
+
+const { expectRevertCustomError } = require('../helpers/customError');
+
+const ReentrancyMock = artifacts.require('ReentrancyMock');
+const ReentrancyAttack = artifacts.require('ReentrancyAttack');
+
+contract('ReentrancyGuard', function () {
+  beforeEach(async function () {
+    this.reentrancyMock = await ReentrancyMock.new();
+    expect(await this.reentrancyMock.counter()).to.be.bignumber.equal('0');
+  });
+
+  it('nonReentrant function can be called', async function () {
+    expect(await this.reentrancyMock.counter()).to.be.bignumber.equal('0');
+    await this.reentrancyMock.callback();
+    expect(await this.reentrancyMock.counter()).to.be.bignumber.equal('1');
+  });
+
+  it('does not allow remote callback', async function () {
+    const attacker = await ReentrancyAttack.new();
+    await expectRevert(this.reentrancyMock.countAndCall(attacker.address), 'ReentrancyAttack: failed call', []);
+  });
+
+  it('_reentrancyGuardEntered should be true when guarded', async function () {
+    await this.reentrancyMock.guardedCheckEntered();
+  });
+
+  it('_reentrancyGuardEntered should be false when unguarded', async function () {
+    await this.reentrancyMock.unguardedCheckNotEntered();
+  });
+
+  // The following are more side-effects than intended behavior:
+  // I put them here as documentation, and to monitor any changes
+  // in the side-effects.
+  it('does not allow local recursion', async function () {
+    await expectRevertCustomError(this.reentrancyMock.countLocalRecursive(10), 'ReentrancyGuardReentrantCall', []);
+  });
+
+  it('does not allow indirect local recursion', async function () {
+    await expectRevert(this.reentrancyMock.countThisRecursive(10), 'ReentrancyMock: failed call', []);
+  });
+});