NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

reorganization + violated rules

Browse Source
This commit is contained in:
Michael M
2021-11-12 09:02:51 +02:00
committed by Aleksander Kryukov
parent 0598a3ac43
commit 921c668a59
1 changed files with 162 additions and 119 deletions
Download Patch File Download Diff File Expand all files Collapse all files

181
certora/specs/GovernorBase.spec
View File

@ -18,13 +18,44 @@ methods {
// internal functions made public in harness: // internal functions made public in harness:
_quorumReached(uint256) returns bool envfree _quorumReached(uint256) returns bool envfree
_voteSucceeded(uint256) returns bool envfree _voteSucceeded(uint256) returns bool envfree
} }
////////////////////////////////////////////////////////////////////////////// /*
////////////////////////////// INVARIANTS //////////////////////////////////// //////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
////////////////////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////// State Diagram //////////////////////////////////////////////////////////
//////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
// //
// castVote(s)() //
// ------------- propose() ---------------------- time pass --------------- time passes ----------- //
// | No Proposal | --------> | Before Start (Delay) | --------> | Voting Period | ----------------------> | execute() | //
// ------------- ---------------------- --------------- -> Executed/Canceled ----------- //
// ------------------------------------------------------------|---------------|-------------------------|--------------> //
// t start end timelock //
// //
//////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
*/
///////////////////////////////////////////////////////////////////////////////////////
///////////////////////////////// Global Valid States /////////////////////////////////
///////////////////////////////////////////////////////////////////////////////////////
// not complete
/*
* If any of the properties are non zero, the rest has to be non zero
*/
// start !0 !0 !0
// end = !0 !0 !0
// exe = 0 0 1 1
// can = 0 1 0 1
invariant proposalInitiated(uint256 pId)
(proposalSnapshot(pId) != 0 <=> proposalDeadline(pId) != 0) &&
(isCanceled(pId) => proposalSnapshot(pId) != 0) &&
(isExecuted(pId) => proposalSnapshot(pId) != 0)
// pass
/* /*
* A proposal cannot end unless it started. * A proposal cannot end unless it started.
*/ */
@ -33,70 +64,74 @@ invariant voteStartBeforeVoteEnd(uint256 pId)
&& (proposalSnapshot(pId) == 0 => proposalDeadline(pId) == 0) && (proposalSnapshot(pId) == 0 => proposalDeadline(pId) == 0)
/** // pass
/*
* A proposal cannot be both executed and canceled. * A proposal cannot be both executed and canceled.
*/ */
invariant noBothExecutedAndCanceled(uint256 pId) invariant noBothExecutedAndCanceled(uint256 pId)
!isExecuted(pId) || !isCanceled(pId) !isExecuted(pId) || !isCanceled(pId)
/**
* A proposal could be executed only if quorum was reached and vote succeeded
*/
invariant executionOnlyIfQuoromReachedAndVoteSucceeded(uint256 pId)
isExecuted(pId) => _quorumReached(pId) && _voteSucceeded(pId)
///////////////////////////////////////////////////////////////////////////////////////
////////////////////////////////// In-State Rules /////////////////////////////////////
///////////////////////////////////////////////////////////////////////////////////////
////////////////////////////////////////////////////////////////////////////// //==========================================
/////////////////////////////////// RULES //////////////////////////////////// //------------- Voting Period --------------
////////////////////////////////////////////////////////////////////////////// //==========================================
// pass
/* /*
* No functions should be allowed to run after a job is deemed as canceled * A user cannot vote twice
*/ */
rule cannotSetIfCanceled(uint256 pId, method f) filtered { f-> !f.isView }{ rule doubleVoting(uint256 pId, uint8 sup) {
require(isCanceled(pId)); env e;
env e; calldataarg args; address user = e.msg.sender;
f(e, args);
assert(isCanceled(pId) => lastReverted == true, "Function did not revert when canceled"); bool votedCheck = hasVoted(e, pId, user);
require votedCheck == true;
castVote@withrevert(e, pId, sup);
bool reverted = lastReverted;
assert votedCheck => reverted, "double voting accured";
} }
/* ///////////////////////////////////////////////////////////////////////////////////////
* No functions should be allowed to run after a job is deemed as executed //////////////////////////// State Transitions Rules //////////////////////////////////
*/ ///////////////////////////////////////////////////////////////////////////////////////
rule cannotSetIfExecuted(uint256 pId, method f) filtered { f-> !f.isView }{
require(isExecuted(pId));
env e; calldataarg args;
f(e, args);
assert(isExecuted(pId) => lastReverted == true, "Function did not revert after executed");
}
//===========================================
//-------- Propose() --> End of Time --------
//===========================================
// pass
/* /*
* The voting must start not before the proposal’s creation time * The voting must start not before the proposal’s creation time
*/ */
rule noStartBeforeCreation(uint256 pId) { rule noStartBeforeCreation(uint256 pId) {
uint previousStart = proposalSnapshot(pId); uint256 previousStart = proposalSnapshot(pId);
require previousStart == 0; require previousStart == 0;
env e; env e;
calldataarg arg; calldataarg arg;
propose(e, arg); propose(e, arg);
uint newStart = proposalSnapshot(pId); uint newStart = proposalSnapshot(pId);
// if created, start is after creation // if created, start is after current block number (creation block)
assert(newStart != 0 => newStart >= e.block.number); assert(newStart != previousStart => newStart >= e.block.number);
} }
// pass
/* /*
* Once a proposal is created, voteStart and voteEnd are immutable * Once a proposal is created, voteStart and voteEnd are immutable
*/ */
rule immutableFieldsAfterProposalCreation(uint256 pId, method f) { rule immutableFieldsAfterProposalCreation(uint256 pId, method f) {
uint _voteStart = proposalSnapshot(pId); uint _voteStart = proposalSnapshot(pId);
uint _voteEnd = proposalDeadline(pId); uint _voteEnd = proposalDeadline(pId);
require _voteStart > 0; // proposal was created require _voteStart > 0; // proposal was created - relation proved in noStartBeforeCreation
env e; env e;
calldataarg arg; calldataarg arg;
@ -108,34 +143,44 @@ rule immutableFieldsAfterProposalCreation(uint256 pId, method f) {
assert _voteEnd == voteEnd_; assert _voteEnd == voteEnd_;
} }
// pass
/* /*
* A user cannot vote twice * A proposal cannot be neither executed nor canceled before it starts
*/ */
rule doubleVoting(uint256 pId, uint8 sup) { rule noExecuteOrCancelBeforeStarting(uint256 pId, method f){
env e; env e;
address user = e.msg.sender;
bool votedCheck = hasVoted(e, pId, user); require !isExecuted(pId) && !isCanceled(pId);
castVote@withrevert(e, pId, sup); calldataarg arg;
bool reverted = lastReverted; f(e, arg);
assert votedCheck => reverted, "double voting accured"; assert e.block.number < proposalSnapshot(pId) => (!isExecuted(pId) && !isCanceled(pId)), "executed/cancelled before start";
} }
//============================================
//--- End of Voting Period --> End of Time ---
//============================================
// pass
/* /*
* When a proposal is created the start and end date are created in the future. * A proposal cannot be neither executed nor canceled before proposal's deadline
*/ */
rule proposalCreatedStartAndEndDateInFuture(address[] targets, uint256[] values, bytes[] calldatas){ rule noExecuteOrCancelBeforeDeadline(uint256 pId, method f){
env e; env e;
uint256 pId = callPropose(e, targets, values, calldatas);
uint256 startDate = proposalSnapshot(pId); requireInvariant voteStartBeforeVoteEnd(pId);
uint256 endDate = proposalDeadline(pId); require !isExecuted(pId) && !isCanceled(pId);
assert(startDate >= e.block.number && endDate >= e.block.number, "Start or end date were set in the past");
calldataarg arg;
f(e, arg);
assert e.block.number < proposalDeadline(pId) => (!isExecuted(pId) && !isCanceled(pId)), "executed/cancelled before deadline";
} }
////////////////////////////////////////////////////////////////////////////////
////////////////////// Integrity Of Functions (Unit Tests) /////////////////////
////////////////////////////////////////////////////////////////////////////////
/** /**
* Check hashProposal hashing is reliable (different inputs lead to different buffers hashed) * Check hashProposal hashing is reliable (different inputs lead to different buffers hashed)
@ -161,32 +206,30 @@ rule checkHashProposal {
} }
*/ */
////////////////////////////////////////////////////////////////////////////////
//////////////////////////////// High Level Rules //////////////////////////////
////////////////////////////////////////////////////////////////////////////////
/** // not passing
* A proposal cannot be neither executed nor canceled before it starts /*
* all non-view functions should revert if proposal is executed
*/ */
rule noExecuteOrCancelBeforeStarting(uint256 pId, method f){ rule allFunctionsRevertIfExecuted(uint256 pId, method f) filtered { f -> !f.isView } {
env e; env e; calldataarg args;
require(isExecuted(pId));
require !isExecuted(pId) && !isCanceled(pId); f@withrevert(e,args);
assert(lastReverted == true, "Function was not reverted");
calldataarg arg;
f(e, arg);
assert e.block.number < proposalSnapshot(pId) => (!isExecuted(pId) && !isCanceled(pId)), "executed/cancelled before start";
} }
/** // not passing
* A proposal cannot be neither executed nor canceled before proposal's deadline /*
* all non-view functions should revert if proposal is canceled
*/ */
rule noExecuteOrCancelBeforeDeadline(uint256 pId, method f){ rule allFunctionsRevertIfCanceled(method f) filtered { f -> !f.isView } {
env e; env e; calldataarg args;
uint256 pId = e.msg.value;
requireInvariant voteStartBeforeVoteEnd(pId); require(isCanceled(pId));
require !isExecuted(pId) && !isCanceled(pId); requireInvariant noBothExecutedAndCanceled(pId);
f@withrevert(e,args);
calldataarg arg; assert(lastReverted == true, "Function was not reverted");
f(e, arg);
assert e.block.number < proposalDeadline(pId) => (!isExecuted(pId) && !isCanceled(pId)), "executed/cancelled before start";
} }