NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Migrate ERC20 tests.

Browse Source
This commit is contained in:
Nicolás Venturo
2019-01-09 15:23:58 -03:00
parent d1e68d94cf
commit 8b14d63670
1 changed files with 125 additions and 132 deletions
Download Patch File Download Diff File Expand all files Collapse all files

257
test/token/ERC20/ERC20.test.js
View File

@ -1,32 +1,29 @@
const shouldFail = require('../../helpers/shouldFail'); const { BN, constants, expectEvent, shouldFail } = require('openzeppelin-test-helpers');
const expectEvent = require('../../helpers/expectEvent');
const { ZERO_ADDRESS } = require('../../helpers/constants');
const ERC20Mock = artifacts.require('ERC20Mock'); const ERC20Mock = artifacts.require('ERC20Mock');
const { BigNumber } = require('../../helpers/setup'); contract('ERC20', function ([_, initialHolder, recipient, anotherAccount]) {
const initialSupply = new BN(100);
contract('ERC20', function ([_, owner, recipient, anotherAccount]) {
beforeEach(async function () { beforeEach(async function () {
this.token = await ERC20Mock.new(owner, 100); this.token = await ERC20Mock.new(initialHolder, initialSupply);
}); });
describe('total supply', function () { describe('total supply', function () {
it('returns the total amount of tokens', async function () { it('returns the total amount of tokens', async function () {
(await this.token.totalSupply()).should.be.bignumber.equal(100); (await this.token.totalSupply()).should.be.bignumber.equal(initialSupply);
}); });
}); });
describe('balanceOf', function () { describe('balanceOf', function () {
describe('when the requested account has no tokens', function () { describe('when the requested account has no tokens', function () {
it('returns zero', async function () { it('returns zero', async function () {
(await this.token.balanceOf(anotherAccount)).should.be.bignumber.equal(0); (await this.token.balanceOf(anotherAccount)).should.be.bignumber.equal('0');
}); });
}); });
describe('when the requested account has some tokens', function () { describe('when the requested account has some tokens', function () {
it('returns the total amount of tokens', async function () { it('returns the total amount of tokens', async function () {
(await this.token.balanceOf(owner)).should.be.bignumber.equal(100); (await this.token.balanceOf(initialHolder)).should.be.bignumber.equal(initialSupply);
}); });
}); });
}); });
@ -36,29 +33,29 @@ contract('ERC20', function ([_, owner, recipient, anotherAccount]) {
const to = recipient; const to = recipient;
describe('when the sender does not have enough balance', function () { describe('when the sender does not have enough balance', function () {
const amount = 101; const amount = initialSupply.addn(1);
it('reverts', async function () { it('reverts', async function () {
await shouldFail.reverting(this.token.transfer(to, amount, { from: owner })); await shouldFail.reverting(this.token.transfer(to, amount, { from: initialHolder }));
}); });
}); });
describe('when the sender has enough balance', function () { describe('when the sender has enough balance', function () {
const amount = 100; const amount = initialSupply;
it('transfers the requested amount', async function () { it('transfers the requested amount', async function () {
await this.token.transfer(to, amount, { from: owner }); await this.token.transfer(to, amount, { from: initialHolder });
(await this.token.balanceOf(owner)).should.be.bignumber.equal(0); (await this.token.balanceOf(initialHolder)).should.be.bignumber.equal('0');
(await this.token.balanceOf(to)).should.be.bignumber.equal(amount); (await this.token.balanceOf(to)).should.be.bignumber.equal(amount);
}); });
it('emits a transfer event', async function () { it('emits a transfer event', async function () {
const { logs } = await this.token.transfer(to, amount, { from: owner }); const { logs } = await this.token.transfer(to, amount, { from: initialHolder });
expectEvent.inLogs(logs, 'Transfer', { expectEvent.inLogs(logs, 'Transfer', {
from: owner, from: initialHolder,
to: to, to: to,
value: amount, value: amount,
}); });
@ -67,10 +64,10 @@ contract('ERC20', function ([_, owner, recipient, anotherAccount]) {
}); });
describe('when the recipient is the zero address', function () { describe('when the recipient is the zero address', function () {
const to = ZERO_ADDRESS; const to = constants.ZERO_ADDRESS;
it('reverts', async function () { it('reverts', async function () {
await shouldFail.reverting(this.token.transfer(to, 100, { from: owner })); await shouldFail.reverting(this.token.transfer(to, initialSupply, { from: initialHolder }));
}); });
}); });
}); });
@ -80,13 +77,13 @@ contract('ERC20', function ([_, owner, recipient, anotherAccount]) {
const spender = recipient; const spender = recipient;
describe('when the sender has enough balance', function () { describe('when the sender has enough balance', function () {
const amount = 100; const amount = initialSupply;
it('emits an approval event', async function () { it('emits an approval event', async function () {
const { logs } = await this.token.approve(spender, amount, { from: owner }); const { logs } = await this.token.approve(spender, amount, { from: initialHolder });
expectEvent.inLogs(logs, 'Approval', { expectEvent.inLogs(logs, 'Approval', {
owner: owner, owner: initialHolder,
spender: spender, spender: spender,
value: amount, value: amount,
}); });
@ -94,33 +91,33 @@ contract('ERC20', function ([_, owner, recipient, anotherAccount]) {
describe('when there was no approved amount before', function () { describe('when there was no approved amount before', function () {
it('approves the requested amount', async function () { it('approves the requested amount', async function () {
await this.token.approve(spender, amount, { from: owner }); await this.token.approve(spender, amount, { from: initialHolder });
(await this.token.allowance(owner, spender)).should.be.bignumber.equal(amount); (await this.token.allowance(initialHolder, spender)).should.be.bignumber.equal(amount);
}); });
}); });
describe('when the spender had an approved amount', function () { describe('when the spender had an approved amount', function () {
beforeEach(async function () { beforeEach(async function () {
await this.token.approve(spender, 1, { from: owner }); await this.token.approve(spender, new BN(1), { from: initialHolder });
}); });
it('approves the requested amount and replaces the previous one', async function () { it('approves the requested amount and replaces the previous one', async function () {
await this.token.approve(spender, amount, { from: owner }); await this.token.approve(spender, amount, { from: initialHolder });
(await this.token.allowance(owner, spender)).should.be.bignumber.equal(amount); (await this.token.allowance(initialHolder, spender)).should.be.bignumber.equal(amount);
}); });
}); });
}); });
describe('when the sender does not have enough balance', function () { describe('when the sender does not have enough balance', function () {
const amount = 101; const amount = initialSupply.addn(1);
it('emits an approval event', async function () { it('emits an approval event', async function () {
const { logs } = await this.token.approve(spender, amount, { from: owner }); const { logs } = await this.token.approve(spender, amount, { from: initialHolder });
expectEvent.inLogs(logs, 'Approval', { expectEvent.inLogs(logs, 'Approval', {
owner: owner, owner: initialHolder,
spender: spender, spender: spender,
value: amount, value: amount,
}); });
@ -128,32 +125,32 @@ contract('ERC20', function ([_, owner, recipient, anotherAccount]) {
describe('when there was no approved amount before', function () { describe('when there was no approved amount before', function () {
it('approves the requested amount', async function () { it('approves the requested amount', async function () {
await this.token.approve(spender, amount, { from: owner }); await this.token.approve(spender, amount, { from: initialHolder });
(await this.token.allowance(owner, spender)).should.be.bignumber.equal(amount); (await this.token.allowance(initialHolder, spender)).should.be.bignumber.equal(amount);
}); });
}); });
describe('when the spender had an approved amount', function () { describe('when the spender had an approved amount', function () {
beforeEach(async function () { beforeEach(async function () {
await this.token.approve(spender, 1, { from: owner }); await this.token.approve(spender, new BN(1), { from: initialHolder });
}); });
it('approves the requested amount and replaces the previous one', async function () { it('approves the requested amount and replaces the previous one', async function () {
await this.token.approve(spender, amount, { from: owner }); await this.token.approve(spender, amount, { from: initialHolder });
(await this.token.allowance(owner, spender)).should.be.bignumber.equal(amount); (await this.token.allowance(initialHolder, spender)).should.be.bignumber.equal(amount);
}); });
}); });
}); });
}); });
describe('when the spender is the zero address', function () { describe('when the spender is the zero address', function () {
const amount = 100; const amount = initialSupply;
const spender = ZERO_ADDRESS; const spender = constants.ZERO_ADDRESS;
it('reverts', async function () { it('reverts', async function () {
await shouldFail.reverting(this.token.approve(spender, amount, { from: owner })); await shouldFail.reverting(this.token.approve(spender, amount, { from: initialHolder }));
}); });
}); });
}); });
@ -166,89 +163,89 @@ contract('ERC20', function ([_, owner, recipient, anotherAccount]) {
describe('when the spender has enough approved balance', function () { describe('when the spender has enough approved balance', function () {
beforeEach(async function () { beforeEach(async function () {
await this.token.approve(spender, 100, { from: owner }); await this.token.approve(spender, initialSupply, { from: initialHolder });
}); });
describe('when the owner has enough balance', function () { describe('when the initial holder has enough balance', function () {
const amount = 100; const amount = initialSupply;
it('transfers the requested amount', async function () { it('transfers the requested amount', async function () {
await this.token.transferFrom(owner, to, amount, { from: spender }); await this.token.transferFrom(initialHolder, to, amount, { from: spender });
(await this.token.balanceOf(owner)).should.be.bignumber.equal(0); (await this.token.balanceOf(initialHolder)).should.be.bignumber.equal('0');
(await this.token.balanceOf(to)).should.be.bignumber.equal(amount); (await this.token.balanceOf(to)).should.be.bignumber.equal(amount);
}); });
it('decreases the spender allowance', async function () { it('decreases the spender allowance', async function () {
await this.token.transferFrom(owner, to, amount, { from: spender }); await this.token.transferFrom(initialHolder, to, amount, { from: spender });
(await this.token.allowance(owner, spender)).should.be.bignumber.equal(0); (await this.token.allowance(initialHolder, spender)).should.be.bignumber.equal('0');
}); });
it('emits a transfer event', async function () { it('emits a transfer event', async function () {
const { logs } = await this.token.transferFrom(owner, to, amount, { from: spender }); const { logs } = await this.token.transferFrom(initialHolder, to, amount, { from: spender });
expectEvent.inLogs(logs, 'Transfer', { expectEvent.inLogs(logs, 'Transfer', {
from: owner, from: initialHolder,
to: to, to: to,
value: amount, value: amount,
}); });
}); });
it('emits an approval event', async function () { it('emits an approval event', async function () {
const { logs } = await this.token.transferFrom(owner, to, amount, { from: spender }); const { logs } = await this.token.transferFrom(initialHolder, to, amount, { from: spender });
expectEvent.inLogs(logs, 'Approval', { expectEvent.inLogs(logs, 'Approval', {
owner: owner, owner: initialHolder,
spender: spender, spender: spender,
value: await this.token.allowance(owner, spender), value: await this.token.allowance(initialHolder, spender),
}); });
}); });
}); });
describe('when the owner does not have enough balance', function () { describe('when the initial holder does not have enough balance', function () {
const amount = 101; const amount = initialSupply.addn(1);
it('reverts', async function () { it('reverts', async function () {
await shouldFail.reverting(this.token.transferFrom(owner, to, amount, { from: spender })); await shouldFail.reverting(this.token.transferFrom(initialHolder, to, amount, { from: spender }));
}); });
}); });
}); });
describe('when the spender does not have enough approved balance', function () { describe('when the spender does not have enough approved balance', function () {
beforeEach(async function () { beforeEach(async function () {
await this.token.approve(spender, 99, { from: owner }); await this.token.approve(spender, initialSupply.subn(1), { from: initialHolder });
}); });
describe('when the owner has enough balance', function () { describe('when the initial holder has enough balance', function () {
const amount = 100; const amount = initialSupply;
it('reverts', async function () { it('reverts', async function () {
await shouldFail.reverting(this.token.transferFrom(owner, to, amount, { from: spender })); await shouldFail.reverting(this.token.transferFrom(initialHolder, to, amount, { from: spender }));
}); });
}); });
describe('when the owner does not have enough balance', function () { describe('when the initial holder does not have enough balance', function () {
const amount = 101; const amount = initialSupply.addn(1);
it('reverts', async function () { it('reverts', async function () {
await shouldFail.reverting(this.token.transferFrom(owner, to, amount, { from: spender })); await shouldFail.reverting(this.token.transferFrom(initialHolder, to, amount, { from: spender }));
}); });
}); });
}); });
}); });
describe('when the recipient is the zero address', function () { describe('when the recipient is the zero address', function () {
const amount = 100; const amount = initialSupply;
const to = ZERO_ADDRESS; const to = constants.ZERO_ADDRESS;
beforeEach(async function () { beforeEach(async function () {
await this.token.approve(spender, amount, { from: owner }); await this.token.approve(spender, amount, { from: initialHolder });
}); });
it('reverts', async function () { it('reverts', async function () {
await shouldFail.reverting(this.token.transferFrom(owner, to, amount, { from: spender })); await shouldFail.reverting(this.token.transferFrom(initialHolder, to, amount, { from: spender }));
}); });
}); });
}); });
@ -260,7 +257,7 @@ contract('ERC20', function ([_, owner, recipient, anotherAccount]) {
function shouldDecreaseApproval (amount) { function shouldDecreaseApproval (amount) {
describe('when there was no approved amount before', function () { describe('when there was no approved amount before', function () {
it('reverts', async function () { it('reverts', async function () {
await shouldFail.reverting(this.token.decreaseAllowance(spender, amount, { from: owner })); await shouldFail.reverting(this.token.decreaseAllowance(spender, amount, { from: initialHolder }));
}); });
}); });
@ -268,71 +265,71 @@ contract('ERC20', function ([_, owner, recipient, anotherAccount]) {
const approvedAmount = amount; const approvedAmount = amount;
beforeEach(async function () { beforeEach(async function () {
({ logs: this.logs } = await this.token.approve(spender, approvedAmount, { from: owner })); ({ logs: this.logs } = await this.token.approve(spender, approvedAmount, { from: initialHolder }));
}); });
it('emits an approval event', async function () { it('emits an approval event', async function () {
const { logs } = await this.token.decreaseAllowance(spender, approvedAmount, { from: owner }); const { logs } = await this.token.decreaseAllowance(spender, approvedAmount, { from: initialHolder });
expectEvent.inLogs(logs, 'Approval', { expectEvent.inLogs(logs, 'Approval', {
owner: owner, owner: initialHolder,
spender: spender, spender: spender,
value: 0, value: new BN(0),
}); });
}); });
it('decreases the spender allowance subtracting the requested amount', async function () { it('decreases the spender allowance subtracting the requested amount', async function () {
await this.token.decreaseAllowance(spender, approvedAmount - 1, { from: owner }); await this.token.decreaseAllowance(spender, approvedAmount.subn(1), { from: initialHolder });
(await this.token.allowance(owner, spender)).should.be.bignumber.equal(1); (await this.token.allowance(initialHolder, spender)).should.be.bignumber.equal('1');
}); });
it('sets the allowance to zero when all allowance is removed', async function () { it('sets the allowance to zero when all allowance is removed', async function () {
await this.token.decreaseAllowance(spender, approvedAmount, { from: owner }); await this.token.decreaseAllowance(spender, approvedAmount, { from: initialHolder });
(await this.token.allowance(owner, spender)).should.be.bignumber.equal(0); (await this.token.allowance(initialHolder, spender)).should.be.bignumber.equal('0');
}); });
it('reverts when more than the full allowance is removed', async function () { it('reverts when more than the full allowance is removed', async function () {
await shouldFail.reverting(this.token.decreaseAllowance(spender, approvedAmount + 1, { from: owner })); await shouldFail.reverting(this.token.decreaseAllowance(spender, approvedAmount.addn(1), { from: initialHolder }));
}); });
}); });
} }
describe('when the sender has enough balance', function () { describe('when the sender has enough balance', function () {
const amount = 100; const amount = initialSupply;
shouldDecreaseApproval(amount); shouldDecreaseApproval(amount);
}); });
describe('when the sender does not have enough balance', function () { describe('when the sender does not have enough balance', function () {
const amount = 101; const amount = initialSupply.addn(1);
shouldDecreaseApproval(amount); shouldDecreaseApproval(amount);
}); });
}); });
describe('when the spender is the zero address', function () { describe('when the spender is the zero address', function () {
const amount = 100; const amount = initialSupply;
const spender = ZERO_ADDRESS; const spender = constants.ZERO_ADDRESS;
it('reverts', async function () { it('reverts', async function () {
await shouldFail.reverting(this.token.decreaseAllowance(spender, amount, { from: owner })); await shouldFail.reverting(this.token.decreaseAllowance(spender, amount, { from: initialHolder }));
}); });
}); });
}); });
describe('increase allowance', function () { describe('increase allowance', function () {
const amount = 100; const amount = initialSupply;
describe('when the spender is not the zero address', function () { describe('when the spender is not the zero address', function () {
const spender = recipient; const spender = recipient;
describe('when the sender has enough balance', function () { describe('when the sender has enough balance', function () {
it('emits an approval event', async function () { it('emits an approval event', async function () {
const { logs } = await this.token.increaseAllowance(spender, amount, { from: owner }); const { logs } = await this.token.increaseAllowance(spender, amount, { from: initialHolder });
expectEvent.inLogs(logs, 'Approval', { expectEvent.inLogs(logs, 'Approval', {
owner: owner, owner: initialHolder,
spender: spender, spender: spender,
value: amount, value: amount,
}); });
@ -340,33 +337,33 @@ contract('ERC20', function ([_, owner, recipient, anotherAccount]) {
describe('when there was no approved amount before', function () { describe('when there was no approved amount before', function () {
it('approves the requested amount', async function () { it('approves the requested amount', async function () {
await this.token.increaseAllowance(spender, amount, { from: owner }); await this.token.increaseAllowance(spender, amount, { from: initialHolder });
(await this.token.allowance(owner, spender)).should.be.bignumber.equal(amount); (await this.token.allowance(initialHolder, spender)).should.be.bignumber.equal(amount);
}); });
}); });
describe('when the spender had an approved amount', function () { describe('when the spender had an approved amount', function () {
beforeEach(async function () { beforeEach(async function () {
await this.token.approve(spender, 1, { from: owner }); await this.token.approve(spender, new BN(1), { from: initialHolder });
}); });
it('increases the spender allowance adding the requested amount', async function () { it('increases the spender allowance adding the requested amount', async function () {
await this.token.increaseAllowance(spender, amount, { from: owner }); await this.token.increaseAllowance(spender, amount, { from: initialHolder });
(await this.token.allowance(owner, spender)).should.be.bignumber.equal(amount + 1); (await this.token.allowance(initialHolder, spender)).should.be.bignumber.equal(amount.addn(1));
}); });
}); });
}); });
describe('when the sender does not have enough balance', function () { describe('when the sender does not have enough balance', function () {
const amount = 101; const amount = initialSupply.addn(1);
it('emits an approval event', async function () { it('emits an approval event', async function () {
const { logs } = await this.token.increaseAllowance(spender, amount, { from: owner }); const { logs } = await this.token.increaseAllowance(spender, amount, { from: initialHolder });
expectEvent.inLogs(logs, 'Approval', { expectEvent.inLogs(logs, 'Approval', {
owner: owner, owner: initialHolder,
spender: spender, spender: spender,
value: amount, value: amount,
}); });
@ -374,41 +371,40 @@ contract('ERC20', function ([_, owner, recipient, anotherAccount]) {
describe('when there was no approved amount before', function () { describe('when there was no approved amount before', function () {
it('approves the requested amount', async function () { it('approves the requested amount', async function () {
await this.token.increaseAllowance(spender, amount, { from: owner }); await this.token.increaseAllowance(spender, amount, { from: initialHolder });
(await this.token.allowance(owner, spender)).should.be.bignumber.equal(amount); (await this.token.allowance(initialHolder, spender)).should.be.bignumber.equal(amount);
}); });
}); });
describe('when the spender had an approved amount', function () { describe('when the spender had an approved amount', function () {
beforeEach(async function () { beforeEach(async function () {
await this.token.approve(spender, 1, { from: owner }); await this.token.approve(spender, new BN(1), { from: initialHolder });
}); });
it('increases the spender allowance adding the requested amount', async function () { it('increases the spender allowance adding the requested amount', async function () {
await this.token.increaseAllowance(spender, amount, { from: owner }); await this.token.increaseAllowance(spender, amount, { from: initialHolder });
(await this.token.allowance(owner, spender)).should.be.bignumber.equal(amount + 1); (await this.token.allowance(initialHolder, spender)).should.be.bignumber.equal(amount.addn(1));
}); });
}); });
}); });
}); });
describe('when the spender is the zero address', function () { describe('when the spender is the zero address', function () {
const spender = ZERO_ADDRESS; const spender = constants.ZERO_ADDRESS;
it('reverts', async function () { it('reverts', async function () {
await shouldFail.reverting(this.token.increaseAllowance(spender, amount, { from: owner })); await shouldFail.reverting(this.token.increaseAllowance(spender, amount, { from: initialHolder }));
}); });
}); });
}); });
describe('_mint', function () { describe('_mint', function () {
const initialSupply = new BigNumber(100); const amount = new BN(50);
const amount = new BigNumber(50);
it('rejects a null account', async function () { it('rejects a null account', async function () {
await shouldFail.reverting(this.token.mint(ZERO_ADDRESS, amount)); await shouldFail.reverting(this.token.mint(constants.ZERO_ADDRESS, amount));
}); });
describe('for a non null account', function () { describe('for a non null account', function () {
@ -418,7 +414,7 @@ contract('ERC20', function ([_, owner, recipient, anotherAccount]) {
}); });
it('increments totalSupply', async function () { it('increments totalSupply', async function () {
const expectedSupply = initialSupply.plus(amount); const expectedSupply = initialSupply.add(amount);
(await this.token.totalSupply()).should.be.bignumber.equal(expectedSupply); (await this.token.totalSupply()).should.be.bignumber.equal(expectedSupply);
}); });
@ -428,7 +424,7 @@ contract('ERC20', function ([_, owner, recipient, anotherAccount]) {
it('emits Transfer event', async function () { it('emits Transfer event', async function () {
const event = expectEvent.inLogs(this.logs, 'Transfer', { const event = expectEvent.inLogs(this.logs, 'Transfer', {
from: ZERO_ADDRESS, from: constants.ZERO_ADDRESS,
to: recipient, to: recipient,
}); });
@ -438,38 +434,36 @@ contract('ERC20', function ([_, owner, recipient, anotherAccount]) {
}); });
describe('_burn', function () { describe('_burn', function () {
const initialSupply = new BigNumber(100);
it('rejects a null account', async function () { it('rejects a null account', async function () {
await shouldFail.reverting(this.token.burn(ZERO_ADDRESS, 1)); await shouldFail.reverting(this.token.burn(constants.ZERO_ADDRESS, new BN(1)));
}); });
describe('for a non null account', function () { describe('for a non null account', function () {
it('rejects burning more than balance', async function () { it('rejects burning more than balance', async function () {
await shouldFail.reverting(this.token.burn(owner, initialSupply.plus(1))); await shouldFail.reverting(this.token.burn(initialHolder, initialSupply.addn(1)));
}); });
const describeBurn = function (description, amount) { const describeBurn = function (description, amount) {
describe(description, function () { describe(description, function () {
beforeEach('burning', async function () { beforeEach('burning', async function () {
const { logs } = await this.token.burn(owner, amount); const { logs } = await this.token.burn(initialHolder, amount);
this.logs = logs; this.logs = logs;
}); });
it('decrements totalSupply', async function () { it('decrements totalSupply', async function () {
const expectedSupply = initialSupply.minus(amount); const expectedSupply = initialSupply.sub(amount);
(await this.token.totalSupply()).should.be.bignumber.equal(expectedSupply); (await this.token.totalSupply()).should.be.bignumber.equal(expectedSupply);
}); });
it('decrements owner balance', async function () { it('decrements initialHolder balance', async function () {
const expectedBalance = initialSupply.minus(amount); const expectedBalance = initialSupply.sub(amount);
(await this.token.balanceOf(owner)).should.be.bignumber.equal(expectedBalance); (await this.token.balanceOf(initialHolder)).should.be.bignumber.equal(expectedBalance);
}); });
it('emits Transfer event', async function () { it('emits Transfer event', async function () {
const event = expectEvent.inLogs(this.logs, 'Transfer', { const event = expectEvent.inLogs(this.logs, 'Transfer', {
from: owner, from: initialHolder,
to: ZERO_ADDRESS, to: constants.ZERO_ADDRESS,
}); });
event.args.value.should.be.bignumber.equal(amount); event.args.value.should.be.bignumber.equal(amount);
@ -478,59 +472,58 @@ contract('ERC20', function ([_, owner, recipient, anotherAccount]) {
}; };
describeBurn('for entire balance', initialSupply); describeBurn('for entire balance', initialSupply);
describeBurn('for less amount than balance', initialSupply.sub(1)); describeBurn('for less amount than balance', initialSupply.subn(1));
}); });
}); });
describe('_burnFrom', function () { describe('_burnFrom', function () {
const initialSupply = new BigNumber(100); const allowance = new BN(70);
const allowance = new BigNumber(70);
const spender = anotherAccount; const spender = anotherAccount;
beforeEach('approving', async function () { beforeEach('approving', async function () {
await this.token.approve(spender, allowance, { from: owner }); await this.token.approve(spender, allowance, { from: initialHolder });
}); });
it('rejects a null account', async function () { it('rejects a null account', async function () {
await shouldFail.reverting(this.token.burnFrom(ZERO_ADDRESS, 1)); await shouldFail.reverting(this.token.burnFrom(constants.ZERO_ADDRESS, new BN(1)));
}); });
describe('for a non null account', function () { describe('for a non null account', function () {
it('rejects burning more than allowance', async function () { it('rejects burning more than allowance', async function () {
await shouldFail.reverting(this.token.burnFrom(owner, allowance.plus(1))); await shouldFail.reverting(this.token.burnFrom(initialHolder, allowance.addn(1)));
}); });
it('rejects burning more than balance', async function () { it('rejects burning more than balance', async function () {
await shouldFail.reverting(this.token.burnFrom(owner, initialSupply.plus(1))); await shouldFail.reverting(this.token.burnFrom(initialHolder, initialSupply.addn(1)));
}); });
const describeBurnFrom = function (description, amount) { const describeBurnFrom = function (description, amount) {
describe(description, function () { describe(description, function () {
beforeEach('burning', async function () { beforeEach('burning', async function () {
const { logs } = await this.token.burnFrom(owner, amount, { from: spender }); const { logs } = await this.token.burnFrom(initialHolder, amount, { from: spender });
this.logs = logs; this.logs = logs;
}); });
it('decrements totalSupply', async function () { it('decrements totalSupply', async function () {
const expectedSupply = initialSupply.minus(amount); const expectedSupply = initialSupply.sub(amount);
(await this.token.totalSupply()).should.be.bignumber.equal(expectedSupply); (await this.token.totalSupply()).should.be.bignumber.equal(expectedSupply);
}); });
it('decrements owner balance', async function () { it('decrements initialHolder balance', async function () {
const expectedBalance = initialSupply.minus(amount); const expectedBalance = initialSupply.sub(amount);
(await this.token.balanceOf(owner)).should.be.bignumber.equal(expectedBalance); (await this.token.balanceOf(initialHolder)).should.be.bignumber.equal(expectedBalance);
}); });
it('decrements spender allowance', async function () { it('decrements spender allowance', async function () {
const expectedAllowance = allowance.minus(amount); const expectedAllowance = allowance.sub(amount);
(await this.token.allowance(owner, spender)).should.be.bignumber.equal(expectedAllowance); (await this.token.allowance(initialHolder, spender)).should.be.bignumber.equal(expectedAllowance);
}); });
it('emits a Transfer event', async function () { it('emits a Transfer event', async function () {
const event = expectEvent.inLogs(this.logs, 'Transfer', { const event = expectEvent.inLogs(this.logs, 'Transfer', {
from: owner, from: initialHolder,
to: ZERO_ADDRESS, to: constants.ZERO_ADDRESS,
}); });
event.args.value.should.be.bignumber.equal(amount); event.args.value.should.be.bignumber.equal(amount);
@ -538,16 +531,16 @@ contract('ERC20', function ([_, owner, recipient, anotherAccount]) {
it('emits an Approval event', async function () { it('emits an Approval event', async function () {
expectEvent.inLogs(this.logs, 'Approval', { expectEvent.inLogs(this.logs, 'Approval', {
owner: owner, owner: initialHolder,
spender: spender, spender: spender,
value: await this.token.allowance(owner, spender), value: await this.token.allowance(initialHolder, spender),
}); });
}); });
}); });
}; };
describeBurnFrom('for entire allowance', allowance); describeBurnFrom('for entire allowance', allowance);
describeBurnFrom('for less amount than allowance', allowance.sub(1)); describeBurnFrom('for less amount than allowance', allowance.subn(1));
}); });
}); });
}); });