Check proof length multiple of 32. Use keccak256 instead of sha3

This commit is contained in:
Yondon Fu
2017-07-28 10:38:32 -04:00
parent bc3db5d4c1
commit 863ad48a81
2 changed files with 25 additions and 5 deletions

View File

@ -26,18 +26,35 @@ contract('MerkleProof', function(accounts) {
});
it("should return false for an invalid Merkle proof", async function() {
const correctElements = ["a", "b", "c"].map(el => sha3(el));
const correctMerkleTree = new MerkleTree(correctElements);
const correctRoot = correctMerkleTree.getHexRoot();
const correctLeaf = correctMerkleTree.bufToHex(correctElements[0]);
const badElements = ["d", "e", "f"].map(el => sha3(el))
const badMerkleTree = new MerkleTree(badElements)
const badProof = badMerkleTree.getHexProof(badElements[0])
const result = await merkleProof.verifyProof(badProof, correctRoot, correctLeaf);
assert.isNotOk(result, "verifyProof did not return false for an invalid proof");
});
it("should return false for a Merkle proof of invalid length", async function() {
const elements = ["a", "b", "c"].map(el => sha3(el));
const merkleTree = new MerkleTree(elements);
const root = merkleTree.getHexRoot();
const proof = merkleTree.getHexProof(elements[0]);
const badProof = proof.slice(0, proof.length - 32);
const badProof = proof.slice(0, proof.length - 5);
const leaf = merkleTree.bufToHex(elements[0]);
const result = await merkleProof.verifyProof(badProof, root, leaf);
assert.isNotOk(result, "verifyProof did not return false for an invalid proof");
});
assert.isNotOk(result, "verifyProof did not return false for proof of invalid length");
})
});
});