NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed a broken payment test (+ another small fix) (#1318)

Browse Source 
* Fixed a broken payment test

* In PR template, npm run lint:fix, not lint:all:fix

* In SplitPayment test, replaced an await-in-loop with Promise.all

(cherry picked from commit b79196f911)
This commit is contained in:
dwardu
2018-09-11 17:32:05 +02:00
committed by Francisco Giordano
parent 08bf6bbed9
commit 76169cda40
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.github/PULL_REQUEST_TEMPLATE.md vendored
View File

@ -14,4 +14,4 @@ Fixes #
- [ ] 📘 I've reviewed the [OpenZeppelin Contributor Guidelines](../blob/master/CONTRIBUTING.md) - [ ] 📘 I've reviewed the [OpenZeppelin Contributor Guidelines](../blob/master/CONTRIBUTING.md)
- [ ] ✅ I've added tests where applicable to test my new functionality. - [ ] ✅ I've added tests where applicable to test my new functionality.
- [ ] 📖 I've made sure that my contracts are well-documented. - [ ] 📖 I've made sure that my contracts are well-documented.
- [ ] 🎨 I've run the JS/Solidity linters and fixed any issues (`npm run lint:all:fix`). - [ ] 🎨 I've run the JS/Solidity linters and fixed any issues (`npm run lint:fix`).

6
test/payment/SplitPayment.test.js
View File

@ -51,10 +51,10 @@ contract('SplitPayment', function ([_, owner, payee1, payee2, payee3, nonpayee1,
}); });
it('should have payees', async function () { it('should have payees', async function () {
this.payees.forEach(async (payee, index) => { await Promise.all(this.payees.map(async (payee, index) => {
(await this.payee(index)).should.be.equal(payee); (await this.contract.payee(index)).should.be.equal(payee);
(await this.contract.released(payee)).should.be.bignumber.equal(0); (await this.contract.released(payee)).should.be.bignumber.equal(0);
}); }));
}); });
it('should accept payments', async function () { it('should accept payments', async function () {