From 74db6c2b3b2d52705b034b713c5efb5dbaced570 Mon Sep 17 00:00:00 2001 From: Francisco Giordano Date: Mon, 28 Aug 2017 19:17:49 -0300 Subject: [PATCH] add missing test for error when doing transferFrom to 0x0 --- test/BasicToken.js | 6 +++--- test/StandardToken.js | 15 +++++++++++++-- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/test/BasicToken.js b/test/BasicToken.js index 76248948a..e5bb46868 100644 --- a/test/BasicToken.js +++ b/test/BasicToken.js @@ -22,7 +22,7 @@ contract('BasicToken', function(accounts) { assert.equal(secondAccountBalance, 100); }); - it("should throw an error when trying to transfer more than balance", async function() { + it('should throw an error when trying to transfer more than balance', async function() { let token = await BasicTokenMock.new(accounts[0], 100); try { let transfer = await token.transfer(accounts[1], 101); @@ -32,14 +32,14 @@ contract('BasicToken', function(accounts) { } }); - it("should throw an error when trying to transfer to 0x0", async function() { + it('should throw an error when trying to transfer to 0x0', async function() { let token = await StandardTokenMock.new(accounts[0], 100); try { let transfer = await token.transfer(0x0, 100); assert.fail('should have thrown before'); } catch(error) { assertJump(error); - } + } }); }); diff --git a/test/StandardToken.js b/test/StandardToken.js index acf53c31e..cb4e9b038 100644 --- a/test/StandardToken.js +++ b/test/StandardToken.js @@ -88,14 +88,25 @@ contract('StandardToken', function(accounts) { }) }); - it("should throw an error when trying to transfer to 0x0", async function() { + it('should throw an error when trying to transfer to 0x0', async function() { let token = await StandardTokenMock.new(accounts[0], 100); try { let transfer = await token.transfer(0x0, 100); assert.fail('should have thrown before'); } catch(error) { assertJump(error); - } + } + }); + + it('should throw an error when trying to transferFrom to 0x0', async function() { + let token = await StandardTokenMock.new(accounts[0], 100); + await token.approve(accounts[1], 100); + try { + let transfer = await token.transferFrom(accounts[0], 0x0, 100, {from: accounts[1]}); + assert.fail('should have thrown before'); + } catch(error) { + assertJump(error); + } }); });