Make ERC4626 _deposit and _withdraw internal virtual (#3504)
This commit is contained in:
@ -175,7 +175,7 @@ abstract contract ERC4626 is ERC20, IERC4626 {
|
||||
address receiver,
|
||||
uint256 assets,
|
||||
uint256 shares
|
||||
) private {
|
||||
) internal virtual {
|
||||
// If _asset is ERC777, `transferFrom` can trigger a reenterancy BEFORE the transfer happens through the
|
||||
// `tokensToSend` hook. On the other hand, the `tokenReceived` hook, that is triggered after the transfer,
|
||||
// calls the vault, which is assumed not malicious.
|
||||
@ -198,7 +198,7 @@ abstract contract ERC4626 is ERC20, IERC4626 {
|
||||
address owner,
|
||||
uint256 assets,
|
||||
uint256 shares
|
||||
) private {
|
||||
) internal virtual {
|
||||
if (caller != owner) {
|
||||
_spendAllowance(owner, caller, shares);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user