NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

remove token.finishMinting() from default finalization

Browse Source
This commit is contained in:
Francisco Giordano
2017-08-12 21:33:32 -03:00
parent e6a7a978d1
commit 4fc6bb7977
2 changed files with 9 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
contracts/crowdsale/FinalizableCrowdsale.sol
View File

@ -16,8 +16,10 @@ contract FinalizableCrowdsale is Crowdsale, Ownable {
event Finalized(); event Finalized();
// should be called after crowdsale ends, to do /**
// some extra finalization work * @dev Must be called after crowdsale ends, to do some extra finalization
* work. Calls the contract's finalization function.
*/
function finalize() onlyOwner { function finalize() onlyOwner {
require(!isFinalized); require(!isFinalized);
require(hasEnded()); require(hasEnded());
@ -28,12 +30,11 @@ contract FinalizableCrowdsale is Crowdsale, Ownable {
isFinalized = true; isFinalized = true;
} }
// end token minting on finalization /**
// override this with custom logic if needed * @dev Can be overriden to add finalization logic. The overriding function
* should call super.finalization() to ensure the chain of finalization is
* executed entirely.
*/
function finalization() internal { function finalization() internal {
token.finishMinting();
} }
} }

7
test/FinalizableCrowdsale.js
View File

@ -60,11 +60,4 @@ contract('FinalizableCrowdsale', function ([_, owner, wallet, thirdparty]) {
should.exist(event) should.exist(event)
}) })
it('finishes minting of token', async function () {
await increaseTimeTo(this.afterEndTime)
await this.crowdsale.finalize({from: owner})
const finished = await this.token.mintingFinished()
finished.should.equal(true)
})
}) })