NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Minor test style improvements (#1219)

Browse Source 
* Changed .eq to .equal

* Changed equal(bool) to .to.be.bool

* Changed be.bool to equal(bool), disallowed unused expressions.
This commit is contained in:
Nicolás Venturo
2018-08-22 16:05:18 -03:00
committed by GitHub
parent 64c324e37c
commit 4fb9bb7020
33 changed files with 109 additions and 114 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
test/library/ECRecovery.test.js
View File

@ -20,7 +20,7 @@ contract('ECRecovery', function ([_, anyone]) {
const message = web3.sha3(TEST_MESSAGE);
// eslint-disable-next-line max-len
const signature = '0x5d99b6f7f6d1f73d1a26497f2b1c89b24c0993913f86e9a2d02cd69887d9c94f3c880358579d811b21dd1b7fd9bb01c1d81d10e69f0384e675c32b39643be89200';
(await ecrecovery.recover(message, signature)).should.eq(signer);
(await ecrecovery.recover(message, signature)).should.equal(signer);
});
it('recover v1', async function () {
@ -29,7 +29,7 @@ contract('ECRecovery', function ([_, anyone]) {
const message = web3.sha3(TEST_MESSAGE);
// eslint-disable-next-line max-len
const signature = '0x331fe75a821c982f9127538858900d87d3ec1f9f737338ad67cad133fa48feff48e6fa0c18abc62e42820f05943e47af3e9fbe306ce74d64094bdf1691ee53e001';
(await ecrecovery.recover(message, signature)).should.eq(signer);
(await ecrecovery.recover(message, signature)).should.equal(signer);
});
it('recover using web3.eth.sign()', async function () {
@ -40,7 +40,7 @@ contract('ECRecovery', function ([_, anyone]) {
(await ecrecovery.recover(
hashMessage(TEST_MESSAGE),
signature
)).should.eq(anyone);
)).should.equal(anyone);
});
it('recover using web3.eth.sign() should return wrong signer', async function () {
@ -48,7 +48,7 @@ contract('ECRecovery', function ([_, anyone]) {
const signature = signMessage(anyone, web3.sha3(TEST_MESSAGE));
// Recover the signer address from the generated message and wrong signature.
(await ecrecovery.recover(hashMessage('Nope'), signature)).should.not.eq(anyone);
(await ecrecovery.recover(hashMessage('Nope'), signature)).should.not.equal(anyone);
});
it('recover should revert when a small hash is sent', async function () {
@ -66,7 +66,7 @@ contract('ECRecovery', function ([_, anyone]) {
context('toEthSignedMessage', function () {
it('should prefix hashes correctly', async function () {
const hashedMessage = web3.sha3(TEST_MESSAGE);
(await ecrecovery.toEthSignedMessageHash(hashedMessage)).should.eq(hashMessage(TEST_MESSAGE));
(await ecrecovery.toEthSignedMessageHash(hashedMessage)).should.equal(hashMessage(TEST_MESSAGE));
});
});
});