NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

added explicit visibility (#1261)

Browse Source
This commit is contained in:
Vyom Sharma
2018-09-01 06:43:39 +05:30
committed by Leo Arias
parent 2e0713becb
commit 4385fd5a23
5 changed files with 16 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
contracts/access/SignatureBouncer.sol
View File

@ -33,9 +33,9 @@ contract SignatureBouncer is Ownable, RBAC {
using ECRecovery for bytes32;
string public constant ROLE_BOUNCER = "bouncer";
uint constant METHOD_ID_SIZE = 4;
uint internal constant METHOD_ID_SIZE = 4;
// signature size is 65 bytes (tightly packed v + r + s), but gets padded to 96 bytes
uint constant SIGNATURE_SIZE = 96;
uint internal constant SIGNATURE_SIZE = 96;
/**
* @dev requires that a valid signature of a bouncer was provided

4
contracts/mocks/ERC721ReceiverMock.sol
View File

@ -4,8 +4,8 @@ import "../token/ERC721/IERC721Receiver.sol";
contract ERC721ReceiverMock is IERC721Receiver {
bytes4 retval_;
bool reverts_;
bytes4 internal retval_;
bool internal reverts_;
event Received(
address _operator,

2
contracts/mocks/RBACMock.sol
View File

@ -5,7 +5,7 @@ import "../examples/RBACWithAdmin.sol";
contract RBACMock is RBACWithAdmin {
string constant ROLE_ADVISOR = "advisor";
string internal constant ROLE_ADVISOR = "advisor";
modifier onlyAdminOrAdvisor()
{

20
contracts/mocks/SafeERC20Helper.sol
View File

@ -61,35 +61,35 @@ contract ERC20SucceedingMock is IERC20 {
contract SafeERC20Helper {
using SafeERC20 for IERC20;
IERC20 failing;
IERC20 succeeding;
IERC20 internal failing_;
IERC20 internal succeeding_;
constructor() public {
failing = new ERC20FailingMock();
succeeding = new ERC20SucceedingMock();
failing_ = new ERC20FailingMock();
succeeding_ = new ERC20SucceedingMock();
}
function doFailingTransfer() public {
failing.safeTransfer(address(0), 0);
failing_.safeTransfer(address(0), 0);
}
function doFailingTransferFrom() public {
failing.safeTransferFrom(address(0), address(0), 0);
failing_.safeTransferFrom(address(0), address(0), 0);
}
function doFailingApprove() public {
failing.safeApprove(address(0), 0);
failing_.safeApprove(address(0), 0);
}
function doSucceedingTransfer() public {
succeeding.safeTransfer(address(0), 0);
succeeding_.safeTransfer(address(0), 0);
}
function doSucceedingTransferFrom() public {
succeeding.safeTransferFrom(address(0), address(0), 0);
succeeding_.safeTransferFrom(address(0), address(0), 0);
}
function doSucceedingApprove() public {
succeeding.safeApprove(address(0), 0);
succeeding_.safeApprove(address(0), 0);
}
}