Revert on useless operations.

This commit is contained in:
Alberto Cuesta Cañada
2020-01-23 20:43:57 +00:00
parent dfdf794e3c
commit 41cb935930
2 changed files with 22 additions and 9 deletions

View File

@ -33,9 +33,8 @@ library EnumerableSet {
function add(AddressSet storage set, address value)
internal
{
if (!contains(set, value)){
set.index[value] = set.values.push(value);
}
require(!contains(set, value), "EnumerableSet: value already in set");
set.index[value] = set.values.push(value);
}
/**
@ -44,11 +43,10 @@ library EnumerableSet {
function remove(AddressSet storage set, address value)
internal
{
if (contains(set, value)) {
set.values[set.index[value] - 1] = set.values[set.values.length - 1];
set.values.pop();
delete set.index[value];
}
require(contains(set, value), "EnumerableSet: value not in set");
set.values[set.index[value] - 1] = set.values[set.values.length - 1];
set.values.pop();
delete set.index[value];
}
/**