add more openzeppelin-solidity library contracts

test/library/ECRecovery.test.js

@@ -0,0 +1,77 @@
+
+import {
+  hashMessage,
+  signMessage,
+} from '../helpers/sign';
+const ECRecoveryMock = artifacts.require('ECRecoveryMock');
+
+require('chai')
+  .use(require('chai-as-promised'))
+  .should();
+
+contract('ECRecovery', function (accounts) {
+  let ecrecovery;
+  const TEST_MESSAGE = 'OpenZeppelin';
+
+  before(async function () {
+    ecrecovery = await ECRecoveryMock.new();
+  });
+
+  it('recover v0', async function () {
+    // Signature generated outside ganache with method web3.eth.sign(signer, message)
+    let signer = '0x2cc1166f6212628a0deef2b33befb2187d35b86c';
+    let message = web3.sha3(TEST_MESSAGE);
+    // eslint-disable-next-line max-len
+    let signature = '0x5d99b6f7f6d1f73d1a26497f2b1c89b24c0993913f86e9a2d02cd69887d9c94f3c880358579d811b21dd1b7fd9bb01c1d81d10e69f0384e675c32b39643be89200';
+    const addrRecovered = await ecrecovery.recover(message, signature);
+    addrRecovered.should.eq(signer);
+  });
+
+  it('recover v1', async function () {
+    // Signature generated outside ganache with method web3.eth.sign(signer, message)
+    let signer = '0x1e318623ab09fe6de3c9b8672098464aeda9100e';
+    let message = web3.sha3(TEST_MESSAGE);
+    // eslint-disable-next-line max-len
+    let signature = '0x331fe75a821c982f9127538858900d87d3ec1f9f737338ad67cad133fa48feff48e6fa0c18abc62e42820f05943e47af3e9fbe306ce74d64094bdf1691ee53e001';
+    const addrRecovered = await ecrecovery.recover(message, signature);
+    addrRecovered.should.eq(signer);
+  });
+
+  it('recover using web3.eth.sign()', async function () {
+    // Create the signature using account[0]
+    const signature = signMessage(accounts[0], TEST_MESSAGE);
+
+    // Recover the signer address from the generated message and signature.
+    const addrRecovered = await ecrecovery.recover(
+      hashMessage(TEST_MESSAGE),
+      signature
+    );
+    addrRecovered.should.eq(accounts[0]);
+  });
+
+  it('recover using web3.eth.sign() should return wrong signer', async function () {
+    // Create the signature using account[0]
+    const signature = signMessage(accounts[0], TEST_MESSAGE);
+
+    // Recover the signer address from the generated message and wrong signature.
+    const addrRecovered = await ecrecovery.recover(hashMessage('Test'), signature);
+    assert.notEqual(accounts[0], addrRecovered);
+  });
+
+  it('recover should fail when a wrong hash is sent', async function () {
+    // Create the signature using account[0]
+    let signature = signMessage(accounts[0], TEST_MESSAGE);
+
+    // Recover the signer address from the generated message and wrong signature.
+    const addrRecovered = await ecrecovery.recover(hashMessage(TEST_MESSAGE).substring(2), signature);
+    addrRecovered.should.eq('0x0000000000000000000000000000000000000000');
+  });
+
+  context('toEthSignedMessage', () => {
+    it('should prefix hashes correctly', async function () {
+      const hashedMessage = web3.sha3(TEST_MESSAGE);
+      const ethMessage = await ecrecovery.toEthSignedMessageHash(hashedMessage);
+      ethMessage.should.eq(hashMessage(TEST_MESSAGE));
+    });
+  });
+});

test/library/Math.test.js

@@ -0,0 +1,43 @@
+var MathMock = artifacts.require('MathMock');
+
+contract('Math', function (accounts) {
+  let math;
+
+  before(async function () {
+    math = await MathMock.new();
+  });
+
+  it('returns max64 correctly', async function () {
+    let a = 5678;
+    let b = 1234;
+    await math.max64(a, b);
+    let result = await math.result64();
+    assert.equal(result, a);
+  });
+
+  it('returns min64 correctly', async function () {
+    let a = 5678;
+    let b = 1234;
+    await math.min64(a, b);
+    let result = await math.result64();
+
+    assert.equal(result, b);
+  });
+
+  it('returns max256 correctly', async function () {
+    let a = 5678;
+    let b = 1234;
+    await math.max256(a, b);
+    let result = await math.result256();
+    assert.equal(result, a);
+  });
+
+  it('returns min256 correctly', async function () {
+    let a = 5678;
+    let b = 1234;
+    await math.min256(a, b);
+    let result = await math.result256();
+
+    assert.equal(result, b);
+  });
+});

test/library/MerkleProof.test.js

@@ -0,0 +1,61 @@
+
+import MerkleTree from '../helpers/merkleTree.js';
+import { sha3, bufferToHex } from 'ethereumjs-util';
+
+var MerkleProofWrapper = artifacts.require('MerkleProofWrapper');
+
+contract('MerkleProof', function (accounts) {
+  let merkleProof;
+
+  before(async function () {
+    merkleProof = await MerkleProofWrapper.new();
+  });
+
+  describe('verifyProof', function () {
+    it('should return true for a valid Merkle proof', async function () {
+      const elements = ['a', 'b', 'c', 'd'];
+      const merkleTree = new MerkleTree(elements);
+
+      const root = merkleTree.getHexRoot();
+
+      const proof = merkleTree.getHexProof(elements[0]);
+
+      const leaf = bufferToHex(sha3(elements[0]));
+
+      const result = await merkleProof.verifyProof(proof, root, leaf);
+      assert.isOk(result, 'verifyProof did not return true for a valid proof');
+    });
+
+    it('should return false for an invalid Merkle proof', async function () {
+      const correctElements = ['a', 'b', 'c'];
+      const correctMerkleTree = new MerkleTree(correctElements);
+
+      const correctRoot = correctMerkleTree.getHexRoot();
+
+      const correctLeaf = bufferToHex(sha3(correctElements[0]));
+
+      const badElements = ['d', 'e', 'f'];
+      const badMerkleTree = new MerkleTree(badElements);
+
+      const badProof = badMerkleTree.getHexProof(badElements[0]);
+
+      const result = await merkleProof.verifyProof(badProof, correctRoot, correctLeaf);
+      assert.isNotOk(result, 'verifyProof did not return false for an invalid proof');
+    });
+
+    it('should return false for a Merkle proof of invalid length', async function () {
+      const elements = ['a', 'b', 'c'];
+      const merkleTree = new MerkleTree(elements);
+
+      const root = merkleTree.getHexRoot();
+
+      const proof = merkleTree.getHexProof(elements[0]);
+      const badProof = proof.slice(0, proof.length - 5);
+
+      const leaf = bufferToHex(sha3(elements[0]));
+
+      const result = await merkleProof.verifyProof(badProof, root, leaf);
+      assert.isNotOk(result, 'verifyProof did not return false for proof of invalid length');
+    });
+  });
+});

test/ownership/rbac/RBAC.test.js

@@ -0,0 +1,98 @@
+import expectThrow from '../../helpers/expectThrow';
+import expectEvent from '../../helpers/expectEvent';
+
+const RBACMock = artifacts.require('RBACMock');
+
+require('chai')
+  .use(require('chai-as-promised'))
+  .should();
+
+const ROLE_ADVISOR = 'advisor';
+
+contract('RBAC', function (accounts) {
+  let mock;
+
+  const [
+    admin,
+    anyone,
+    futureAdvisor,
+    ...advisors
+  ] = accounts;
+
+  before(async () => {
+    mock = await RBACMock.new(advisors, { from: admin });
+  });
+
+  context('in normal conditions', () => {
+    it('allows admin to call #onlyAdminsCanDoThis', async () => {
+      await mock.onlyAdminsCanDoThis({ from: admin })
+        .should.be.fulfilled;
+    });
+    it('allows admin to call #onlyAdvisorsCanDoThis', async () => {
+      await mock.onlyAdvisorsCanDoThis({ from: admin })
+        .should.be.fulfilled;
+    });
+    it('allows advisors to call #onlyAdvisorsCanDoThis', async () => {
+      await mock.onlyAdvisorsCanDoThis({ from: advisors[0] })
+        .should.be.fulfilled;
+    });
+    it('allows admin to call #eitherAdminOrAdvisorCanDoThis', async () => {
+      await mock.eitherAdminOrAdvisorCanDoThis({ from: admin })
+        .should.be.fulfilled;
+    });
+    it('allows advisors to call #eitherAdminOrAdvisorCanDoThis', async () => {
+      await mock.eitherAdminOrAdvisorCanDoThis({ from: advisors[0] })
+        .should.be.fulfilled;
+    });
+    it('does not allow admins to call #nobodyCanDoThis', async () => {
+      await expectThrow(
+        mock.nobodyCanDoThis({ from: admin })
+      );
+    });
+    it('does not allow advisors to call #nobodyCanDoThis', async () => {
+      await expectThrow(
+        mock.nobodyCanDoThis({ from: advisors[0] })
+      );
+    });
+    it('does not allow anyone to call #nobodyCanDoThis', async () => {
+      await expectThrow(
+        mock.nobodyCanDoThis({ from: anyone })
+      );
+    });
+    it('allows an admin to remove an advisor\'s role', async () => {
+      await mock.removeAdvisor(advisors[0], { from: admin })
+        .should.be.fulfilled;
+    });
+    it('allows admins to #adminRemoveRole', async () => {
+      await mock.adminRemoveRole(advisors[3], ROLE_ADVISOR, { from: admin })
+        .should.be.fulfilled;
+    });
+
+    it('announces a RoleAdded event on addRole', async () => {
+      await expectEvent.inTransaction(
+        mock.adminAddRole(futureAdvisor, ROLE_ADVISOR, { from: admin }),
+        'RoleAdded'
+      );
+    });
+
+    it('announces a RoleRemoved event on removeRole', async () => {
+      await expectEvent.inTransaction(
+        mock.adminRemoveRole(futureAdvisor, ROLE_ADVISOR, { from: admin }),
+        'RoleRemoved'
+      );
+    });
+  });
+
+  context('in adversarial conditions', () => {
+    it('does not allow an advisor to remove another advisor', async () => {
+      await expectThrow(
+        mock.removeAdvisor(advisors[1], { from: advisors[0] })
+      );
+    });
+    it('does not allow "anyone" to remove an advisor', async () => {
+      await expectThrow(
+        mock.removeAdvisor(advisors[0], { from: anyone })
+      );
+    });
+  });
+});

test/payment/PullPayment.test.js

@@ -0,0 +1,71 @@
+var PullPaymentMock = artifacts.require('PullPaymentMock');
+
+contract('PullPayment', function (accounts) {
+  let ppce;
+  let amount = 17 * 1e18;
+
+  beforeEach(async function () {
+    ppce = await PullPaymentMock.new({ value: amount });
+  });
+
+  it('can\'t call asyncSend externally', async function () {
+    assert.isUndefined(ppce.asyncSend);
+  });
+
+  it('can record an async payment correctly', async function () {
+    let AMOUNT = 100;
+    await ppce.callSend(accounts[0], AMOUNT);
+    let paymentsToAccount0 = await ppce.payments(accounts[0]);
+    let totalPayments = await ppce.totalPayments();
+
+    assert.equal(totalPayments, AMOUNT);
+    assert.equal(paymentsToAccount0, AMOUNT);
+  });
+
+  it('can add multiple balances on one account', async function () {
+    await ppce.callSend(accounts[0], 200);
+    await ppce.callSend(accounts[0], 300);
+    let paymentsToAccount0 = await ppce.payments(accounts[0]);
+    let totalPayments = await ppce.totalPayments();
+
+    assert.equal(totalPayments, 500);
+    assert.equal(paymentsToAccount0, 500);
+  });
+
+  it('can add balances on multiple accounts', async function () {
+    await ppce.callSend(accounts[0], 200);
+    await ppce.callSend(accounts[1], 300);
+
+    let paymentsToAccount0 = await ppce.payments(accounts[0]);
+    assert.equal(paymentsToAccount0, 200);
+
+    let paymentsToAccount1 = await ppce.payments(accounts[1]);
+    assert.equal(paymentsToAccount1, 300);
+
+    let totalPayments = await ppce.totalPayments();
+    assert.equal(totalPayments, 500);
+  });
+
+  it('can withdraw payment', async function () {
+    let payee = accounts[1];
+    let initialBalance = web3.eth.getBalance(payee);
+
+    await ppce.callSend(payee, amount);
+
+    let payment1 = await ppce.payments(payee);
+    assert.equal(payment1, amount);
+
+    let totalPayments = await ppce.totalPayments();
+    assert.equal(totalPayments, amount);
+
+    await ppce.withdrawPayments({ from: payee });
+    let payment2 = await ppce.payments(payee);
+    assert.equal(payment2, 0);
+
+    totalPayments = await ppce.totalPayments();
+    assert.equal(totalPayments, 0);
+
+    let balance = web3.eth.getBalance(payee);
+    assert(Math.abs(balance - initialBalance - amount) < 1e16);
+  });
+});