Adding RBAC Mintable token (#923)
* added the RBACMintableToken * added MintedCrowdsale with RBACMintableToken test * added a mintable behaviour for tests * moved minting tests in behaviour * created a minted crowdsale behaviour to be tested with both mintable and rbacmintable token
This commit is contained in:
Vittorio Minacori
committed by
Matt Condon
Matt Condon
parent
ad12381549
commit
39370ff690
148
test/token/ERC20/MintableToken.behaviour.js
Normal file
148
test/token/ERC20/MintableToken.behaviour.js
Normal file
@ -0,0 +1,148 @@
|
||||
import assertRevert from '../../helpers/assertRevert';
|
||||
|
||||
const BigNumber = web3.BigNumber;
|
||||
|
||||
require('chai')
|
||||
.use(require('chai-as-promised'))
|
||||
.use(require('chai-bignumber')(BigNumber))
|
||||
.should();
|
||||
|
||||
export default function ([owner, anotherAccount, minter]) {
|
||||
describe('as a basic mintable token', function () {
|
||||
describe('after token creation', function () {
|
||||
it('sender should be token owner', async function () {
|
||||
const tokenOwner = await this.token.owner({ from: owner });
|
||||
tokenOwner.should.equal(owner);
|
||||
});
|
||||
});
|
||||
|
||||
describe('minting finished', function () {
|
||||
describe('when the token minting is not finished', function () {
|
||||
it('returns false', async function () {
|
||||
const mintingFinished = await this.token.mintingFinished();
|
||||
assert.equal(mintingFinished, false);
|
||||
});
|
||||
});
|
||||
|
||||
describe('when the token is minting finished', function () {
|
||||
beforeEach(async function () {
|
||||
await this.token.finishMinting({ from: owner });
|
||||
});
|
||||
|
||||
it('returns true', async function () {
|
||||
const mintingFinished = await this.token.mintingFinished();
|
||||
assert.equal(mintingFinished, true);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe('finish minting', function () {
|
||||
describe('when the sender is the token owner', function () {
|
||||
const from = owner;
|
||||
|
||||
describe('when the token minting was not finished', function () {
|
||||
it('finishes token minting', async function () {
|
||||
await this.token.finishMinting({ from });
|
||||
|
||||
const mintingFinished = await this.token.mintingFinished();
|
||||
assert.equal(mintingFinished, true);
|
||||
});
|
||||
|
||||
it('emits a mint finished event', async function () {
|
||||
const { logs } = await this.token.finishMinting({ from });
|
||||
|
||||
assert.equal(logs.length, 1);
|
||||
assert.equal(logs[0].event, 'MintFinished');
|
||||
});
|
||||
});
|
||||
|
||||
describe('when the token minting was already finished', function () {
|
||||
beforeEach(async function () {
|
||||
await this.token.finishMinting({ from });
|
||||
});
|
||||
|
||||
it('reverts', async function () {
|
||||
await assertRevert(this.token.finishMinting({ from }));
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe('when the sender is not the token owner', function () {
|
||||
const from = anotherAccount;
|
||||
|
||||
describe('when the token minting was not finished', function () {
|
||||
it('reverts', async function () {
|
||||
await assertRevert(this.token.finishMinting({ from }));
|
||||
});
|
||||
});
|
||||
|
||||
describe('when the token minting was already finished', function () {
|
||||
beforeEach(async function () {
|
||||
await this.token.finishMinting({ from: owner });
|
||||
});
|
||||
|
||||
it('reverts', async function () {
|
||||
await assertRevert(this.token.finishMinting({ from }));
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe('mint', function () {
|
||||
const amount = 100;
|
||||
|
||||
describe('when the sender has the minting permission', function () {
|
||||
const from = minter;
|
||||
|
||||
describe('when the token minting is not finished', function () {
|
||||
it('mints the requested amount', async function () {
|
||||
await this.token.mint(owner, amount, { from });
|
||||
|
||||
const balance = await this.token.balanceOf(owner);
|
||||
assert.equal(balance, amount);
|
||||
});
|
||||
|
||||
it('emits a mint and a transfer event', async function () {
|
||||
const { logs } = await this.token.mint(owner, amount, { from });
|
||||
|
||||
assert.equal(logs.length, 2);
|
||||
assert.equal(logs[0].event, 'Mint');
|
||||
assert.equal(logs[0].args.to, owner);
|
||||
assert.equal(logs[0].args.amount, amount);
|
||||
assert.equal(logs[1].event, 'Transfer');
|
||||
});
|
||||
});
|
||||
|
||||
describe('when the token minting is finished', function () {
|
||||
beforeEach(async function () {
|
||||
await this.token.finishMinting({ from: owner });
|
||||
});
|
||||
|
||||
it('reverts', async function () {
|
||||
await assertRevert(this.token.mint(owner, amount, { from }));
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe('when the sender has not the minting permission', function () {
|
||||
const from = anotherAccount;
|
||||
|
||||
describe('when the token minting is not finished', function () {
|
||||
it('reverts', async function () {
|
||||
await assertRevert(this.token.mint(owner, amount, { from }));
|
||||
});
|
||||
});
|
||||
|
||||
describe('when the token minting is already finished', function () {
|
||||
beforeEach(async function () {
|
||||
await this.token.finishMinting({ from: owner });
|
||||
});
|
||||
|
||||
it('reverts', async function () {
|
||||
await assertRevert(this.token.mint(owner, amount, { from }));
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
};
|
||||
@ -1,137 +1,12 @@
|
||||
import assertRevert from '../../helpers/assertRevert';
|
||||
import shouldBehaveLikeMintableToken from './MintableToken.behaviour';
|
||||
const MintableToken = artifacts.require('MintableToken');
|
||||
|
||||
contract('Mintable', function ([owner, anotherAccount]) {
|
||||
contract('MintableToken', function ([owner, anotherAccount]) {
|
||||
const minter = owner;
|
||||
|
||||
beforeEach(async function () {
|
||||
this.token = await MintableToken.new({ from: owner });
|
||||
});
|
||||
|
||||
describe('minting finished', function () {
|
||||
describe('when the token is not finished', function () {
|
||||
it('returns false', async function () {
|
||||
const mintingFinished = await this.token.mintingFinished();
|
||||
assert.equal(mintingFinished, false);
|
||||
});
|
||||
});
|
||||
|
||||
describe('when the token is finished', function () {
|
||||
beforeEach(async function () {
|
||||
await this.token.finishMinting({ from: owner });
|
||||
});
|
||||
|
||||
it('returns true', async function () {
|
||||
const mintingFinished = await this.token.mintingFinished.call();
|
||||
assert.equal(mintingFinished, true);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe('finish minting', function () {
|
||||
describe('when the sender is the token owner', function () {
|
||||
const from = owner;
|
||||
|
||||
describe('when the token was not finished', function () {
|
||||
it('finishes token minting', async function () {
|
||||
await this.token.finishMinting({ from });
|
||||
|
||||
const mintingFinished = await this.token.mintingFinished();
|
||||
assert.equal(mintingFinished, true);
|
||||
});
|
||||
|
||||
it('emits a mint finished event', async function () {
|
||||
const { logs } = await this.token.finishMinting({ from });
|
||||
|
||||
assert.equal(logs.length, 1);
|
||||
assert.equal(logs[0].event, 'MintFinished');
|
||||
});
|
||||
});
|
||||
|
||||
describe('when the token was already finished', function () {
|
||||
beforeEach(async function () {
|
||||
await this.token.finishMinting({ from });
|
||||
});
|
||||
|
||||
it('reverts', async function () {
|
||||
await assertRevert(this.token.finishMinting({ from }));
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe('when the sender is not the token owner', function () {
|
||||
const from = anotherAccount;
|
||||
|
||||
describe('when the token was not finished', function () {
|
||||
it('reverts', async function () {
|
||||
await assertRevert(this.token.finishMinting({ from }));
|
||||
});
|
||||
});
|
||||
|
||||
describe('when the token was already finished', function () {
|
||||
beforeEach(async function () {
|
||||
await this.token.finishMinting({ from: owner });
|
||||
});
|
||||
|
||||
it('reverts', async function () {
|
||||
await assertRevert(this.token.finishMinting({ from }));
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe('mint', function () {
|
||||
const amount = 100;
|
||||
|
||||
describe('when the sender is the token owner', function () {
|
||||
const from = owner;
|
||||
|
||||
describe('when the token was not finished', function () {
|
||||
it('mints the requested amount', async function () {
|
||||
await this.token.mint(owner, amount, { from });
|
||||
|
||||
const balance = await this.token.balanceOf(owner);
|
||||
assert.equal(balance, amount);
|
||||
});
|
||||
|
||||
it('emits a mint finished event', async function () {
|
||||
const { logs } = await this.token.mint(owner, amount, { from });
|
||||
|
||||
assert.equal(logs.length, 2);
|
||||
assert.equal(logs[0].event, 'Mint');
|
||||
assert.equal(logs[0].args.to, owner);
|
||||
assert.equal(logs[0].args.amount, amount);
|
||||
assert.equal(logs[1].event, 'Transfer');
|
||||
});
|
||||
});
|
||||
|
||||
describe('when the token minting is finished', function () {
|
||||
beforeEach(async function () {
|
||||
await this.token.finishMinting({ from });
|
||||
});
|
||||
|
||||
it('reverts', async function () {
|
||||
await assertRevert(this.token.mint(owner, amount, { from }));
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe('when the sender is not the token owner', function () {
|
||||
const from = anotherAccount;
|
||||
|
||||
describe('when the token was not finished', function () {
|
||||
it('reverts', async function () {
|
||||
await assertRevert(this.token.mint(owner, amount, { from }));
|
||||
});
|
||||
});
|
||||
|
||||
describe('when the token was already finished', function () {
|
||||
beforeEach(async function () {
|
||||
await this.token.finishMinting({ from: owner });
|
||||
});
|
||||
|
||||
it('reverts', async function () {
|
||||
await assertRevert(this.token.mint(owner, amount, { from }));
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
shouldBehaveLikeMintableToken([owner, anotherAccount, minter]);
|
||||
});
|
||||
|
||||
37
test/token/ERC20/RBACMintableToken.test.js
Normal file
37
test/token/ERC20/RBACMintableToken.test.js
Normal file
@ -0,0 +1,37 @@
|
||||
import expectThrow from '../../helpers/expectThrow';
|
||||
import shouldBehaveLikeMintableToken from './MintableToken.behaviour';
|
||||
const RBACMintableToken = artifacts.require('RBACMintableToken');
|
||||
|
||||
const ROLE_MINTER = 'minter';
|
||||
|
||||
contract('RBACMintableToken', function ([owner, anotherAccount, minter]) {
|
||||
beforeEach(async function () {
|
||||
this.token = await RBACMintableToken.new({ from: owner });
|
||||
await this.token.addMinter(minter, { from: owner });
|
||||
});
|
||||
|
||||
describe('handle roles', function () {
|
||||
it('owner can add and remove a minter role', async function () {
|
||||
await this.token.addMinter(anotherAccount, { from: owner });
|
||||
let hasRole = await this.token.hasRole(anotherAccount, ROLE_MINTER);
|
||||
assert.equal(hasRole, true);
|
||||
|
||||
await this.token.removeMinter(anotherAccount, { from: owner });
|
||||
hasRole = await this.token.hasRole(anotherAccount, ROLE_MINTER);
|
||||
assert.equal(hasRole, false);
|
||||
});
|
||||
|
||||
it('another account can\'t add or remove a minter role', async function () {
|
||||
await expectThrow(
|
||||
this.token.addMinter(anotherAccount, { from: anotherAccount })
|
||||
);
|
||||
|
||||
await this.token.addMinter(anotherAccount, { from: owner });
|
||||
await expectThrow(
|
||||
this.token.removeMinter(anotherAccount, { from: anotherAccount })
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
shouldBehaveLikeMintableToken([owner, anotherAccount, minter]);
|
||||
});
|
||||
Reference in New Issue
Block a user