NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove DOMAIN_SEPARATOR from Votes and update docs examples (#4297)

Browse Source 
Co-authored-by: Qiwei Yang <yangqiwei97@gmail.com>
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
This commit is contained in:
Francisco
2023-06-02 16:02:57 +01:00
committed by GitHub
parent 5cef83d2c7
commit 3902a410f1
12 changed files with 186 additions and 224 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/governance/utils/Votes.behavior.js
View File

@ -7,7 +7,7 @@ const ethSigUtil = require('eth-sig-util');
const Wallet = require('ethereumjs-wallet').default;
const { shouldBehaveLikeEIP6372 } = require('./EIP6372.behavior');
const { getDomain, domainType, domainSeparator } = require('../../helpers/eip712');
const { getDomain, domainType } = require('../../helpers/eip712');
const { clockFromReceipt } = require('../../helpers/time');
const Delegation = [
@ -36,10 +36,6 @@ function shouldBehaveLikeVotes(accounts, tokens, { mode = 'blocknumber', fungibl
expect(await this.votes.nonces(accounts[0])).to.be.bignumber.equal('0');
});
it('domain separator', async function () {
expect(await this.votes.DOMAIN_SEPARATOR()).to.equal(domainSeparator(await getDomain(this.votes)));
});
describe('delegation with signature', function () {
const token = tokens[0];

4
test/token/ERC20/extensions/ERC20Votes.test.js
View File

@ -46,10 +46,6 @@ contract('ERC20Votes', function (accounts) {
expect(await this.token.nonces(holder)).to.be.bignumber.equal('0');
});
it('domain separator', async function () {
expect(await this.token.DOMAIN_SEPARATOR()).to.equal(await getDomain(this.token).then(domainSeparator));
});
it('minting restriction', async function () {
const amount = new BN('2').pow(new BN('224'));
await expectRevert(this.token.$_mint(holder, amount), 'ERC20Votes: total supply risks overflowing votes');