NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FixinigTimeoutsAndTotalVotes

Browse Source
This commit is contained in:
Aleksander Kryukov
2021-11-22 09:51:11 +02:00
parent cd703a5ee0
commit 37fe8c292a
4 changed files with 38 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
certora/specs/GovernorBase.spec
View File

@ -14,6 +14,7 @@ methods {
hasVoted(uint256, address) returns bool
castVote(uint256, uint8) returns uint256
updateQuorumNumerator(uint256)
queue(address[], uint256[], bytes[], bytes32) returns uint256
// internal functions made public in harness:
@ -29,8 +30,10 @@ methods {
getVotes(address, uint256) returns uint256 => DISPATCHER(true)
erc20votes.getPastTotalSupply(uint256) returns uint256
erc20votes.getPastVotes(address, uint256) returns uint256
scheduleBatch(address[],uint256[],bytes[],bytes32,bytes32,uint256) => NONDET
executeBatch(address[], uint256[], bytes[], bytes32, bytes32) => NONDET
}
//////////////////////////////////////////////////////////////////////////////
@ -55,6 +58,9 @@ function callFunctionWithProposal(uint256 proposalId, method f) {
f@withrevert(e, args);
} else if (f.selector == castVoteBySig(uint256, uint8,uint8, bytes32, bytes32).selector) {
castVoteBySig@withrevert(e, proposalId, support, v, r, s);
} else if (f.selector == queue(address[], uint256[], bytes[], bytes32).selector) {
require targets.length <= 1 && values.length <= 1 && calldatas.length <= 1;
queue@withrevert(e, targets, values, calldatas, descriptionHash);
} else {
calldataarg args;
f@withrevert(e, args);

34
certora/specs/GovernorCountingSimple.spec
View File

@ -16,8 +16,6 @@ methods {
erc20votes._getPastVotes(address, uint256) returns uint256
getExecutor() returns address
//0xe38335e5 => DISPATCHER(true)
}
//////////////////////////////////////////////////////////////////////////////
@ -133,11 +131,35 @@ invariant OneIsNotMoreThanAll(uint256 pId)
/*
* totalVotesPossible >= votePower(id)
*/
invariant possibleTotalVotes(uint256 pId, env e)
tracked_weight(pId) <= erc20votes.getPastTotalSupply(e, proposalSnapshot(pId))
//invariant possibleTotalVotes(uint256 pId, env e)
// tracked_weight(pId) <= erc20votes.getPastTotalSupply(e, proposalSnapshot(pId))
invariant voteGettersCheck(uint256 pId, address acc, env e)
erc20votes.getPastVotes(e, acc, proposalSnapshot(pId)) <= erc20votes.getPastTotalSupply(e, proposalSnapshot(pId))
rule possibleTotalVotes(uint256 pId, env e, method f) {
require tracked_weight(pId) <= erc20votes.getPastTotalSupply(e, proposalSnapshot(pId));
calldataarg args;
f(e, args);
assert tracked_weight(pId) <= erc20votes.getPastTotalSupply(e, proposalSnapshot(pId)), "bla bla bla";
}
//invariant voteGettersCheck(uint256 pId, address acc, env e)
// erc20votes.getPastVotes(e, acc, proposalSnapshot(pId)) <= erc20votes.getPastTotalSupply(e, proposalSnapshot(pId))
rule voteGettersCheck(uint256 pId, address acc, env e, method f){
address[] targets;
uint256[] values;
bytes[] calldatas;
require erc20votes.getPastVotes(e, acc, proposalSnapshot(pId)) <= erc20votes.getPastTotalSupply(e, proposalSnapshot(pId));
uint256 result = callPropose(e, targets, values, calldatas);
require result == pId;
assert erc20votes.getPastVotes(e, acc, proposalSnapshot(pId)) <= erc20votes.getPastTotalSupply(e, proposalSnapshot(pId)),
"getPastVotes is greater";
}
/*
* totalVotesPossible >= votePower(id)