Transpile 7bce2b72
This commit is contained in:
github-actions
87
test/governance/extensions/GovernorComp.test.js
Normal file
87
test/governance/extensions/GovernorComp.test.js
Normal file
@ -0,0 +1,87 @@
|
||||
const { BN, expectEvent } = require('@openzeppelin/test-helpers');
|
||||
const Enums = require('../../helpers/enums');
|
||||
|
||||
const {
|
||||
runGovernorWorkflow,
|
||||
} = require('./../GovernorWorkflow.behavior');
|
||||
|
||||
const Token = artifacts.require('ERC20VotesCompMock');
|
||||
const Governor = artifacts.require('GovernorCompMock');
|
||||
const CallReceiver = artifacts.require('CallReceiverMock');
|
||||
|
||||
contract('GovernorComp', function (accounts) {
|
||||
const [ owner, voter1, voter2, voter3, voter4 ] = accounts;
|
||||
|
||||
const name = 'OZ-Governor';
|
||||
// const version = '1';
|
||||
const tokenName = 'MockToken';
|
||||
const tokenSymbol = 'MTKN';
|
||||
const tokenSupply = web3.utils.toWei('100');
|
||||
|
||||
beforeEach(async function () {
|
||||
this.owner = owner;
|
||||
this.token = await Token.new(tokenName, tokenSymbol);
|
||||
this.mock = await Governor.new(name, this.token.address);
|
||||
this.receiver = await CallReceiver.new();
|
||||
await this.token.mint(owner, tokenSupply);
|
||||
await this.token.delegate(voter1, { from: voter1 });
|
||||
await this.token.delegate(voter2, { from: voter2 });
|
||||
await this.token.delegate(voter3, { from: voter3 });
|
||||
await this.token.delegate(voter4, { from: voter4 });
|
||||
});
|
||||
|
||||
it('deployment check', async function () {
|
||||
expect(await this.mock.name()).to.be.equal(name);
|
||||
expect(await this.mock.token()).to.be.equal(this.token.address);
|
||||
expect(await this.mock.votingDelay()).to.be.bignumber.equal('4');
|
||||
expect(await this.mock.votingPeriod()).to.be.bignumber.equal('16');
|
||||
expect(await this.mock.quorum(0)).to.be.bignumber.equal('0');
|
||||
});
|
||||
|
||||
describe('voting with comp token', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[ this.receiver.address ],
|
||||
[ web3.utils.toWei('0') ],
|
||||
[ this.receiver.contract.methods.mockFunction().encodeABI() ],
|
||||
'<proposal description>',
|
||||
],
|
||||
tokenHolder: owner,
|
||||
voters: [
|
||||
{ voter: voter1, weight: web3.utils.toWei('1'), support: Enums.VoteType.For },
|
||||
{ voter: voter2, weight: web3.utils.toWei('10'), support: Enums.VoteType.For },
|
||||
{ voter: voter3, weight: web3.utils.toWei('5'), support: Enums.VoteType.Against },
|
||||
{ voter: voter4, weight: web3.utils.toWei('2'), support: Enums.VoteType.Abstain },
|
||||
],
|
||||
};
|
||||
});
|
||||
afterEach(async function () {
|
||||
expect(await this.mock.hasVoted(this.id, owner)).to.be.equal(false);
|
||||
expect(await this.mock.hasVoted(this.id, voter1)).to.be.equal(true);
|
||||
expect(await this.mock.hasVoted(this.id, voter2)).to.be.equal(true);
|
||||
expect(await this.mock.hasVoted(this.id, voter3)).to.be.equal(true);
|
||||
expect(await this.mock.hasVoted(this.id, voter4)).to.be.equal(true);
|
||||
|
||||
this.receipts.castVote.filter(Boolean).forEach(vote => {
|
||||
const { voter } = vote.logs.find(Boolean).args;
|
||||
expectEvent(
|
||||
vote,
|
||||
'VoteCast',
|
||||
this.settings.voters.find(({ address }) => address === voter),
|
||||
);
|
||||
});
|
||||
await this.mock.proposalVotes(this.id).then(result => {
|
||||
for (const [key, value] of Object.entries(Enums.VoteType)) {
|
||||
expect(result[`${key.toLowerCase()}Votes`]).to.be.bignumber.equal(
|
||||
Object.values(this.settings.voters).filter(({ support }) => support === value).reduce(
|
||||
(acc, { weight }) => acc.add(new BN(weight)),
|
||||
new BN('0'),
|
||||
),
|
||||
);
|
||||
}
|
||||
});
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
});
|
||||
118
test/governance/extensions/GovernorERC721.test.js
Normal file
118
test/governance/extensions/GovernorERC721.test.js
Normal file
@ -0,0 +1,118 @@
|
||||
const { expectEvent } = require('@openzeppelin/test-helpers');
|
||||
const { BN } = require('bn.js');
|
||||
const Enums = require('../../helpers/enums');
|
||||
|
||||
const {
|
||||
runGovernorWorkflow,
|
||||
} = require('./../GovernorWorkflow.behavior');
|
||||
|
||||
const Token = artifacts.require('ERC721VotesMock');
|
||||
const Governor = artifacts.require('GovernorVoteMocks');
|
||||
const CallReceiver = artifacts.require('CallReceiverMock');
|
||||
|
||||
contract('GovernorERC721Mock', function (accounts) {
|
||||
const [ owner, voter1, voter2, voter3, voter4 ] = accounts;
|
||||
|
||||
const name = 'OZ-Governor';
|
||||
const tokenName = 'MockNFToken';
|
||||
const tokenSymbol = 'MTKN';
|
||||
const NFT0 = web3.utils.toWei('100');
|
||||
const NFT1 = web3.utils.toWei('10');
|
||||
const NFT2 = web3.utils.toWei('20');
|
||||
const NFT3 = web3.utils.toWei('30');
|
||||
const NFT4 = web3.utils.toWei('40');
|
||||
|
||||
// Must be the same as in contract
|
||||
const ProposalState = {
|
||||
Pending: new BN('0'),
|
||||
Active: new BN('1'),
|
||||
Canceled: new BN('2'),
|
||||
Defeated: new BN('3'),
|
||||
Succeeded: new BN('4'),
|
||||
Queued: new BN('5'),
|
||||
Expired: new BN('6'),
|
||||
Executed: new BN('7'),
|
||||
};
|
||||
|
||||
beforeEach(async function () {
|
||||
this.owner = owner;
|
||||
this.token = await Token.new(tokenName, tokenSymbol);
|
||||
this.mock = await Governor.new(name, this.token.address);
|
||||
this.receiver = await CallReceiver.new();
|
||||
await this.token.mint(owner, NFT0);
|
||||
await this.token.mint(owner, NFT1);
|
||||
await this.token.mint(owner, NFT2);
|
||||
await this.token.mint(owner, NFT3);
|
||||
await this.token.mint(owner, NFT4);
|
||||
|
||||
await this.token.delegate(voter1, { from: voter1 });
|
||||
await this.token.delegate(voter2, { from: voter2 });
|
||||
await this.token.delegate(voter3, { from: voter3 });
|
||||
await this.token.delegate(voter4, { from: voter4 });
|
||||
});
|
||||
|
||||
it('deployment check', async function () {
|
||||
expect(await this.mock.name()).to.be.equal(name);
|
||||
expect(await this.mock.token()).to.be.equal(this.token.address);
|
||||
expect(await this.mock.votingDelay()).to.be.bignumber.equal('4');
|
||||
expect(await this.mock.votingPeriod()).to.be.bignumber.equal('16');
|
||||
expect(await this.mock.quorum(0)).to.be.bignumber.equal('0');
|
||||
});
|
||||
|
||||
describe('voting with ERC721 token', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[ this.receiver.address ],
|
||||
[ web3.utils.toWei('0') ],
|
||||
[ this.receiver.contract.methods.mockFunction().encodeABI() ],
|
||||
'<proposal description>',
|
||||
],
|
||||
tokenHolder: owner,
|
||||
voters: [
|
||||
{ voter: voter1, nfts: [NFT0], support: Enums.VoteType.For },
|
||||
{ voter: voter2, nfts: [NFT1, NFT2], support: Enums.VoteType.For },
|
||||
{ voter: voter3, nfts: [NFT3], support: Enums.VoteType.Against },
|
||||
{ voter: voter4, nfts: [NFT4], support: Enums.VoteType.Abstain },
|
||||
],
|
||||
};
|
||||
});
|
||||
|
||||
afterEach(async function () {
|
||||
expect(await this.mock.hasVoted(this.id, owner)).to.be.equal(false);
|
||||
|
||||
for (const vote of this.receipts.castVote.filter(Boolean)) {
|
||||
const { voter } = vote.logs.find(Boolean).args;
|
||||
|
||||
expect(await this.mock.hasVoted(this.id, voter)).to.be.equal(true);
|
||||
|
||||
expectEvent(
|
||||
vote,
|
||||
'VoteCast',
|
||||
this.settings.voters.find(({ address }) => address === voter),
|
||||
);
|
||||
|
||||
if (voter === voter2) {
|
||||
expect(await this.token.getVotes(voter, vote.blockNumber)).to.be.bignumber.equal('2');
|
||||
} else {
|
||||
expect(await this.token.getVotes(voter, vote.blockNumber)).to.be.bignumber.equal('1');
|
||||
}
|
||||
}
|
||||
|
||||
await this.mock.proposalVotes(this.id).then(result => {
|
||||
for (const [key, value] of Object.entries(Enums.VoteType)) {
|
||||
expect(result[`${key.toLowerCase()}Votes`]).to.be.bignumber.equal(
|
||||
Object.values(this.settings.voters).filter(({ support }) => support === value).reduce(
|
||||
(acc, { nfts }) => acc.add(new BN(nfts.length)),
|
||||
new BN('0'),
|
||||
),
|
||||
);
|
||||
}
|
||||
});
|
||||
|
||||
expect(await this.mock.state(this.id)).to.be.bignumber.equal(ProposalState.Executed);
|
||||
});
|
||||
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
});
|
||||
247
test/governance/extensions/GovernorPreventLateQuorum.test.js
Normal file
247
test/governance/extensions/GovernorPreventLateQuorum.test.js
Normal file
@ -0,0 +1,247 @@
|
||||
const { BN, expectEvent, expectRevert, time } = require('@openzeppelin/test-helpers');
|
||||
const Enums = require('../../helpers/enums');
|
||||
|
||||
const {
|
||||
runGovernorWorkflow,
|
||||
} = require('../GovernorWorkflow.behavior');
|
||||
|
||||
const Token = artifacts.require('ERC20VotesCompMock');
|
||||
const Governor = artifacts.require('GovernorPreventLateQuorumMock');
|
||||
const CallReceiver = artifacts.require('CallReceiverMock');
|
||||
|
||||
contract('GovernorPreventLateQuorum', function (accounts) {
|
||||
const [ owner, proposer, voter1, voter2, voter3, voter4 ] = accounts;
|
||||
|
||||
const name = 'OZ-Governor';
|
||||
// const version = '1';
|
||||
const tokenName = 'MockToken';
|
||||
const tokenSymbol = 'MTKN';
|
||||
const tokenSupply = web3.utils.toWei('100');
|
||||
const votingDelay = new BN(4);
|
||||
const votingPeriod = new BN(16);
|
||||
const lateQuorumVoteExtension = new BN(8);
|
||||
const quorum = web3.utils.toWei('1');
|
||||
|
||||
beforeEach(async function () {
|
||||
this.owner = owner;
|
||||
this.token = await Token.new(tokenName, tokenSymbol);
|
||||
this.mock = await Governor.new(
|
||||
name,
|
||||
this.token.address,
|
||||
votingDelay,
|
||||
votingPeriod,
|
||||
quorum,
|
||||
lateQuorumVoteExtension,
|
||||
);
|
||||
this.receiver = await CallReceiver.new();
|
||||
await this.token.mint(owner, tokenSupply);
|
||||
await this.token.delegate(voter1, { from: voter1 });
|
||||
await this.token.delegate(voter2, { from: voter2 });
|
||||
await this.token.delegate(voter3, { from: voter3 });
|
||||
await this.token.delegate(voter4, { from: voter4 });
|
||||
});
|
||||
|
||||
it('deployment check', async function () {
|
||||
expect(await this.mock.name()).to.be.equal(name);
|
||||
expect(await this.mock.token()).to.be.equal(this.token.address);
|
||||
expect(await this.mock.votingDelay()).to.be.bignumber.equal(votingDelay);
|
||||
expect(await this.mock.votingPeriod()).to.be.bignumber.equal(votingPeriod);
|
||||
expect(await this.mock.quorum(0)).to.be.bignumber.equal(quorum);
|
||||
expect(await this.mock.lateQuorumVoteExtension()).to.be.bignumber.equal(lateQuorumVoteExtension);
|
||||
});
|
||||
|
||||
describe('nominal is unaffected', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[ this.receiver.address ],
|
||||
[ 0 ],
|
||||
[ this.receiver.contract.methods.mockFunction().encodeABI() ],
|
||||
'<proposal description>',
|
||||
],
|
||||
proposer,
|
||||
tokenHolder: owner,
|
||||
voters: [
|
||||
{ voter: voter1, weight: web3.utils.toWei('1'), support: Enums.VoteType.For, reason: 'This is nice' },
|
||||
{ voter: voter2, weight: web3.utils.toWei('7'), support: Enums.VoteType.For },
|
||||
{ voter: voter3, weight: web3.utils.toWei('5'), support: Enums.VoteType.Against },
|
||||
{ voter: voter4, weight: web3.utils.toWei('2'), support: Enums.VoteType.Abstain },
|
||||
],
|
||||
};
|
||||
});
|
||||
|
||||
afterEach(async function () {
|
||||
expect(await this.mock.hasVoted(this.id, owner)).to.be.equal(false);
|
||||
expect(await this.mock.hasVoted(this.id, voter1)).to.be.equal(true);
|
||||
expect(await this.mock.hasVoted(this.id, voter2)).to.be.equal(true);
|
||||
|
||||
await this.mock.proposalVotes(this.id).then(result => {
|
||||
for (const [key, value] of Object.entries(Enums.VoteType)) {
|
||||
expect(result[`${key.toLowerCase()}Votes`]).to.be.bignumber.equal(
|
||||
Object.values(this.settings.voters).filter(({ support }) => support === value).reduce(
|
||||
(acc, { weight }) => acc.add(new BN(weight)),
|
||||
new BN('0'),
|
||||
),
|
||||
);
|
||||
}
|
||||
});
|
||||
|
||||
const startBlock = new BN(this.receipts.propose.blockNumber).add(votingDelay);
|
||||
const endBlock = new BN(this.receipts.propose.blockNumber).add(votingDelay).add(votingPeriod);
|
||||
expect(await this.mock.proposalSnapshot(this.id)).to.be.bignumber.equal(startBlock);
|
||||
expect(await this.mock.proposalDeadline(this.id)).to.be.bignumber.equal(endBlock);
|
||||
|
||||
expectEvent(
|
||||
this.receipts.propose,
|
||||
'ProposalCreated',
|
||||
{
|
||||
proposalId: this.id,
|
||||
proposer,
|
||||
targets: this.settings.proposal[0],
|
||||
// values: this.settings.proposal[1].map(value => new BN(value)),
|
||||
signatures: this.settings.proposal[2].map(() => ''),
|
||||
calldatas: this.settings.proposal[2],
|
||||
startBlock,
|
||||
endBlock,
|
||||
description: this.settings.proposal[3],
|
||||
},
|
||||
);
|
||||
|
||||
this.receipts.castVote.filter(Boolean).forEach(vote => {
|
||||
const { voter } = vote.logs.find(Boolean).args;
|
||||
expectEvent(
|
||||
vote,
|
||||
'VoteCast',
|
||||
this.settings.voters.find(({ address }) => address === voter),
|
||||
);
|
||||
expectEvent.notEmitted(
|
||||
vote,
|
||||
'ProposalExtended',
|
||||
);
|
||||
});
|
||||
expectEvent(
|
||||
this.receipts.execute,
|
||||
'ProposalExecuted',
|
||||
{ proposalId: this.id },
|
||||
);
|
||||
await expectEvent.inTransaction(
|
||||
this.receipts.execute.transactionHash,
|
||||
this.receiver,
|
||||
'MockFunctionCalled',
|
||||
);
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
|
||||
describe('Delay is extended to prevent last minute take-over', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[ this.receiver.address ],
|
||||
[ 0 ],
|
||||
[ this.receiver.contract.methods.mockFunction().encodeABI() ],
|
||||
'<proposal description>',
|
||||
],
|
||||
proposer,
|
||||
tokenHolder: owner,
|
||||
voters: [
|
||||
{ voter: voter1, weight: web3.utils.toWei('0.2'), support: Enums.VoteType.Against },
|
||||
{ voter: voter2, weight: web3.utils.toWei('1.0') }, // do not actually vote, only getting tokens
|
||||
{ voter: voter3, weight: web3.utils.toWei('0.9') }, // do not actually vote, only getting tokens
|
||||
],
|
||||
steps: {
|
||||
wait: { enable: false },
|
||||
execute: { enable: false },
|
||||
},
|
||||
};
|
||||
});
|
||||
|
||||
afterEach(async function () {
|
||||
expect(await this.mock.state(this.id)).to.be.bignumber.equal(Enums.ProposalState.Active);
|
||||
|
||||
const startBlock = new BN(this.receipts.propose.blockNumber).add(votingDelay);
|
||||
const endBlock = new BN(this.receipts.propose.blockNumber).add(votingDelay).add(votingPeriod);
|
||||
expect(await this.mock.proposalSnapshot(this.id)).to.be.bignumber.equal(startBlock);
|
||||
expect(await this.mock.proposalDeadline(this.id)).to.be.bignumber.equal(endBlock);
|
||||
|
||||
// wait until the vote is almost over
|
||||
await time.advanceBlockTo(endBlock.subn(1));
|
||||
expect(await this.mock.state(this.id)).to.be.bignumber.equal(Enums.ProposalState.Active);
|
||||
|
||||
// try to overtake the vote at the last minute
|
||||
const tx = await this.mock.castVote(this.id, Enums.VoteType.For, { from: voter2 });
|
||||
|
||||
// vote duration is extended
|
||||
const extendedBlock = new BN(tx.receipt.blockNumber).add(lateQuorumVoteExtension);
|
||||
expect(await this.mock.proposalDeadline(this.id)).to.be.bignumber.equal(extendedBlock);
|
||||
|
||||
expectEvent(
|
||||
tx,
|
||||
'ProposalExtended',
|
||||
{ proposalId: this.id, extendedDeadline: extendedBlock },
|
||||
);
|
||||
|
||||
// vote is still active after expected end
|
||||
await time.advanceBlockTo(endBlock.addn(1));
|
||||
expect(await this.mock.state(this.id)).to.be.bignumber.equal(Enums.ProposalState.Active);
|
||||
|
||||
// Still possible to vote
|
||||
await this.mock.castVote(this.id, Enums.VoteType.Against, { from: voter3 });
|
||||
|
||||
// proposal fails
|
||||
await time.advanceBlockTo(extendedBlock.addn(1));
|
||||
expect(await this.mock.state(this.id)).to.be.bignumber.equal(Enums.ProposalState.Defeated);
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
|
||||
describe('setLateQuorumVoteExtension', function () {
|
||||
beforeEach(async function () {
|
||||
this.newVoteExtension = new BN(0); // disable voting delay extension
|
||||
});
|
||||
|
||||
it('protected', async function () {
|
||||
await expectRevert(
|
||||
this.mock.setLateQuorumVoteExtension(this.newVoteExtension),
|
||||
'Governor: onlyGovernance',
|
||||
);
|
||||
});
|
||||
|
||||
describe('using workflow', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[ this.mock.address ],
|
||||
[ web3.utils.toWei('0') ],
|
||||
[ this.mock.contract.methods.setLateQuorumVoteExtension(this.newVoteExtension).encodeABI() ],
|
||||
'<proposal description>',
|
||||
],
|
||||
proposer,
|
||||
tokenHolder: owner,
|
||||
voters: [
|
||||
{ voter: voter1, weight: web3.utils.toWei('1.0'), support: Enums.VoteType.For },
|
||||
],
|
||||
};
|
||||
});
|
||||
afterEach(async function () {
|
||||
expectEvent(
|
||||
this.receipts.propose,
|
||||
'ProposalCreated',
|
||||
{ proposalId: this.id },
|
||||
);
|
||||
expectEvent(
|
||||
this.receipts.execute,
|
||||
'ProposalExecuted',
|
||||
{ proposalId: this.id },
|
||||
);
|
||||
expectEvent(
|
||||
this.receipts.execute,
|
||||
'LateQuorumVoteExtensionSet',
|
||||
{ oldVoteExtension: lateQuorumVoteExtension, newVoteExtension: this.newVoteExtension },
|
||||
);
|
||||
expect(await this.mock.lateQuorumVoteExtension()).to.be.bignumber.equal(this.newVoteExtension);
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
});
|
||||
});
|
||||
487
test/governance/extensions/GovernorTimelockCompound.test.js
Normal file
487
test/governance/extensions/GovernorTimelockCompound.test.js
Normal file
@ -0,0 +1,487 @@
|
||||
const { constants, expectEvent, expectRevert } = require('@openzeppelin/test-helpers');
|
||||
const { expect } = require('chai');
|
||||
const Enums = require('../../helpers/enums');
|
||||
const RLP = require('rlp');
|
||||
|
||||
const {
|
||||
runGovernorWorkflow,
|
||||
} = require('../GovernorWorkflow.behavior');
|
||||
|
||||
const {
|
||||
shouldSupportInterfaces,
|
||||
} = require('../../utils/introspection/SupportsInterface.behavior');
|
||||
|
||||
const Token = artifacts.require('ERC20VotesMock');
|
||||
const Timelock = artifacts.require('CompTimelock');
|
||||
const Governor = artifacts.require('GovernorTimelockCompoundMock');
|
||||
const CallReceiver = artifacts.require('CallReceiverMock');
|
||||
|
||||
function makeContractAddress (creator, nonce) {
|
||||
return web3.utils.toChecksumAddress(web3.utils.sha3(RLP.encode([creator, nonce])).slice(12).substring(14));
|
||||
}
|
||||
|
||||
contract('GovernorTimelockCompound', function (accounts) {
|
||||
const [ admin, voter, other ] = accounts;
|
||||
|
||||
const name = 'OZ-Governor';
|
||||
// const version = '1';
|
||||
const tokenName = 'MockToken';
|
||||
const tokenSymbol = 'MTKN';
|
||||
const tokenSupply = web3.utils.toWei('100');
|
||||
|
||||
beforeEach(async function () {
|
||||
const [ deployer ] = await web3.eth.getAccounts();
|
||||
|
||||
this.token = await Token.new(tokenName, tokenSymbol);
|
||||
|
||||
// Need to predict governance address to set it as timelock admin with a delayed transfer
|
||||
const nonce = await web3.eth.getTransactionCount(deployer);
|
||||
const predictGovernor = makeContractAddress(deployer, nonce + 1);
|
||||
|
||||
this.timelock = await Timelock.new(predictGovernor, 2 * 86400);
|
||||
this.mock = await Governor.new(name, this.token.address, 4, 16, this.timelock.address, 0);
|
||||
this.receiver = await CallReceiver.new();
|
||||
await this.token.mint(voter, tokenSupply);
|
||||
await this.token.delegate(voter, { from: voter });
|
||||
});
|
||||
|
||||
shouldSupportInterfaces([
|
||||
'ERC165',
|
||||
'Governor',
|
||||
'GovernorTimelock',
|
||||
]);
|
||||
|
||||
it('doesn\'t accept ether transfers', async function () {
|
||||
await expectRevert.unspecified(web3.eth.sendTransaction({ from: voter, to: this.mock.address, value: 1 }));
|
||||
});
|
||||
|
||||
it('post deployment check', async function () {
|
||||
expect(await this.mock.name()).to.be.equal(name);
|
||||
expect(await this.mock.token()).to.be.equal(this.token.address);
|
||||
expect(await this.mock.votingDelay()).to.be.bignumber.equal('4');
|
||||
expect(await this.mock.votingPeriod()).to.be.bignumber.equal('16');
|
||||
expect(await this.mock.quorum(0)).to.be.bignumber.equal('0');
|
||||
|
||||
expect(await this.mock.timelock()).to.be.equal(this.timelock.address);
|
||||
expect(await this.timelock.admin()).to.be.equal(this.mock.address);
|
||||
});
|
||||
|
||||
describe('nominal', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[ this.receiver.address ],
|
||||
[ web3.utils.toWei('0') ],
|
||||
[ this.receiver.contract.methods.mockFunction().encodeABI() ],
|
||||
'<proposal description>',
|
||||
],
|
||||
voters: [
|
||||
{ voter: voter, support: Enums.VoteType.For },
|
||||
],
|
||||
steps: {
|
||||
queue: { delay: 7 * 86400 },
|
||||
},
|
||||
};
|
||||
});
|
||||
afterEach(async function () {
|
||||
expectEvent(
|
||||
this.receipts.propose,
|
||||
'ProposalCreated',
|
||||
{ proposalId: this.id },
|
||||
);
|
||||
expectEvent(
|
||||
this.receipts.queue,
|
||||
'ProposalQueued',
|
||||
{ proposalId: this.id },
|
||||
);
|
||||
await expectEvent.inTransaction(
|
||||
this.receipts.queue.transactionHash,
|
||||
this.timelock,
|
||||
'QueueTransaction',
|
||||
{ eta: this.eta },
|
||||
);
|
||||
expectEvent(
|
||||
this.receipts.execute,
|
||||
'ProposalExecuted',
|
||||
{ proposalId: this.id },
|
||||
);
|
||||
await expectEvent.inTransaction(
|
||||
this.receipts.execute.transactionHash,
|
||||
this.timelock,
|
||||
'ExecuteTransaction',
|
||||
{ eta: this.eta },
|
||||
);
|
||||
await expectEvent.inTransaction(
|
||||
this.receipts.execute.transactionHash,
|
||||
this.receiver,
|
||||
'MockFunctionCalled',
|
||||
);
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
|
||||
describe('not queued', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[ this.receiver.address ],
|
||||
[ web3.utils.toWei('0') ],
|
||||
[ this.receiver.contract.methods.mockFunction().encodeABI() ],
|
||||
'<proposal description>',
|
||||
],
|
||||
voters: [
|
||||
{ voter: voter, support: Enums.VoteType.For },
|
||||
],
|
||||
steps: {
|
||||
queue: { enable: false },
|
||||
execute: { error: 'GovernorTimelockCompound: proposal not yet queued' },
|
||||
},
|
||||
};
|
||||
});
|
||||
afterEach(async function () {
|
||||
expect(await this.mock.state(this.id)).to.be.bignumber.equal(Enums.ProposalState.Succeeded);
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
|
||||
describe('to early', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[ this.receiver.address ],
|
||||
[ web3.utils.toWei('0') ],
|
||||
[ this.receiver.contract.methods.mockFunction().encodeABI() ],
|
||||
'<proposal description>',
|
||||
],
|
||||
voters: [
|
||||
{ voter: voter, support: Enums.VoteType.For },
|
||||
],
|
||||
steps: {
|
||||
execute: { error: 'Timelock::executeTransaction: Transaction hasn\'t surpassed time lock' },
|
||||
},
|
||||
};
|
||||
});
|
||||
afterEach(async function () {
|
||||
expect(await this.mock.state(this.id)).to.be.bignumber.equal(Enums.ProposalState.Queued);
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
|
||||
describe('to late', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[ this.receiver.address ],
|
||||
[ web3.utils.toWei('0') ],
|
||||
[ this.receiver.contract.methods.mockFunction().encodeABI() ],
|
||||
'<proposal description>',
|
||||
],
|
||||
voters: [
|
||||
{ voter: voter, support: Enums.VoteType.For },
|
||||
],
|
||||
steps: {
|
||||
queue: { delay: 30 * 86400 },
|
||||
execute: { error: 'Governor: proposal not successful' },
|
||||
},
|
||||
};
|
||||
});
|
||||
afterEach(async function () {
|
||||
expect(await this.mock.state(this.id)).to.be.bignumber.equal(Enums.ProposalState.Expired);
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
|
||||
describe('deplicated underlying call', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
Array(2).fill(this.token.address),
|
||||
Array(2).fill(web3.utils.toWei('0')),
|
||||
Array(2).fill(this.token.contract.methods.approve(this.receiver.address, constants.MAX_UINT256).encodeABI()),
|
||||
'<proposal description>',
|
||||
],
|
||||
voters: [
|
||||
{ voter: voter, support: Enums.VoteType.For },
|
||||
],
|
||||
steps: {
|
||||
queue: {
|
||||
error: 'GovernorTimelockCompound: identical proposal action already queued',
|
||||
},
|
||||
execute: {
|
||||
error: 'GovernorTimelockCompound: proposal not yet queued',
|
||||
},
|
||||
},
|
||||
};
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
|
||||
describe('re-queue / re-execute', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[ this.receiver.address ],
|
||||
[ web3.utils.toWei('0') ],
|
||||
[ this.receiver.contract.methods.mockFunction().encodeABI() ],
|
||||
'<proposal description>',
|
||||
],
|
||||
voters: [
|
||||
{ voter: voter, support: Enums.VoteType.For },
|
||||
],
|
||||
steps: {
|
||||
queue: { delay: 7 * 86400 },
|
||||
},
|
||||
};
|
||||
});
|
||||
afterEach(async function () {
|
||||
expect(await this.mock.state(this.id)).to.be.bignumber.equal(Enums.ProposalState.Executed);
|
||||
|
||||
await expectRevert(
|
||||
this.mock.queue(...this.settings.proposal.slice(0, -1), this.descriptionHash),
|
||||
'Governor: proposal not successful',
|
||||
);
|
||||
await expectRevert(
|
||||
this.mock.execute(...this.settings.proposal.slice(0, -1), this.descriptionHash),
|
||||
'Governor: proposal not successful',
|
||||
);
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
|
||||
describe('cancel before queue prevents scheduling', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[ this.receiver.address ],
|
||||
[ web3.utils.toWei('0') ],
|
||||
[ this.receiver.contract.methods.mockFunction().encodeABI() ],
|
||||
'<proposal description>',
|
||||
],
|
||||
voters: [
|
||||
{ voter: voter, support: Enums.VoteType.For },
|
||||
],
|
||||
steps: {
|
||||
queue: { enable: false },
|
||||
execute: { enable: false },
|
||||
},
|
||||
};
|
||||
});
|
||||
afterEach(async function () {
|
||||
expect(await this.mock.state(this.id)).to.be.bignumber.equal(Enums.ProposalState.Succeeded);
|
||||
|
||||
expectEvent(
|
||||
await this.mock.cancel(...this.settings.proposal.slice(0, -1), this.descriptionHash),
|
||||
'ProposalCanceled',
|
||||
{ proposalId: this.id },
|
||||
);
|
||||
|
||||
expect(await this.mock.state(this.id)).to.be.bignumber.equal(Enums.ProposalState.Canceled);
|
||||
|
||||
await expectRevert(
|
||||
this.mock.queue(...this.settings.proposal.slice(0, -1), this.descriptionHash),
|
||||
'Governor: proposal not successful',
|
||||
);
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
|
||||
describe('cancel after queue prevents executing', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[ this.receiver.address ],
|
||||
[ web3.utils.toWei('0') ],
|
||||
[ this.receiver.contract.methods.mockFunction().encodeABI() ],
|
||||
'<proposal description>',
|
||||
],
|
||||
voters: [
|
||||
{ voter: voter, support: Enums.VoteType.For },
|
||||
],
|
||||
steps: {
|
||||
queue: { delay: 7 * 86400 },
|
||||
execute: { enable: false },
|
||||
},
|
||||
};
|
||||
});
|
||||
afterEach(async function () {
|
||||
expect(await this.mock.state(this.id)).to.be.bignumber.equal(Enums.ProposalState.Queued);
|
||||
|
||||
const receipt = await this.mock.cancel(...this.settings.proposal.slice(0, -1), this.descriptionHash);
|
||||
expectEvent(
|
||||
receipt,
|
||||
'ProposalCanceled',
|
||||
{ proposalId: this.id },
|
||||
);
|
||||
await expectEvent.inTransaction(
|
||||
receipt.receipt.transactionHash,
|
||||
this.timelock,
|
||||
'CancelTransaction',
|
||||
);
|
||||
|
||||
expect(await this.mock.state(this.id)).to.be.bignumber.equal(Enums.ProposalState.Canceled);
|
||||
|
||||
await expectRevert(
|
||||
this.mock.execute(...this.settings.proposal.slice(0, -1), this.descriptionHash),
|
||||
'Governor: proposal not successful',
|
||||
);
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
|
||||
describe('relay', function () {
|
||||
beforeEach(async function () {
|
||||
await this.token.mint(this.mock.address, 1);
|
||||
this.call = [
|
||||
this.token.address,
|
||||
0,
|
||||
this.token.contract.methods.transfer(other, 1).encodeABI(),
|
||||
];
|
||||
});
|
||||
|
||||
it('protected', async function () {
|
||||
await expectRevert(
|
||||
this.mock.relay(...this.call),
|
||||
'Governor: onlyGovernance',
|
||||
);
|
||||
});
|
||||
|
||||
describe('using workflow', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[
|
||||
this.mock.address,
|
||||
],
|
||||
[
|
||||
web3.utils.toWei('0'),
|
||||
],
|
||||
[
|
||||
this.mock.contract.methods.relay(...this.call).encodeABI(),
|
||||
],
|
||||
'<proposal description>',
|
||||
],
|
||||
voters: [
|
||||
{ voter: voter, support: Enums.VoteType.For },
|
||||
],
|
||||
steps: {
|
||||
queue: { delay: 7 * 86400 },
|
||||
},
|
||||
};
|
||||
|
||||
expect(await this.token.balanceOf(this.mock.address), 1);
|
||||
expect(await this.token.balanceOf(other), 0);
|
||||
});
|
||||
afterEach(async function () {
|
||||
expect(await this.token.balanceOf(this.mock.address), 0);
|
||||
expect(await this.token.balanceOf(other), 1);
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
});
|
||||
|
||||
describe('updateTimelock', function () {
|
||||
beforeEach(async function () {
|
||||
this.newTimelock = await Timelock.new(this.mock.address, 7 * 86400);
|
||||
});
|
||||
|
||||
it('protected', async function () {
|
||||
await expectRevert(
|
||||
this.mock.updateTimelock(this.newTimelock.address),
|
||||
'Governor: onlyGovernance',
|
||||
);
|
||||
});
|
||||
|
||||
describe('using workflow', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[
|
||||
this.timelock.address,
|
||||
this.mock.address,
|
||||
],
|
||||
[
|
||||
web3.utils.toWei('0'),
|
||||
web3.utils.toWei('0'),
|
||||
],
|
||||
[
|
||||
this.timelock.contract.methods.setPendingAdmin(admin).encodeABI(),
|
||||
this.mock.contract.methods.updateTimelock(this.newTimelock.address).encodeABI(),
|
||||
],
|
||||
'<proposal description>',
|
||||
],
|
||||
voters: [
|
||||
{ voter: voter, support: Enums.VoteType.For },
|
||||
],
|
||||
steps: {
|
||||
queue: { delay: 7 * 86400 },
|
||||
},
|
||||
};
|
||||
});
|
||||
afterEach(async function () {
|
||||
expectEvent(
|
||||
this.receipts.propose,
|
||||
'ProposalCreated',
|
||||
{ proposalId: this.id },
|
||||
);
|
||||
expectEvent(
|
||||
this.receipts.execute,
|
||||
'ProposalExecuted',
|
||||
{ proposalId: this.id },
|
||||
);
|
||||
expectEvent(
|
||||
this.receipts.execute,
|
||||
'TimelockChange',
|
||||
{ oldTimelock: this.timelock.address, newTimelock: this.newTimelock.address },
|
||||
);
|
||||
expect(await this.mock.timelock()).to.be.bignumber.equal(this.newTimelock.address);
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
});
|
||||
|
||||
describe('transfer timelock to new governor', function () {
|
||||
beforeEach(async function () {
|
||||
this.newGovernor = await Governor.new(name, this.token.address, 8, 32, this.timelock.address, 0);
|
||||
});
|
||||
|
||||
describe('using workflow', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[ this.timelock.address ],
|
||||
[ web3.utils.toWei('0') ],
|
||||
[ this.timelock.contract.methods.setPendingAdmin(this.newGovernor.address).encodeABI() ],
|
||||
'<proposal description>',
|
||||
],
|
||||
voters: [
|
||||
{ voter: voter, support: Enums.VoteType.For },
|
||||
],
|
||||
steps: {
|
||||
queue: { delay: 7 * 86400 },
|
||||
},
|
||||
};
|
||||
});
|
||||
afterEach(async function () {
|
||||
expectEvent(
|
||||
this.receipts.propose,
|
||||
'ProposalCreated',
|
||||
{ proposalId: this.id },
|
||||
);
|
||||
expectEvent(
|
||||
this.receipts.execute,
|
||||
'ProposalExecuted',
|
||||
{ proposalId: this.id },
|
||||
);
|
||||
await expectEvent.inTransaction(
|
||||
this.receipts.execute.transactionHash,
|
||||
this.timelock,
|
||||
'NewPendingAdmin',
|
||||
{ newPendingAdmin: this.newGovernor.address },
|
||||
);
|
||||
await this.newGovernor.__acceptAdmin();
|
||||
expect(await this.timelock.admin()).to.be.bignumber.equal(this.newGovernor.address);
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
});
|
||||
});
|
||||
464
test/governance/extensions/GovernorTimelockControl.test.js
Normal file
464
test/governance/extensions/GovernorTimelockControl.test.js
Normal file
@ -0,0 +1,464 @@
|
||||
const { constants, expectEvent, expectRevert } = require('@openzeppelin/test-helpers');
|
||||
const { expect } = require('chai');
|
||||
const Enums = require('../../helpers/enums');
|
||||
|
||||
const {
|
||||
runGovernorWorkflow,
|
||||
} = require('../GovernorWorkflow.behavior');
|
||||
|
||||
const {
|
||||
shouldSupportInterfaces,
|
||||
} = require('../../utils/introspection/SupportsInterface.behavior');
|
||||
|
||||
const Token = artifacts.require('ERC20VotesMock');
|
||||
const Timelock = artifacts.require('TimelockController');
|
||||
const Governor = artifacts.require('GovernorTimelockControlMock');
|
||||
const CallReceiver = artifacts.require('CallReceiverMock');
|
||||
|
||||
contract('GovernorTimelockControl', function (accounts) {
|
||||
const [ admin, voter, other ] = accounts;
|
||||
|
||||
const name = 'OZ-Governor';
|
||||
// const version = '1';
|
||||
const tokenName = 'MockToken';
|
||||
const tokenSymbol = 'MTKN';
|
||||
const tokenSupply = web3.utils.toWei('100');
|
||||
|
||||
beforeEach(async function () {
|
||||
const [ deployer ] = await web3.eth.getAccounts();
|
||||
|
||||
this.token = await Token.new(tokenName, tokenSymbol);
|
||||
this.timelock = await Timelock.new(3600, [], []);
|
||||
this.mock = await Governor.new(name, this.token.address, 4, 16, this.timelock.address, 0);
|
||||
this.receiver = await CallReceiver.new();
|
||||
// normal setup: governor is proposer, everyone is executor, timelock is its own admin
|
||||
await this.timelock.grantRole(await this.timelock.PROPOSER_ROLE(), this.mock.address);
|
||||
await this.timelock.grantRole(await this.timelock.PROPOSER_ROLE(), admin);
|
||||
await this.timelock.grantRole(await this.timelock.EXECUTOR_ROLE(), constants.ZERO_ADDRESS);
|
||||
await this.timelock.revokeRole(await this.timelock.TIMELOCK_ADMIN_ROLE(), deployer);
|
||||
await this.token.mint(voter, tokenSupply);
|
||||
await this.token.delegate(voter, { from: voter });
|
||||
});
|
||||
|
||||
shouldSupportInterfaces([
|
||||
'ERC165',
|
||||
'Governor',
|
||||
'GovernorTimelock',
|
||||
]);
|
||||
|
||||
it('doesn\'t accept ether transfers', async function () {
|
||||
await expectRevert.unspecified(web3.eth.sendTransaction({ from: voter, to: this.mock.address, value: 1 }));
|
||||
});
|
||||
|
||||
it('post deployment check', async function () {
|
||||
expect(await this.mock.name()).to.be.equal(name);
|
||||
expect(await this.mock.token()).to.be.equal(this.token.address);
|
||||
expect(await this.mock.votingDelay()).to.be.bignumber.equal('4');
|
||||
expect(await this.mock.votingPeriod()).to.be.bignumber.equal('16');
|
||||
expect(await this.mock.quorum(0)).to.be.bignumber.equal('0');
|
||||
|
||||
expect(await this.mock.timelock()).to.be.equal(this.timelock.address);
|
||||
});
|
||||
|
||||
describe('nominal', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[ this.receiver.address ],
|
||||
[ web3.utils.toWei('0') ],
|
||||
[ this.receiver.contract.methods.mockFunction().encodeABI() ],
|
||||
'<proposal description>',
|
||||
],
|
||||
voters: [
|
||||
{ voter: voter, support: Enums.VoteType.For },
|
||||
],
|
||||
steps: {
|
||||
queue: { delay: 3600 },
|
||||
},
|
||||
};
|
||||
});
|
||||
afterEach(async function () {
|
||||
const timelockid = await this.timelock.hashOperationBatch(
|
||||
...this.settings.proposal.slice(0, 3),
|
||||
'0x0',
|
||||
this.descriptionHash,
|
||||
);
|
||||
|
||||
expectEvent(
|
||||
this.receipts.propose,
|
||||
'ProposalCreated',
|
||||
{ proposalId: this.id },
|
||||
);
|
||||
expectEvent(
|
||||
this.receipts.queue,
|
||||
'ProposalQueued',
|
||||
{ proposalId: this.id },
|
||||
);
|
||||
await expectEvent.inTransaction(
|
||||
this.receipts.queue.transactionHash,
|
||||
this.timelock,
|
||||
'CallScheduled',
|
||||
{ id: timelockid },
|
||||
);
|
||||
expectEvent(
|
||||
this.receipts.execute,
|
||||
'ProposalExecuted',
|
||||
{ proposalId: this.id },
|
||||
);
|
||||
await expectEvent.inTransaction(
|
||||
this.receipts.execute.transactionHash,
|
||||
this.timelock,
|
||||
'CallExecuted',
|
||||
{ id: timelockid },
|
||||
);
|
||||
await expectEvent.inTransaction(
|
||||
this.receipts.execute.transactionHash,
|
||||
this.receiver,
|
||||
'MockFunctionCalled',
|
||||
);
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
|
||||
describe('executed by other proposer', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[ this.receiver.address ],
|
||||
[ web3.utils.toWei('0') ],
|
||||
[ this.receiver.contract.methods.mockFunction().encodeABI() ],
|
||||
'<proposal description>',
|
||||
],
|
||||
voters: [
|
||||
{ voter: voter, support: Enums.VoteType.For },
|
||||
],
|
||||
steps: {
|
||||
queue: { delay: 3600 },
|
||||
execute: { enable: false },
|
||||
},
|
||||
};
|
||||
});
|
||||
afterEach(async function () {
|
||||
await this.timelock.executeBatch(
|
||||
...this.settings.proposal.slice(0, 3),
|
||||
'0x0',
|
||||
this.descriptionHash,
|
||||
);
|
||||
|
||||
expect(await this.mock.state(this.id)).to.be.bignumber.equal(Enums.ProposalState.Executed);
|
||||
|
||||
await expectRevert(
|
||||
this.mock.execute(...this.settings.proposal.slice(0, -1), this.descriptionHash),
|
||||
'Governor: proposal not successful',
|
||||
);
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
|
||||
describe('not queued', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[ this.receiver.address ],
|
||||
[ web3.utils.toWei('0') ],
|
||||
[ this.receiver.contract.methods.mockFunction().encodeABI() ],
|
||||
'<proposal description>',
|
||||
],
|
||||
voters: [
|
||||
{ voter: voter, support: Enums.VoteType.For },
|
||||
],
|
||||
steps: {
|
||||
queue: { enable: false },
|
||||
execute: { error: 'TimelockController: operation is not ready' },
|
||||
},
|
||||
};
|
||||
});
|
||||
afterEach(async function () {
|
||||
expect(await this.mock.state(this.id)).to.be.bignumber.equal(Enums.ProposalState.Succeeded);
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
|
||||
describe('to early', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[ this.receiver.address ],
|
||||
[ web3.utils.toWei('0') ],
|
||||
[ this.receiver.contract.methods.mockFunction().encodeABI() ],
|
||||
'<proposal description>',
|
||||
],
|
||||
voters: [
|
||||
{ voter: voter, support: Enums.VoteType.For },
|
||||
],
|
||||
steps: {
|
||||
execute: { error: 'TimelockController: operation is not ready' },
|
||||
},
|
||||
};
|
||||
});
|
||||
afterEach(async function () {
|
||||
expect(await this.mock.state(this.id)).to.be.bignumber.equal(Enums.ProposalState.Queued);
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
|
||||
describe('re-queue / re-execute', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[ this.receiver.address ],
|
||||
[ web3.utils.toWei('0') ],
|
||||
[ this.receiver.contract.methods.mockFunction().encodeABI() ],
|
||||
'<proposal description>',
|
||||
],
|
||||
voters: [
|
||||
{ voter: voter, support: Enums.VoteType.For },
|
||||
],
|
||||
steps: {
|
||||
queue: { delay: 3600 },
|
||||
},
|
||||
};
|
||||
});
|
||||
afterEach(async function () {
|
||||
expect(await this.mock.state(this.id)).to.be.bignumber.equal(Enums.ProposalState.Executed);
|
||||
|
||||
await expectRevert(
|
||||
this.mock.queue(...this.settings.proposal.slice(0, -1), this.descriptionHash),
|
||||
'Governor: proposal not successful',
|
||||
);
|
||||
await expectRevert(
|
||||
this.mock.execute(...this.settings.proposal.slice(0, -1), this.descriptionHash),
|
||||
'Governor: proposal not successful',
|
||||
);
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
|
||||
describe('cancel before queue prevents scheduling', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[ this.receiver.address ],
|
||||
[ web3.utils.toWei('0') ],
|
||||
[ this.receiver.contract.methods.mockFunction().encodeABI() ],
|
||||
'<proposal description>',
|
||||
],
|
||||
voters: [
|
||||
{ voter: voter, support: Enums.VoteType.For },
|
||||
],
|
||||
steps: {
|
||||
queue: { enable: false },
|
||||
execute: { enable: false },
|
||||
},
|
||||
};
|
||||
});
|
||||
afterEach(async function () {
|
||||
expect(await this.mock.state(this.id)).to.be.bignumber.equal(Enums.ProposalState.Succeeded);
|
||||
|
||||
expectEvent(
|
||||
await this.mock.cancel(...this.settings.proposal.slice(0, -1), this.descriptionHash),
|
||||
'ProposalCanceled',
|
||||
{ proposalId: this.id },
|
||||
);
|
||||
|
||||
expect(await this.mock.state(this.id)).to.be.bignumber.equal(Enums.ProposalState.Canceled);
|
||||
|
||||
await expectRevert(
|
||||
this.mock.queue(...this.settings.proposal.slice(0, -1), this.descriptionHash),
|
||||
'Governor: proposal not successful',
|
||||
);
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
|
||||
describe('cancel after queue prevents execution', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[ this.receiver.address ],
|
||||
[ web3.utils.toWei('0') ],
|
||||
[ this.receiver.contract.methods.mockFunction().encodeABI() ],
|
||||
'<proposal description>',
|
||||
],
|
||||
voters: [
|
||||
{ voter: voter, support: Enums.VoteType.For },
|
||||
],
|
||||
steps: {
|
||||
queue: { delay: 3600 },
|
||||
execute: { enable: false },
|
||||
},
|
||||
};
|
||||
});
|
||||
afterEach(async function () {
|
||||
const timelockid = await this.timelock.hashOperationBatch(
|
||||
...this.settings.proposal.slice(0, 3),
|
||||
'0x0',
|
||||
this.descriptionHash,
|
||||
);
|
||||
|
||||
expect(await this.mock.state(this.id)).to.be.bignumber.equal(Enums.ProposalState.Queued);
|
||||
|
||||
const receipt = await this.mock.cancel(...this.settings.proposal.slice(0, -1), this.descriptionHash);
|
||||
expectEvent(
|
||||
receipt,
|
||||
'ProposalCanceled',
|
||||
{ proposalId: this.id },
|
||||
);
|
||||
await expectEvent.inTransaction(
|
||||
receipt.receipt.transactionHash,
|
||||
this.timelock,
|
||||
'Cancelled',
|
||||
{ id: timelockid },
|
||||
);
|
||||
|
||||
expect(await this.mock.state(this.id)).to.be.bignumber.equal(Enums.ProposalState.Canceled);
|
||||
|
||||
await expectRevert(
|
||||
this.mock.execute(...this.settings.proposal.slice(0, -1), this.descriptionHash),
|
||||
'Governor: proposal not successful',
|
||||
);
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
|
||||
describe('relay', function () {
|
||||
beforeEach(async function () {
|
||||
await this.token.mint(this.mock.address, 1);
|
||||
this.call = [
|
||||
this.token.address,
|
||||
0,
|
||||
this.token.contract.methods.transfer(other, 1).encodeABI(),
|
||||
];
|
||||
});
|
||||
|
||||
it('protected', async function () {
|
||||
await expectRevert(
|
||||
this.mock.relay(...this.call),
|
||||
'Governor: onlyGovernance',
|
||||
);
|
||||
});
|
||||
|
||||
describe('using workflow', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[
|
||||
this.mock.address,
|
||||
],
|
||||
[
|
||||
web3.utils.toWei('0'),
|
||||
],
|
||||
[
|
||||
this.mock.contract.methods.relay(...this.call).encodeABI(),
|
||||
],
|
||||
'<proposal description>',
|
||||
],
|
||||
voters: [
|
||||
{ voter: voter, support: Enums.VoteType.For },
|
||||
],
|
||||
steps: {
|
||||
queue: { delay: 7 * 86400 },
|
||||
},
|
||||
};
|
||||
|
||||
expect(await this.token.balanceOf(this.mock.address), 1);
|
||||
expect(await this.token.balanceOf(other), 0);
|
||||
});
|
||||
afterEach(async function () {
|
||||
expect(await this.token.balanceOf(this.mock.address), 0);
|
||||
expect(await this.token.balanceOf(other), 1);
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
});
|
||||
|
||||
describe('cancel on timelock is forwarded in state', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[ this.receiver.address ],
|
||||
[ web3.utils.toWei('0') ],
|
||||
[ this.receiver.contract.methods.mockFunction().encodeABI() ],
|
||||
'<proposal description>',
|
||||
],
|
||||
voters: [
|
||||
{ voter: voter, support: Enums.VoteType.For },
|
||||
],
|
||||
steps: {
|
||||
queue: { delay: 3600 },
|
||||
execute: { enable: false },
|
||||
},
|
||||
};
|
||||
});
|
||||
afterEach(async function () {
|
||||
const timelockid = await this.timelock.hashOperationBatch(
|
||||
...this.settings.proposal.slice(0, 3),
|
||||
'0x0',
|
||||
this.descriptionHash,
|
||||
);
|
||||
|
||||
expect(await this.mock.state(this.id)).to.be.bignumber.equal(Enums.ProposalState.Queued);
|
||||
|
||||
const receipt = await this.timelock.cancel(timelockid, { from: admin });
|
||||
expectEvent(
|
||||
receipt,
|
||||
'Cancelled',
|
||||
{ id: timelockid },
|
||||
);
|
||||
|
||||
expect(await this.mock.state(this.id)).to.be.bignumber.equal(Enums.ProposalState.Canceled);
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
|
||||
describe('updateTimelock', function () {
|
||||
beforeEach(async function () {
|
||||
this.newTimelock = await Timelock.new(3600, [], []);
|
||||
});
|
||||
|
||||
it('protected', async function () {
|
||||
await expectRevert(
|
||||
this.mock.updateTimelock(this.newTimelock.address),
|
||||
'Governor: onlyGovernance',
|
||||
);
|
||||
});
|
||||
|
||||
describe('using workflow', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[ this.mock.address ],
|
||||
[ web3.utils.toWei('0') ],
|
||||
[ this.mock.contract.methods.updateTimelock(this.newTimelock.address).encodeABI() ],
|
||||
'<proposal description>',
|
||||
],
|
||||
voters: [
|
||||
{ voter: voter, support: Enums.VoteType.For },
|
||||
],
|
||||
steps: {
|
||||
queue: { delay: 3600 },
|
||||
},
|
||||
};
|
||||
});
|
||||
afterEach(async function () {
|
||||
expectEvent(
|
||||
this.receipts.propose,
|
||||
'ProposalCreated',
|
||||
{ proposalId: this.id },
|
||||
);
|
||||
expectEvent(
|
||||
this.receipts.execute,
|
||||
'ProposalExecuted',
|
||||
{ proposalId: this.id },
|
||||
);
|
||||
expectEvent(
|
||||
this.receipts.execute,
|
||||
'TimelockChange',
|
||||
{ oldTimelock: this.timelock.address, newTimelock: this.newTimelock.address },
|
||||
);
|
||||
expect(await this.mock.timelock()).to.be.bignumber.equal(this.newTimelock.address);
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
});
|
||||
});
|
||||
122
test/governance/extensions/GovernorWeightQuorumFraction.test.js
Normal file
122
test/governance/extensions/GovernorWeightQuorumFraction.test.js
Normal file
@ -0,0 +1,122 @@
|
||||
const { BN, expectEvent, time } = require('@openzeppelin/test-helpers');
|
||||
const Enums = require('../../helpers/enums');
|
||||
|
||||
const {
|
||||
runGovernorWorkflow,
|
||||
} = require('./../GovernorWorkflow.behavior');
|
||||
|
||||
const Token = artifacts.require('ERC20VotesMock');
|
||||
const Governor = artifacts.require('GovernorMock');
|
||||
const CallReceiver = artifacts.require('CallReceiverMock');
|
||||
|
||||
contract('GovernorVotesQuorumFraction', function (accounts) {
|
||||
const [ owner, voter1, voter2, voter3, voter4 ] = accounts;
|
||||
|
||||
const name = 'OZ-Governor';
|
||||
// const version = '1';
|
||||
const tokenName = 'MockToken';
|
||||
const tokenSymbol = 'MTKN';
|
||||
const tokenSupply = new BN(web3.utils.toWei('100'));
|
||||
const ratio = new BN(8); // percents
|
||||
const newRatio = new BN(6); // percents
|
||||
|
||||
beforeEach(async function () {
|
||||
this.owner = owner;
|
||||
this.token = await Token.new(tokenName, tokenSymbol);
|
||||
this.mock = await Governor.new(name, this.token.address, 4, 16, ratio);
|
||||
this.receiver = await CallReceiver.new();
|
||||
await this.token.mint(owner, tokenSupply);
|
||||
await this.token.delegate(voter1, { from: voter1 });
|
||||
await this.token.delegate(voter2, { from: voter2 });
|
||||
await this.token.delegate(voter3, { from: voter3 });
|
||||
await this.token.delegate(voter4, { from: voter4 });
|
||||
});
|
||||
|
||||
it('deployment check', async function () {
|
||||
expect(await this.mock.name()).to.be.equal(name);
|
||||
expect(await this.mock.token()).to.be.equal(this.token.address);
|
||||
expect(await this.mock.votingDelay()).to.be.bignumber.equal('4');
|
||||
expect(await this.mock.votingPeriod()).to.be.bignumber.equal('16');
|
||||
expect(await this.mock.quorum(0)).to.be.bignumber.equal('0');
|
||||
expect(await this.mock.quorumNumerator()).to.be.bignumber.equal(ratio);
|
||||
expect(await this.mock.quorumDenominator()).to.be.bignumber.equal('100');
|
||||
expect(await time.latestBlock().then(blockNumber => this.mock.quorum(blockNumber.subn(1))))
|
||||
.to.be.bignumber.equal(tokenSupply.mul(ratio).divn(100));
|
||||
});
|
||||
|
||||
describe('quroum not reached', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[ this.receiver.address ],
|
||||
[ web3.utils.toWei('0') ],
|
||||
[ this.receiver.contract.methods.mockFunction().encodeABI() ],
|
||||
'<proposal description>',
|
||||
],
|
||||
tokenHolder: owner,
|
||||
voters: [
|
||||
{ voter: voter1, weight: web3.utils.toWei('1'), support: Enums.VoteType.For },
|
||||
],
|
||||
steps: {
|
||||
execute: { error: 'Governor: proposal not successful' },
|
||||
},
|
||||
};
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
|
||||
describe('update quorum ratio through proposal', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[ this.mock.address ],
|
||||
[ web3.utils.toWei('0') ],
|
||||
[ this.mock.contract.methods.updateQuorumNumerator(newRatio).encodeABI() ],
|
||||
'<proposal description>',
|
||||
],
|
||||
tokenHolder: owner,
|
||||
voters: [
|
||||
{ voter: voter1, weight: tokenSupply, support: Enums.VoteType.For },
|
||||
],
|
||||
};
|
||||
});
|
||||
afterEach(async function () {
|
||||
await expectEvent.inTransaction(
|
||||
this.receipts.execute.transactionHash,
|
||||
this.mock,
|
||||
'QuorumNumeratorUpdated',
|
||||
{
|
||||
oldQuorumNumerator: ratio,
|
||||
newQuorumNumerator: newRatio,
|
||||
},
|
||||
);
|
||||
|
||||
expect(await this.mock.quorumNumerator()).to.be.bignumber.equal(newRatio);
|
||||
expect(await this.mock.quorumDenominator()).to.be.bignumber.equal('100');
|
||||
expect(await time.latestBlock().then(blockNumber => this.mock.quorum(blockNumber.subn(1))))
|
||||
.to.be.bignumber.equal(tokenSupply.mul(newRatio).divn(100));
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
|
||||
describe('update quorum over the maximum', function () {
|
||||
beforeEach(async function () {
|
||||
this.settings = {
|
||||
proposal: [
|
||||
[ this.mock.address ],
|
||||
[ web3.utils.toWei('0') ],
|
||||
[ this.mock.contract.methods.updateQuorumNumerator(new BN(101)).encodeABI() ],
|
||||
'<proposal description>',
|
||||
],
|
||||
tokenHolder: owner,
|
||||
voters: [
|
||||
{ voter: voter1, weight: tokenSupply, support: Enums.VoteType.For },
|
||||
],
|
||||
steps: {
|
||||
execute: { error: 'GovernorVotesQuorumFraction: quorumNumerator over quorumDenominator' },
|
||||
},
|
||||
};
|
||||
});
|
||||
runGovernorWorkflow();
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user