NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid validating ECDSA signatures for addresses with code in SignatureChecker (#4951)

Browse Source 
Co-authored-by: ernestognw <ernestognw@gmail.com>
This commit is contained in:
Hadrien Croubois
2024-03-14 17:27:15 +01:00
committed by GitHub
parent 6b4ec6c6c6
commit 33ea1111b0
2 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/yellow-moles-hammer.md Normal file
View File

@ -0,0 +1,5 @@
---
'openzeppelin-solidity': minor
---
`SignatureChecker`: refactor `isValidSignatureNow` to avoid validating ECDSA signatures if there is code deployed at the signer's address.

10
contracts/utils/cryptography/SignatureChecker.sol
View File

@ -20,10 +20,12 @@ library SignatureChecker {
* change through time. It could return true at block N and false at block N+1 (or the opposite). * change through time. It could return true at block N and false at block N+1 (or the opposite).
*/ */
function isValidSignatureNow(address signer, bytes32 hash, bytes memory signature) internal view returns (bool) { function isValidSignatureNow(address signer, bytes32 hash, bytes memory signature) internal view returns (bool) {
(address recovered, ECDSA.RecoverError error, ) = ECDSA.tryRecover(hash, signature); if (signer.code.length == 0) {
return (address recovered, ECDSA.RecoverError err, ) = ECDSA.tryRecover(hash, signature);
(error == ECDSA.RecoverError.NoError && recovered == signer) || return err == ECDSA.RecoverError.NoError && recovered == signer;
isValidERC1271SignatureNow(signer, hash, signature); } else {
return isValidERC1271SignatureNow(signer, hash, signature);
}
} }
/** /**