From 2f6c8b05f6d73141629bed00d7779eda0ccf4b9b Mon Sep 17 00:00:00 2001
From: Justus Perlwitz <justuswilhelm@users.noreply.github.com>
Date: Fri, 27 Jul 2018 11:53:06 +0900
Subject: [PATCH] Test/assertRevert: Fix late return bug (#1123)

We now ensure that if an exception is thrown while awaiting the promise,
the exception _has_ to be a revert. We throw 'Expected revert not
received' only afterwards. This solves any problems with confusing the
word 'revert'.

Fix #775
---
 test/helpers/assertRevert.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/test/helpers/assertRevert.js b/test/helpers/assertRevert.js
index b82e0f195..063a873e3 100644
--- a/test/helpers/assertRevert.js
+++ b/test/helpers/assertRevert.js
@@ -1,11 +1,12 @@
 async function assertRevert (promise) {
   try {
     await promise;
-    assert.fail('Expected revert not received');
   } catch (error) {
     const revertFound = error.message.search('revert') >= 0;
     assert(revertFound, `Expected "revert", got ${error} instead`);
+    return;
   }
+  assert.fail('Expected revert not received');
 }
 
 module.exports = {