NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve encapsulation on ERC165 and update code style guide (#1379)

Browse Source 
* use prefix underscore for internal state variables

* make _supportedInterfaces private

(cherry picked from commit 03dfb2965c)
This commit is contained in:
Mikhail Melnik
2018-10-13 01:13:36 +03:00
committed by Leo Arias
parent 10a5864fdf
commit 2c40ffa011
3 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
CODE_STYLE.md
View File

@ -23,6 +23,7 @@ Any exception or additions specific to our project are documented below.
``` ```
contract TestContract { contract TestContract {
uint256 private _privateVar; uint256 private _privateVar;
uint256 internal _internalVar;
} }
``` ```

2
contracts/introspection/ERC165.sol
View File

@ -18,7 +18,7 @@ contract ERC165 is IERC165 {
/** /**
* @dev a mapping of interface id to whether or not it's supported * @dev a mapping of interface id to whether or not it's supported
*/ */
mapping(bytes4 => bool) internal _supportedInterfaces; mapping(bytes4 => bool) private _supportedInterfaces;
/** /**
* @dev A contract implementing SupportsInterfaceWithLookup * @dev A contract implementing SupportsInterfaceWithLookup

6
contracts/mocks/ERC165/ERC165InterfacesSupported.sol
View File

@ -21,7 +21,7 @@ contract SupportsInterfaceWithLookupMock is IERC165 {
/** /**
* @dev a mapping of interface id to whether or not it's supported * @dev a mapping of interface id to whether or not it's supported
*/ */
mapping(bytes4 => bool) internal supportedInterfaces; mapping(bytes4 => bool) private _supportedInterfaces;
/** /**
* @dev A contract implementing SupportsInterfaceWithLookup * @dev A contract implementing SupportsInterfaceWithLookup
@ -41,7 +41,7 @@ contract SupportsInterfaceWithLookupMock is IERC165 {
view view
returns (bool) returns (bool)
{ {
return supportedInterfaces[interfaceId]; return _supportedInterfaces[interfaceId];
} }
/** /**
@ -51,7 +51,7 @@ contract SupportsInterfaceWithLookupMock is IERC165 {
internal internal
{ {
require(interfaceId != 0xffffffff); require(interfaceId != 0xffffffff);
supportedInterfaces[interfaceId] = true; _supportedInterfaces[interfaceId] = true;
} }
} }