NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use clones for testing non ERC1967 proxies (#4371)

Browse Source
This commit is contained in:
Hadrien Croubois
2023-06-20 10:01:30 +02:00
committed by GitHub
parent 365aca6d60
commit 2271e2c58d
1 changed files with 15 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
test/proxy/utils/UUPSUpgradeable.test.js
View File

@ -7,7 +7,7 @@ const UUPSUpgradeableMock = artifacts.require('UUPSUpgradeableMock');
const UUPSUpgradeableUnsafeMock = artifacts.require('UUPSUpgradeableUnsafeMock'); const UUPSUpgradeableUnsafeMock = artifacts.require('UUPSUpgradeableUnsafeMock');
const NonUpgradeableMock = artifacts.require('NonUpgradeableMock'); const NonUpgradeableMock = artifacts.require('NonUpgradeableMock');
const UUPSUnsupportedProxiableUUID = artifacts.require('UUPSUnsupportedProxiableUUID'); const UUPSUnsupportedProxiableUUID = artifacts.require('UUPSUnsupportedProxiableUUID');
const Address = artifacts.require('$Address'); const Clones = artifacts.require('$Clones');
contract('UUPSUpgradeable', function () { contract('UUPSUpgradeable', function () {
before(async function () { before(async function () {
@ -16,7 +16,8 @@ contract('UUPSUpgradeable', function () {
this.implUpgradeUnsafe = await UUPSUpgradeableUnsafeMock.new(); this.implUpgradeUnsafe = await UUPSUpgradeableUnsafeMock.new();
this.implUpgradeNonUUPS = await NonUpgradeableMock.new(); this.implUpgradeNonUUPS = await NonUpgradeableMock.new();
this.implUnsupportedUUID = await UUPSUnsupportedProxiableUUID.new(); this.implUnsupportedUUID = await UUPSUnsupportedProxiableUUID.new();
this.helper = await Address.new(); // Used for testing non ERC1967 compliant proxies (clones are proxies that don't use the ERC1967 implementation slot)
this.cloneFactory = await Clones.new();
}); });
beforeEach(async function () { beforeEach(async function () {
@ -65,22 +66,26 @@ contract('UUPSUpgradeable', function () {
}); });
it('calling upgradeTo from a contract that is not an ERC1967 proxy (with the right implementation) reverts', async function () { it('calling upgradeTo from a contract that is not an ERC1967 proxy (with the right implementation) reverts', async function () {
const receipt = await this.cloneFactory.$clone(this.implUpgradeOk.address);
const instance = await UUPSUpgradeableMock.at(
receipt.logs.find(({ event }) => event === 'return$clone').args.instance,
);
await expectRevertCustomError( await expectRevertCustomError(
this.helper.$functionDelegateCall( instance.upgradeTo(this.implUpgradeUnsafe.address),
this.implUpgradeOk.address,
this.implUpgradeOk.contract.methods.upgradeTo(this.implUpgradeUnsafe.address).encodeABI(),
),
'UUPSUnauthorizedCallContext', 'UUPSUnauthorizedCallContext',
[], [],
); );
}); });
it('calling upgradeToAndCall from a contract that is not an ERC1967 proxy (with the right implementation) reverts', async function () { it('calling upgradeToAndCall from a contract that is not an ERC1967 proxy (with the right implementation) reverts', async function () {
const receipt = await this.cloneFactory.$clone(this.implUpgradeOk.address);
const instance = await UUPSUpgradeableMock.at(
receipt.logs.find(({ event }) => event === 'return$clone').args.instance,
);
await expectRevertCustomError( await expectRevertCustomError(
this.helper.$functionDelegateCall( instance.upgradeToAndCall(this.implUpgradeUnsafe.address, '0x'),
this.implUpgradeOk.address,
this.implUpgradeOk.contract.methods.upgradeToAndCall(this.implUpgradeUnsafe.address, '0x').encodeABI(),
),
'UUPSUnauthorizedCallContext', 'UUPSUnauthorizedCallContext',
[], [],
); );