NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

No longer assigning awaits to temporary variables. (#1216)

Browse Source
This commit is contained in:
Nicolás Venturo
2018-08-17 16:10:40 -03:00
committed by GitHub
parent df9426f989
commit 20cf885430
43 changed files with 231 additions and 467 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
test/library/ECRecovery.test.js
View File

@ -20,8 +20,7 @@ contract('ECRecovery', function ([_, anyone]) {
const message = web3.sha3(TEST_MESSAGE);
// eslint-disable-next-line max-len
const signature = '0x5d99b6f7f6d1f73d1a26497f2b1c89b24c0993913f86e9a2d02cd69887d9c94f3c880358579d811b21dd1b7fd9bb01c1d81d10e69f0384e675c32b39643be89200';
const addrRecovered = await ecrecovery.recover(message, signature);
addrRecovered.should.eq(signer);
(await ecrecovery.recover(message, signature)).should.eq(signer);
});
it('recover v1', async function () {
@ -30,8 +29,7 @@ contract('ECRecovery', function ([_, anyone]) {
const message = web3.sha3(TEST_MESSAGE);
// eslint-disable-next-line max-len
const signature = '0x331fe75a821c982f9127538858900d87d3ec1f9f737338ad67cad133fa48feff48e6fa0c18abc62e42820f05943e47af3e9fbe306ce74d64094bdf1691ee53e001';
const addrRecovered = await ecrecovery.recover(message, signature);
addrRecovered.should.eq(signer);
(await ecrecovery.recover(message, signature)).should.eq(signer);
});
it('recover using web3.eth.sign()', async function () {
@ -39,11 +37,10 @@ contract('ECRecovery', function ([_, anyone]) {
const signature = signMessage(anyone, web3.sha3(TEST_MESSAGE));
// Recover the signer address from the generated message and signature.
const addrRecovered = await ecrecovery.recover(
(await ecrecovery.recover(
hashMessage(TEST_MESSAGE),
signature
);
addrRecovered.should.eq(anyone);
)).should.eq(anyone);
});
it('recover using web3.eth.sign() should return wrong signer', async function () {
@ -51,8 +48,7 @@ contract('ECRecovery', function ([_, anyone]) {
const signature = signMessage(anyone, web3.sha3(TEST_MESSAGE));
// Recover the signer address from the generated message and wrong signature.
const addrRecovered = await ecrecovery.recover(hashMessage('Nope'), signature);
addrRecovered.should.not.eq(anyone);
(await ecrecovery.recover(hashMessage('Nope'), signature)).should.not.eq(anyone);
});
it('recover should revert when a small hash is sent', async function () {
@ -70,8 +66,7 @@ contract('ECRecovery', function ([_, anyone]) {
context('toEthSignedMessage', () => {
it('should prefix hashes correctly', async function () {
const hashedMessage = web3.sha3(TEST_MESSAGE);
const ethMessage = await ecrecovery.toEthSignedMessageHash(hashedMessage);
ethMessage.should.eq(hashMessage(TEST_MESSAGE));
(await ecrecovery.toEthSignedMessageHash(hashedMessage)).should.eq(hashMessage(TEST_MESSAGE));
});
});
});

12
test/library/Math.test.js
View File

@ -16,25 +16,21 @@ contract('Math', function () {
describe('max', function () {
it('is correctly detected in first argument position', async function () {
const result = await this.math.max(max, min);
result.should.be.bignumber.equal(max);
(await this.math.max(max, min)).should.be.bignumber.equal(max);
});
it('is correctly detected in second argument position', async function () {
const result = await this.math.max(min, max);
result.should.be.bignumber.equal(max);
(await this.math.max(min, max)).should.be.bignumber.equal(max);
});
});
describe('min', function () {
it('is correctly detected in first argument position', async function () {
const result = await this.math.min(min, max);
result.should.be.bignumber.equal(min);
(await this.math.min(min, max)).should.be.bignumber.equal(min);
});
it('is correctly detected in second argument position', async function () {
const result = await this.math.min(max, min);
result.should.be.bignumber.equal(min);
(await this.math.min(max, min)).should.be.bignumber.equal(min);
});
});

9
test/library/MerkleProof.test.js
View File

@ -24,8 +24,7 @@ contract('MerkleProof', function () {
const leaf = bufferToHex(sha3(elements[0]));
const result = await merkleProof.verifyProof(proof, root, leaf);
result.should.be.true;
(await merkleProof.verifyProof(proof, root, leaf)).should.be.true;
});
it('should return false for an invalid Merkle proof', async function () {
@ -41,8 +40,7 @@ contract('MerkleProof', function () {
const badProof = badMerkleTree.getHexProof(badElements[0]);
const result = await merkleProof.verifyProof(badProof, correctRoot, correctLeaf);
result.should.be.false;
(await merkleProof.verifyProof(badProof, correctRoot, correctLeaf)).should.be.false;
});
it('should return false for a Merkle proof of invalid length', async function () {
@ -56,8 +54,7 @@ contract('MerkleProof', function () {
const leaf = bufferToHex(sha3(elements[0]));
const result = await merkleProof.verifyProof(badProof, root, leaf);
result.should.be.false;
(await merkleProof.verifyProof(badProof, root, leaf)).should.be.false;
});
});
});