NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Ownable behavior (#929)

Browse Source 
* added function to renounce ownership

* Provide an Ownable behavior for testing (#905)

* Fix indentation

* Convert to use should assertions
This commit is contained in:
Paweł Winnicki
2018-05-09 02:33:37 +02:00
committed by Matt Condon
parent 4223c9d50e
commit 20b85be6aa
2 changed files with 54 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
test/ownership/Ownable.behaviour.js Normal file
View File

@ -0,0 +1,50 @@
import EVMRevert from '../helpers/EVMRevert';
const ZERO_ADDRESS = '0x0000000000000000000000000000000000000000';
require('chai')
.use(require('chai-as-promised'))
.should();
export default function (accounts) {
describe('as an ownable', function () {
it('should have an owner', async function () {
let owner = await this.ownable.owner();
owner.should.not.eq(ZERO_ADDRESS);
});
it('changes owner after transfer', async function () {
let other = accounts[1];
await this.ownable.transferOwnership(other);
let owner = await this.ownable.owner();
owner.should.eq(other);
});
it('should prevent non-owners from transfering', async function () {
const other = accounts[2];
const owner = await this.ownable.owner.call();
owner.should.not.eq(other);
await this.ownable.transferOwnership(other, { from: other }).should.be.rejectedWith(EVMRevert);
});
it('should guard ownership against stuck state', async function () {
let originalOwner = await this.ownable.owner();
await this.ownable.transferOwnership(null, { from: originalOwner }).should.be.rejectedWith(EVMRevert);
});
it('loses owner after renouncement', async function () {
await this.ownable.renounceOwnership();
let owner = await this.ownable.owner();
owner.should.eq(ZERO_ADDRESS);
});
it('should prevent non-owners from renouncement', async function () {
const other = accounts[2];
const owner = await this.ownable.owner.call();
owner.should.not.eq(other);
await this.ownable.renounceOwnership({ from: other }).should.be.rejectedWith(EVMRevert);
});
});
};

49
test/ownership/Ownable.test.js
View File

@ -1,52 +1,11 @@
import shouldBehaveLikeOwnable from './Ownable.behaviour';
import assertRevert from '../helpers/assertRevert';
var Ownable = artifacts.require('Ownable');
const ZERO_ADDRESS = '0x0000000000000000000000000000000000000000';
const Ownable = artifacts.require('Ownable');
contract('Ownable', function (accounts) {
let ownable;
beforeEach(async function () {
ownable = await Ownable.new();
this.ownable = await Ownable.new();
});
it('should have an owner', async function () {
let owner = await ownable.owner();
assert.isTrue(owner !== 0);
});
it('changes owner after transfer', async function () {
let other = accounts[1];
await ownable.transferOwnership(other);
let owner = await ownable.owner();
assert.isTrue(owner === other);
});
it('should prevent non-owners from transfering', async function () {
const other = accounts[2];
const owner = await ownable.owner.call();
assert.isTrue(owner !== other);
await assertRevert(ownable.transferOwnership(other, { from: other }));
});
it('should guard ownership against stuck state', async function () {
let originalOwner = await ownable.owner();
await assertRevert(ownable.transferOwnership(null, { from: originalOwner }));
});
it('loses owner after renouncement', async function () {
await ownable.renounceOwnership();
let owner = await ownable.owner();
assert.isTrue(owner === ZERO_ADDRESS);
});
it('should prevent non-owners from renouncement', async function () {
const other = accounts[2];
const owner = await ownable.owner.call();
assert.isTrue(owner !== other);
await assertRevert(ownable.renounceOwnership({ from: other }));
});
shouldBehaveLikeOwnable(accounts);
});