NoBey/openzeppelin-contracts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Roles.add and remove now require pre-conditions on the account. (#1421)

Browse Source 
(cherry picked from commit 3bd30f7382)
This commit is contained in:
Nicolás Venturo
2018-10-16 17:20:33 -03:00
committed by Leo Arias
parent e990525c2e
commit 1b79b536cd
3 changed files with 14 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
test/access/Roles.test.js
View File

@ -29,10 +29,9 @@ contract('Roles', function ([_, authorized, otherAuthorized, anyone]) {
(await this.roles.has(anyone)).should.equal(false);
});
it('adds roles to an already-assigned account', async function () {
it('reverts when adding roles to an already assigned account', async function () {
await this.roles.add(authorized);
await this.roles.add(authorized);
(await this.roles.has(authorized)).should.equal(true);
await shouldFail.reverting(this.roles.add(authorized));
});
it('reverts when adding roles to the null account', async function () {
@ -54,8 +53,8 @@ contract('Roles', function ([_, authorized, otherAuthorized, anyone]) {
(await this.roles.has(otherAuthorized)).should.equal(true);
});
it('doesn\'t revert when removing unassigned roles', async function () {
await this.roles.remove(anyone);
it('reverts when removing unassigned roles', async function () {
await shouldFail.reverting(this.roles.remove(anyone));
});
it('reverts when removing roles from the null account', async function () {